nastra merged PR #9122:
URL: https://github.com/apache/iceberg/pull/9122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra commented on PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#issuecomment-1825872962
> > > Btw, should I squash the commits together or you will do that when
merging the pr?
> >
> >
> > commits will be squashed when the PR is getting merged, so it's up to
you if
lisirrx commented on PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#issuecomment-1825810278
> > Btw, should I squash the commits together or you will do that when
merging the pr?
>
> commits will be squashed when the PR is getting merged, so it's up to you
if you want to
nastra commented on PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#issuecomment-1822571206
> Btw, should I squash the commits together or you will do that when merging
the pr?
commits will be squashed when the PR is getting merged, so it's up to you if
you want to squash
lisirrx commented on PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#issuecomment-1822488153
> just a few small things to fix, but overall this LGTM.
>
> I also checked how the env variables are being used and they are not set
by our CI. They were introduced by #3687, so pi
nastra commented on code in PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#discussion_r1401773295
##
aliyun/src/test/java/org/apache/iceberg/aliyun/TestAliyunClientFactories.java:
##
@@ -22,43 +22,45 @@
import java.util.Map;
import org.apache.iceberg.relocated.com.
lisirrx commented on code in PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#discussion_r1401459825
##
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/AliyunOSSExtension.java:
##
@@ -39,18 +39,13 @@ default String testBucketName() {
}
@Override
- default S
lisirrx commented on code in PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#discussion_r1401456890
##
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/AliyunOSSExtension.java:
##
@@ -39,18 +39,13 @@ default String testBucketName() {
}
@Override
- default S
nastra commented on code in PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#discussion_r1400943843
##
build.gradle:
##
@@ -17,7 +17,9 @@
* under the License.
*/
+
Review Comment:
unnecessary changes here and below
##
aliyun/src/test/java/org/apach
lisirrx opened a new pull request, #9122:
URL: https://github.com/apache/iceberg/pull/9122
Switch iceberg-aliyun's tests to Junit5
Fix: #9081
@nastra Hi, I have changed all of the junit4 code to junit5 with AssertJ,
but I have a question here: To fit the Extension class of Junit5, I c
10 matches
Mail list logo
