lisirrx commented on code in PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#discussion_r1401456890
##########
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/AliyunOSSExtension.java:
##########
@@ -39,18 +39,13 @@ default String testBucketName() {
}
@Override
- default Statement apply(Statement base, Description description) {
- return new Statement() {
- @Override
- public void evaluate() throws Throwable {
- start();
- try {
- base.evaluate();
- } finally {
- stop();
- }
- }
- };
+ default void afterAll(ExtensionContext context) throws Exception {
+ stop();
+ }
+
+ @Override
+ default void beforeAll(ExtensionContext context) throws Exception {
Review Comment:
`AliyunOSSExtension` is an interface. If we want it to have a common method
for it's implement, I guess we could only use such way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
