lisirrx opened a new pull request, #9122:
URL: https://github.com/apache/iceberg/pull/9122
   Switch iceberg-aliyun's tests to Junit5
   Fix: #9081 
   @nastra Hi, I have changed all of the junit4 code to junit5 with AssertJ, 
but I have a question here: To fit the Extension class of Junit5, I changed 
most of the term 'Rule' to 'Extension', but there is a system env variable in 
`org/apache/iceberg/aliyun/TestUtility.java` called 
`ALIYUN_TEST_OSS_TEST_RULE_CLASS`.
   I don't know where the CI system runs, and how the variable is set. So I'm 
not sure if I should change this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to