lisirrx commented on PR #9122: URL: https://github.com/apache/iceberg/pull/9122#issuecomment-1822488153
> just a few small things to fix, but overall this LGTM. > > I also checked how the env variables are being used and they are not set by our CI. They were introduced by #3687, so pinging @openinx to also have a look at the proposed changes here. Thank you for your patient review. I'm sorry for introducing unnecessary blank lines. I will pay attention to this issue when writing code in the future. If I understand correctly, will the integration test of this package only run locally on the developer's computer? I ran these tests successfully with my own Aliyun AK/SK. Maybe let's wait for @openinx ‘s opinion. Btw, should I squash the commits together or you will do that when merging the pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
