rdblue commented on PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#issuecomment-2635466295
I see the other PRs that replaced this one referenced, but the Spark one is
missing: https://github.com/apache/iceberg/pull/12160
--
This is an automated message from the Apache Git Se
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1937761076
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -497,12 +680,46 @@ file:
-This binar
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1937555672
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the
following in its NOTICE file
---
manuzhang commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1937547525
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the
following in its NOTICE file
--
jbonofre closed pull request #12095: Add relevant NOTICE portions from ALv2
bundled dependencies
URL: https://github.com/apache/iceberg/pull/12095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jbonofre commented on PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#issuecomment-2627356032
To facilitate the review, I close this PR, and I will open one PR per module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ajantha-bhat commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1937104605
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -497,12 +680,46 @@ file:
-This b
ajantha-bhat commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1937104605
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -497,12 +680,46 @@ file:
-This b
jbonofre commented on PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#issuecomment-2626806494
So, let me take a step back on this PR, overriding with the minimum required
changes (formatting can come later).
--
This is an automated message from the Apache Git Service.
To resp
jbonofre commented on PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#issuecomment-2626767026
@rdblue ok fair. So let me use another approach:
1. Let me create a summary of my findings and share with you.
2. I agree the reformating is not required (I thought it's what you a
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936947396
##
spark/v3.5/spark-runtime/LICENSE:
##
@@ -203,109 +203,78 @@
-This binary ar
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936947785
##
spark/v3.5/spark-runtime/LICENSE:
##
@@ -203,109 +203,78 @@
-This binary ar
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936947179
##
spark/v3.5/spark-runtime/LICENSE:
##
@@ -582,66 +460,48 @@ License text:
Thi
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936945527
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -82,42 +245,7 @@ NOTICE file:
-This
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936944256
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the
following in its NOTICE file
---
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936939199
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -497,12 +680,46 @@ file:
-This binar
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936458957
##
spark/v3.5/spark-runtime/LICENSE:
##
@@ -203,109 +203,78 @@
-This binary arti
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936456243
##
spark/v3.5/spark-runtime/LICENSE:
##
@@ -203,109 +203,78 @@
-This binary arti
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936454435
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -497,12 +680,46 @@ file:
-Th
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936448470
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -82,42 +245,7 @@ NOTICE file:
-This bi
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936437048
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the
following in its NOTICE file
-
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936437048
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the
following in its NOTICE file
-
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936424888
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -497,12 +680,46 @@ file:
-This binary
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936424888
##
spark/v3.5/spark-runtime/NOTICE:
##
@@ -497,12 +680,46 @@ file:
-This binary
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936114817
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +103,143 @@ This binary artifact includes Apache ORC with the
following in its NOTICE file:
--
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936109448
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +103,143 @@ This binary artifact includes Apache ORC with the
following in its NOTICE file:
---
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936103070
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +103,143 @@ This binary artifact includes Apache ORC with the
following in its NOTICE file:
--
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936099857
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,94 @@ The Apache Software Foundation (http://www.apache.org/).
--
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936098464
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/).
-
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936095768
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,94 @@ The Apache Software Foundation (http://www.apache.org/).
-
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935966493
##
azure-bundle/NOTICE:
##
@@ -7,24 +6,240 @@ The Apache Software Foundation (http://www.apache.org/).
--
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935960403
##
azure-bundle/NOTICE:
##
@@ -7,24 +6,240 @@ The Apache Software Foundation (http://www.apache.org/).
--
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935956733
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +57,143 @@ This binary artifact includes Apache ORC with the following
in its NOTICE file:
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935956204
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/).
--
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935950971
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/).
--
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935947656
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +57,143 @@ This binary artifact includes Apache ORC with the following
in its NOTICE file:
---
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935946610
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/).
-
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935945294
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/).
-
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935942629
##
azure-bundle/NOTICE:
##
@@ -7,24 +6,240 @@ The Apache Software Foundation (http://www.apache.org/).
-
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935638374
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/).
--
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935634814
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -7,10 +6,48 @@ The Apache Software Foundation (http://www.apache.org/).
-
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935633940
##
flink/v1.20/flink-runtime/LICENSE:
##
@@ -203,105 +203,121 @@
-This binary art
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1934558928
##
spark/v3.5/spark-runtime/LICENSE:
##
@@ -456,95 +380,49 @@ License text:
-T
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1934381374
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +57,143 @@ This binary artifact includes Apache ORC with the following
in its NOTICE file:
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1934353320
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +58,143 @@ This binary artifact includes Apache ORC with the following
in its NOTICE file:
jbonofre commented on PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#issuecomment-2622467451
FYI, I checked/fixed/updates spark-runtime `LICENSE` and `NOTICE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1934209301
##
flink/v1.20/flink-runtime/NOTICE:
##
@@ -20,7 +58,143 @@ This binary artifact includes Apache ORC with the following
in its NOTICE file:
jbonofre commented on PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#issuecomment-2622082894
@amogh-jahagirdar @rdblue @Fokko I fixed the versions in the bundle jar
files. I added fixed on flink-runtime. I'm checking/updating LICENSE/NOTICE in
spark-runtime now.
--
This is
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1933380621
##
aws-bundle/NOTICE:
##
@@ -101,3 +100,252 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1933347495
##
gcp-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (GCP Bundle)
Review Comment:
I agree.
--
This is an automated message from the Apa
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932837482
##
azure-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (Azure bundle)
Review Comment:
do we want to keep the empty line ? I don't see the r
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1933045814
##
gcp-bundle/NOTICE:
##
@@ -29,72 +28,106 @@ from the source code management (SCM) system project uses.
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932981950
##
gcp-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (GCP Bundle)
Review Comment:
I'd say no empty first line (and it should be con
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932838112
##
gcp-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (GCP Bundle)
Review Comment:
do we want to keep this empty first line ?
--
This is
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932837482
##
azure-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (Azure bundle)
Review Comment:
do we want to keep the empty line ? I mean I don't se
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932831211
##
azure-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (Azure bundle)
Review Comment:
There's a new line on the AWS bundle:
https://git
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932557613
##
azure-bundle/NOTICE:
##
@@ -28,3 +27,272 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932559418
##
azure-bundle/NOTICE:
##
@@ -28,3 +27,272 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932644033
##
aws-bundle/NOTICE:
##
@@ -101,3 +100,252 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932643236
##
gcp-bundle/NOTICE:
##
@@ -29,72 +28,106 @@ from the source code management (SCM) system project uses.
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932598555
##
gcp-bundle/NOTICE:
##
@@ -29,72 +28,106 @@ from the source code management (SCM) system project uses.
--
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932594836
##
azure-bundle/NOTICE:
##
@@ -28,3 +27,272 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found f
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932594343
##
aws-bundle/NOTICE:
##
@@ -1,25 +1,24 @@
-Apache Iceberg
+Apache Iceberg (AWS Bundle)
Review Comment:
Yes, no problem to be generic and as it's in the artifa
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932587756
##
aws-bundle/NOTICE:
##
@@ -101,3 +100,252 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found f
rdblue commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932571477
##
aws-bundle/NOTICE:
##
@@ -1,25 +1,24 @@
-Apache Iceberg
+Apache Iceberg (AWS Bundle)
Review Comment:
Why is this change necessary? It is clear from its inclus
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932559312
##
azure-bundle/NOTICE:
##
@@ -28,3 +27,272 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932557613
##
azure-bundle/NOTICE:
##
@@ -28,3 +27,272 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may be found
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932548242
##
gcp-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (GCP Bundle)
Review Comment:
What do you mean ? 😄
--
This is an automated message
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932547837
##
azure-bundle/NOTICE:
##
@@ -1,5 +1,4 @@
-
-Apache Iceberg
+Apache Iceberg (Azure bundle)
Review Comment:
What do you mean ? 😄
--
This is an automated mes
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932543338
##
aws-bundle/NOTICE:
##
@@ -1,25 +1,24 @@
-Apache Iceberg
+Apache Iceberg (AWS Bundle)
Copyright 2017-2025 The Apache Software Foundation
This product include
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932543338
##
aws-bundle/NOTICE:
##
@@ -1,25 +1,24 @@
-Apache Iceberg
+Apache Iceberg (AWS Bundle)
Copyright 2017-2025 The Apache Software Foundation
This product include
jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932534648
##
gcp-bundle/NOTICE:
##
@@ -29,53 +28,314 @@ from the source code management (SCM) system project uses.
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1931498907
##
gcp-bundle/NOTICE:
##
@@ -84,17 +344,38 @@ This product contains the Maven wrapper scripts from
'Maven Wrapper', that provi
* HOMEPAGE:
* https:/
amogh-jahagirdar commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1931488179
##
azure-bundle/NOTICE:
##
@@ -28,3 +27,272 @@ To find the details that apply to this artifact see the
accompanying LICENSE fil
A list of contributors may
Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1930145205
##
aws-bundle/NOTICE:
##
@@ -1,25 +1,24 @@
-Apache Iceberg
+Apache Iceberg (AWS Bundle)
Copyright 2017-2025 The Apache Software Foundation
This product includes s
jbonofre opened a new pull request, #12095:
URL: https://github.com/apache/iceberg/pull/12095
Bundle jar files actually bundle a few ALv2 dependencies. These dependencies
are correctly listed in the `LICENSE` file, but the `NOTICE` file don't contain
relevant portions when the dependency pr
76 matches
Mail list logo
