Fokko commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1935942629


##########
azure-bundle/NOTICE:
##########
@@ -7,24 +6,240 @@ The Apache Software Foundation (http://www.apache.org/).
 
 
--------------------------------------------------------------------------------
 
-NOTICE for Group: com.fasterxml.jackson.core  Name: jackson-core  Version: 
2.13.5
-NOTICE for Group: com.fasterxml.jackson.core  Name: jackson-databind  Version: 
2.13.5
-NOTICE for Group: com.fasterxml.jackson.dataformat  Name: 
jackson-dataformat-xml  Version: 2.13.5
-
-# Jackson JSON processor
+This binary artifact includes FasterXML Jackson 2.13.5 with the following in 
its NOTICE file:

Review Comment:
   I think we actually ship a lower version:
   
   ```
   ➜  iceberg git:(main) ./gradlew :iceberg-azure-bundle:dependencies | grep -i 
jackson
   |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2
   |    |    |         +--- 
com.fasterxml.jackson.core:jackson-annotations:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 
(c)
   |    |    |         \--- 
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2 (c)
   |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
        |    \--- com.fasterxml.jackson.core:jackson-databind:2.13.4.2 -> 
2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2
   |    |    |         +--- 
com.fasterxml.jackson.core:jackson-annotations:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 
(c)
   |    |    |         \--- 
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2 (c)
   |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
        |    \--- com.fasterxml.jackson.core:jackson-databind:2.13.4.2 -> 
2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2
   |    |    |         +--- 
com.fasterxml.jackson.core:jackson-annotations:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 
(c)
   |    |    |         \--- 
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2 (c)
   |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
        |    \--- com.fasterxml.jackson.core:jackson-databind:2.13.4.2 -> 
2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2
   |    |    |         +--- 
com.fasterxml.jackson.core:jackson-annotations:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 
(c)
   |    |    |         \--- 
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2 (c)
   |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    \--- com.fasterxml.jackson.core:jackson-databind:2.13.4.2 -> 
2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2
   |    |    |         +--- 
com.fasterxml.jackson.core:jackson-annotations:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (c)
   |    |    |         +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 
(c)
   |    |    |         \--- 
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2 (c)
   |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    +--- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2
   |    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-core:2.17.2 (*)
   |    |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.17.2 (*)
   |    |    |    \--- com.fasterxml.jackson:jackson-bom:2.17.2 (*)
   |    |    \--- com.fasterxml.jackson.core:jackson-databind:2.13.4.2 -> 
2.17.2 (*)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to