rdblue commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932587756
########## aws-bundle/NOTICE: ########## @@ -101,3 +100,252 @@ To find the details that apply to this artifact see the accompanying LICENSE fil A list of contributors may be found from CREDITS(-2.x) file, which is included in some artifacts (usually source distributions); but is always available from the source code management (SCM) system project uses. + +-------------------------------------------------------------------------------- Review Comment: When copying another NOTICE into this one, I think we need to use some formatting to give clear context about what was copied and what is original content. In other runtime bundles, we identify the included project and then identify the notice content specifically (see [this ORC example](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark-runtime/NOTICE#L27-L38)): ``` -------------------------------------------------------------------------------- This binary artifact includes <PROJECT> with the following in its NOTICE file: | COPIED PROJECT NOTICE | Indented to clearly show what was copied ``` I think that we should follow that convention here as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
