wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1941373788
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTI
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1940580970
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1940578441
##
src/iceberg/type.h:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1940550748
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1940544261
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1940417078
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1940311010
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2632488206
Thanks @Fokko I'll follow up to correct those things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1940311892
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
Fokko merged PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1939675681
##
src/iceberg/type.h:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1939669942
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1939672043
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1939669942
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1939661683
##
src/iceberg/schema_field.cc:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See th
Fokko commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1939655258
##
src/iceberg/schema_field.cc:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See th
gaborkaszab commented on PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2630393003
> @Fokko @Xuanwo I think this is ready to merge. cc @gaborkaszab in case
there is any comment.
I got a bit busy with other stuff, so wouldn't block this PR for me to find
time
wgtmac commented on PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2630371626
@Fokko @Xuanwo I think this is ready to merge. cc @gaborkaszab in case there
is any comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
zhjwpku commented on PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2629416131
> Is anything else required here?
+1 to merge this PR, thanks for working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
lidavidm commented on PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2629358646
Is anything else required here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1931317189
##
src/iceberg/schema.cc:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the N
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1931316798
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1931316526
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930652040
##
src/iceberg/schema.cc:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930661811
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTI
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930530815
##
src/iceberg/type.h:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930529228
##
src/iceberg/schema.cc:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the N
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930527117
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTI
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930519529
##
src/iceberg/type.h:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930515526
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930518460
##
src/iceberg/type.h:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930514942
##
src/iceberg/type.cc:
##
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930513905
##
src/iceberg/util/formatter.h:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. Se
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1930297551
##
src/iceberg/util/formatter.h:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See
zhjwpku commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929955889
##
src/iceberg/type.h:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTI
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929897710
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929898199
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929897727
##
src/iceberg/schema.h:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929896367
##
src/iceberg/type_fwd.h:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929895510
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929895464
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r192989
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929894113
##
src/iceberg/type.h:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929893856
##
src/iceberg/type.h:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
zhjwpku commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929632431
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
mapleFU commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929570771
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
mapleFU commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929571875
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
mapleFU commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929571759
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
mapleFU commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929571759
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
zhjwpku commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929540361
##
src/iceberg/type_fwd.h:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the N
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929484489
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929484432
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929484350
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
mapleFU commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1928877725
##
src/iceberg/type.cc:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
raulcd commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1928587396
##
src/iceberg/schema_field.cc:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See t
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1928124052
##
src/iceberg/schema_field.h:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See th
lidavidm commented on PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2608739486
I added a bunch of unit tests + fixed some copy-paste errors I discovered in
the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1925149114
##
src/iceberg/type.h:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1925143148
##
src/iceberg/type.h:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1924967533
##
src/iceberg/type.h:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1924965681
##
src/iceberg/type.h:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1924878641
##
src/iceberg/type.h:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1924876800
##
src/iceberg/type.h:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1924877020
##
src/iceberg/type.h:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOT
lidavidm commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1924876360
##
src/iceberg/schema_field.h:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See
wgtmac commented on code in PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1924866221
##
src/iceberg/type.h:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
lidavidm commented on PR #31:
URL: https://github.com/apache/iceberg-cpp/pull/31#issuecomment-2606400574
I'll add some unit tests as long as the API looks good to everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
67 matches
Mail list logo