wgtmac commented on code in PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1928124052
########## src/iceberg/schema_field.h: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +/// \file iceberg/schema_field.h +/// A (schema) field is a name and a type and is part of a schema or nested +/// type (e.g. a struct). + +#include <cstdint> +#include <memory> +#include <string> +#include <string_view> + +#include "iceberg/iceberg_export.h" +#include "iceberg/type_fwd.h" +#include "iceberg/util/formattable.h" + +namespace iceberg { + +/// \brief A type combined with a name. +class ICEBERG_EXPORT SchemaField : public iceberg::util::Formattable { + public: + /// \brief Construct a field. + /// \param[in] field_id The field ID. + /// \param[in] name The field name. + /// \param[in] type The field type. + /// \param[in] optional Whether values of this field are required or nullable. + SchemaField(int32_t field_id, std::string name, std::shared_ptr<Type> type, + bool optional); + + /// \brief Construct an optional (nullable) field. + static SchemaField MakeOptional(int32_t field_id, std::string name, + std::shared_ptr<Type> type); + /// \brief Construct a required (non-null) field. + static SchemaField MakeRequired(int32_t field_id, std::string name, + std::shared_ptr<Type> type); + + /// \brief Get the field ID. + [[nodiscard]] int32_t field_id() const; Review Comment: Right, it is just personal flavor. I have commented at https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2611657586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
