lidavidm commented on code in PR #31: URL: https://github.com/apache/iceberg-cpp/pull/31#discussion_r1929895510
########## src/iceberg/type.cc: ########## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "iceberg/type.h" + +#include <format> +#include <iterator> +#include <stdexcept> + +#include "iceberg/util/formatter.h" + +namespace iceberg { + +TypeId BooleanType::type_id() const { return TypeId::kBoolean; } +std::string BooleanType::ToString() const { return "boolean"; } +bool BooleanType::Equals(const Type& other) const { + return other.type_id() == TypeId::kBoolean; +} + +TypeId Int32Type::type_id() const { return TypeId::kInt32; } +std::string Int32Type::ToString() const { return "int32"; } +bool Int32Type::Equals(const Type& other) const { + return other.type_id() == TypeId::kInt32; +} + +TypeId Int64Type::type_id() const { return TypeId::kInt64; } +std::string Int64Type::ToString() const { return "int64"; } +bool Int64Type::Equals(const Type& other) const { + return other.type_id() == TypeId::kInt64; +} + +TypeId Float32Type::type_id() const { return TypeId::kFloat32; } +std::string Float32Type::ToString() const { return "float32"; } +bool Float32Type::Equals(const Type& other) const { + return other.type_id() == TypeId::kFloat32; +} + +TypeId Float64Type::type_id() const { return TypeId::kFloat64; } +std::string Float64Type::ToString() const { return "float64"; } +bool Float64Type::Equals(const Type& other) const { + return other.type_id() == TypeId::kFloat64; +} + +DecimalType::DecimalType(int32_t precision, int32_t scale) + : precision_(precision), scale_(scale) { + if (precision < 0 || precision > kMaxPrecision) { + throw std::runtime_error( + std::format("DecimalType: precision must be in [0, 38], was {}", precision)); + } +} + +int32_t DecimalType::precision() const { return precision_; } +int32_t DecimalType::scale() const { return scale_; } +TypeId DecimalType::type_id() const { return TypeId::kDecimal; } +std::string DecimalType::ToString() const { + return std::format("decimal({}, {})", precision_, scale_); +} +bool DecimalType::Equals(const Type& other) const { + if (other.type_id() != TypeId::kDecimal) { + return false; + } + const auto& decimal = static_cast<const DecimalType&>(other); + return precision_ == decimal.precision_ && scale_ == decimal.scale_; +} + +TypeId TimeType::type_id() const { return TypeId::kTime; } +std::string TimeType::ToString() const { return "time"; } +bool TimeType::Equals(const Type& other) const { + return other.type_id() == TypeId::kTime; +} + +TypeId DateType::type_id() const { return TypeId::kDate; } +std::string DateType::ToString() const { return "date"; } +bool DateType::Equals(const Type& other) const { + return other.type_id() == TypeId::kDate; +} + +bool TimestampType::is_zoned() const { return false; } +TimeUnit TimestampType::time_unit() const { return TimeUnit::kMicrosecond; } +TypeId TimestampType::type_id() const { return TypeId::kTimestamp; } +std::string TimestampType::ToString() const { return "timestamp"; } +bool TimestampType::Equals(const Type& other) const { + return other.type_id() == TypeId::kTimestamp; +} + +bool TimestampTzType::is_zoned() const { return true; } +TimeUnit TimestampTzType::time_unit() const { return TimeUnit::kMicrosecond; } +TypeId TimestampTzType::type_id() const { return TypeId::kTimestampTz; } +std::string TimestampTzType::ToString() const { return "timestamptz"; } +bool TimestampTzType::Equals(const Type& other) const { + return other.type_id() == TypeId::kTimestampTz; +} + +TypeId BinaryType::type_id() const { return TypeId::kBinary; } +std::string BinaryType::ToString() const { return "binary"; } +bool BinaryType::Equals(const Type& other) const { + return other.type_id() == TypeId::kBinary; +} + +TypeId StringType::type_id() const { return TypeId::kString; } +std::string StringType::ToString() const { return "string"; } +bool StringType::Equals(const Type& other) const { + return other.type_id() == TypeId::kString; +} + +FixedType::FixedType(int32_t length) : length_(length) { + if (length < 0) { + throw std::runtime_error( + std::format("FixedType: length must be >= 0, was {}", length)); + } +} + +int32_t FixedType::length() const { return length_; } Review Comment: Java does not have unsigned types but you can manipulate signed types as if they were unsigned when necessary. I'll close this since there's another thread about this now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
