Fokko commented on PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#issuecomment-2876795518
Let's merge this to unblock
https://github.com/apache/iceberg-python/pull/1958. Thanks @soumya-ghosh for
working on this, and thanks @kevinjqliu and @geruh for the reviews 🙌
--
T
Fokko merged PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2081380859
##
pyiceberg/table/inspect.py:
##
@@ -523,7 +523,67 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schem
Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2081294621
##
pyiceberg/table/inspect.py:
##
@@ -523,7 +523,67 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schema)
-
soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2080552494
##
pyiceberg/table/inspect.py:
##
@@ -523,7 +523,67 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schem
soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2079178204
##
tests/integration/test_inspect_table.py:
##
@@ -942,3 +949,83 @@ def test_inspect_all_manifests(spark: SparkSession,
session_catalog: Catalog, fo
l
Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2079109317
##
pyiceberg/table/inspect.py:
##
@@ -523,7 +523,67 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schema)
-
soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2078557847
##
pyiceberg/table/inspect.py:
##
@@ -657,3 +671,30 @@ def all_manifests(self) -> "pa.Table":
lambda args: self._generate_manifests_table(*args
soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2076356376
##
pyiceberg/table/inspect.py:
##
@@ -657,3 +671,30 @@ def all_manifests(self) -> "pa.Table":
lambda args: self._generate_manifests_table(*args
soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2076246023
##
tests/integration/test_inspect_table.py:
##
@@ -938,3 +947,37 @@ def test_inspect_all_manifests(spark: SparkSession,
session_catalog: Catalog, fo
l
Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2074995021
##
pyiceberg/table/inspect.py:
##
@@ -657,3 +671,30 @@ def all_manifests(self) -> "pa.Table":
lambda args: self._generate_manifests_table(*args), [(sn
Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2074993621
##
pyiceberg/table/inspect.py:
##
@@ -657,3 +671,30 @@ def all_manifests(self) -> "pa.Table":
lambda args: self._generate_manifests_table(*args), [(sn
soumya-ghosh commented on PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#issuecomment-2853642895
Yes @Fokko, there is an open discussion that was happening in
https://github.com/apache/iceberg-python/issues/1053#issuecomment-2661633989.
I will raise another PR for d
Fokko commented on PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#issuecomment-2853640976
@soumya-ghosh I see that you incorporated the feedback by @kevinjqliu
directly, instead of accepting the suggestion. That also works, thanks for
working on this. I think we're pretty
Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2074944552
##
pyiceberg/table/inspect.py:
##
@@ -570,71 +630,25 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
pa.field("reada
Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2074942264
##
pyiceberg/table/inspect.py:
##
@@ -570,71 +630,25 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
pa.field("reada
Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2074937959
##
tests/integration/test_inspect_table.py:
##
@@ -938,3 +947,37 @@ def test_inspect_all_manifests(spark: SparkSession,
session_catalog: Catalog, fo
lhs = sp
Fokko commented on PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#issuecomment-2853613242
@soumya-ghosh Gentle ping, would you be interested in contributing this?
Would be great to get this in 🚀
--
This is an automated message from the Apache Git Service.
To respond to
soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2061539548
##
pyiceberg/table/inspect.py:
##
@@ -523,7 +523,62 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schem
geruh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r1960691377
##
pyiceberg/table/inspect.py:
##
@@ -657,3 +669,35 @@ def all_manifests(self) -> "pa.Table":
lambda args: self._generate_manifests_table(*args), [(sn
kevinjqliu commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r1947923174
##
pyiceberg/table/inspect.py:
##
@@ -523,7 +523,62 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schema)
soumya-ghosh opened a new pull request, #1626:
URL: https://github.com/apache/iceberg-python/pull/1626
- all_files
- all_data_files
- all_delete_files
Refactored code for files metadata for better reusability
--
This is an automated message from the Apache Git Service.
To resp
22 matches
Mail list logo
