Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2074944552
##########
pyiceberg/table/inspect.py:
##########
@@ -570,71 +630,25 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
pa.field("readable_metrics",
pa.struct(readable_metrics_struct), nullable=True),
]
)
+ return files_schema
- files: list[dict[str, Any]] = []
+ def _files(self, snapshot_id: Optional[int] = None, data_file_filter:
Optional[Set[DataFileContent]] = None) -> "pa.Table":
+ import pyarrow as pa
+
+ files_table: list[pa.Table] = []
Review Comment:
nit: we can move this one down, we don't need to create the error when we
return on line 642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
