soumya-ghosh commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2061539548
##########
pyiceberg/table/inspect.py:
##########
@@ -523,7 +523,62 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schema)
- def _files(self, snapshot_id: Optional[int] = None, data_file_filter:
Optional[Set[DataFileContent]] = None) -> "pa.Table":
+ def _files_by_manifest(
+ self, manifest_list: ManifestFile, data_file_filter:
Optional[Set[DataFileContent]] = None
+ ) -> List[Dict[str, Any]]:
+ files: list[dict[str, Any]] = []
+ schema = self.tbl.metadata.schema()
Review Comment:
@kevinjqliu updated code as per comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
