Fokko commented on code in PR #1626:
URL: https://github.com/apache/iceberg-python/pull/1626#discussion_r2074937959
##########
tests/integration/test_inspect_table.py:
##########
@@ -938,3 +947,37 @@ def test_inspect_all_manifests(spark: SparkSession,
session_catalog: Catalog, fo
lhs = spark.table(f"{identifier}.all_manifests").toPandas()
rhs = df.to_pandas()
assert_frame_equal(lhs, rhs, check_dtype=False)
+
+
[email protected]
[email protected]("format_version", [1, 2])
+def test_inspect_all_files(
+ spark: SparkSession, session_catalog: Catalog, arrow_table_with_null:
pa.Table, format_version: int
+) -> None:
+ identifier = "default.table_metadata_files"
+
+ tbl = _create_table(session_catalog, identifier,
properties={"format-version": format_version})
Review Comment:
Instead of setting the properties below, we can also do this during table
creation:
```suggestion
tbl = _create_table(session_catalog, identifier,
properties={"format-version": format_version, "write.delete.mode":
"merge-on-read", "write.update.mode": "merge-on-read"})
```
This avoids another round trip, speeding up the tests :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
