sungwy merged PR #931:
URL: https://github.com/apache/iceberg-python/pull/931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
jqin61 commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2537415525
Thanks for fixing the jar issue, shall we rerun CI and merge? @Fokko Thank
you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jqin61 commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2530521095
@Fokko @sungwy Thank you for the review and the suggestions! I fixed the
latest comments and let's rerun CI and merge it if looks good to you.
--
This is an automated message from
Fokko commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2486886304
@jqin61 Do you have time to follow up on the last few comments? Would be
great to get this in 👍
--
This is an automated message from the Apache Git Service.
To respond to the messag
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1829297150
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -181,6 +181,61 @@ def test_query_filter_appended_null_partitioned(
assert len(rows) == 6
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1829270083
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -181,6 +181,61 @@ def test_query_filter_appended_null_partitioned(
assert len(rows) == 6
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1829272105
##
pyiceberg/table/__init__.py:
##
@@ -456,6 +461,89 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1829270083
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -181,6 +181,61 @@ def test_query_filter_appended_null_partitioned(
assert len(rows) == 6
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1829238607
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -222,6 +277,113 @@ def test_query_filter_v1_v2_append_null(
assert df.where(f"{col} is nu
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1829233234
##
pyiceberg/table/__init__.py:
##
@@ -456,6 +461,89 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1829210096
##
mkdocs/docs/api.md:
##
@@ -353,6 +353,127 @@ lat: [[52.371807,37.773972,53.11254],[53.21917]]
long: [[4.896029,-122.431297,6.0989],[6.56667]]
```
+### Partial
Fokko commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2455407068
@jqin61 @sungwy Sorry for leaving this hanging, I'll do a review first thing
tomorrow 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
sungwy commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2372038772
Hi @Fokko - this PR looks good from my end.
Would you have some time to take a look? Since this is a new API (which
comes with another level of caution), I'd love to get your r
sungwy commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1771352661
##
pyiceberg/table/__init__.py:
##
@@ -456,6 +461,89 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
sungwy commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2362472247
Thank you for making this contribution @jqin61 ! I'll leave this PR open for
another review
--
This is an automated message from the Apache Git Service.
To respond to the message, p
sungwy commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1766801854
##
mkdocs/docs/api.md:
##
@@ -353,6 +353,127 @@ lat: [[52.371807,37.773972,53.11254],[53.21917]]
long: [[4.896029,-122.431297,6.0989],[6.56667]]
```
+### Partia
sungwy commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1766797436
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -221,6 +276,98 @@ def test_query_filter_v1_v2_append_null(
assert df.where(f"{col} is no
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r176422
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -221,6 +276,98 @@ def test_query_filter_v1_v2_append_null(
assert df.where(f"{col} is no
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r176422
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -221,6 +276,98 @@ def test_query_filter_v1_v2_append_null(
assert df.where(f"{col} is no
sungwy commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1761801698
##
pyiceberg/table/__init__.py:
##
@@ -456,6 +461,85 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
sungwy commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1761797345
##
pyiceberg/table/__init__.py:
##
@@ -456,6 +461,85 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1721056249
##
pyiceberg/table/__init__.py:
##
@@ -3542,14 +3629,22 @@ def __init__(self, transaction: Transaction, io:
FileIO, snapshot_properties: Di
self._io = io
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1721043893
##
pyiceberg/table/__init__.py:
##
@@ -1551,6 +1627,17 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
with self.trans
jqin61 commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2273853017
> @jqin61 Sorry for the slow review, I was doing some other stuff as well.
Can you fix the merge conflicts? I think this looks good to go 👍
Thank you Fokko! Sorry for the delay,
Fokko commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2272768616
@jqin61 Sorry for the slow review, I was doing some other stuff as well. Can
you fix the merge conflicts? I think this looks good to go 👍
--
This is an automated message from the Ap
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684839188
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684836325
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684712750
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684716462
##
pyiceberg/table/__init__.py:
##
@@ -3542,14 +3629,22 @@ def __init__(self, transaction: Transaction, io:
FileIO, snapshot_properties: Di
self._io = io
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684716462
##
pyiceberg/table/__init__.py:
##
@@ -3542,14 +3629,22 @@ def __init__(self, transaction: Transaction, io:
FileIO, snapshot_properties: Di
self._io = io
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684712750
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684712750
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
Fokko commented on PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2232862859
Left some more comments @jqin61, thanks for working on this 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680739942
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -181,6 +181,73 @@ def test_query_filter_appended_null_partitioned(
assert len(rows) == 6
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680737458
##
pyiceberg/table/__init__.py:
##
@@ -3542,14 +3629,22 @@ def __init__(self, transaction: Transaction, io:
FileIO, snapshot_properties: Di
self._io = io
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680737458
##
pyiceberg/table/__init__.py:
##
@@ -3542,14 +3629,22 @@ def __init__(self, transaction: Transaction, io:
FileIO, snapshot_properties: Di
self._io = io
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680724658
##
pyiceberg/table/__init__.py:
##
@@ -544,14 +612,22 @@ def overwrite(
self.delete(delete_filter=overwrite_filter,
snapshot_properties=snapshot_properti
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r168073
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680692811
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680690395
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680690823
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680686994
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680586403
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680580388
##
pyiceberg/table/__init__.py:
##
@@ -1551,6 +1627,17 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
with self.transa
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1679986891
##
pyiceberg/table/__init__.py:
##
@@ -3542,14 +3629,22 @@ def __init__(self, transaction: Transaction, io:
FileIO, snapshot_properties: Di
self._io = io
Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1679982328
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_f
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1678417234
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,71 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1678416870
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,71 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1678414292
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,71 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
syun64 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1678319796
##
pyiceberg/table/__init__.py:
##
@@ -502,6 +503,71 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_
jqin61 opened a new pull request, #931:
URL: https://github.com/apache/iceberg-python/pull/931
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
51 matches
Mail list logo
