jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684712750
##########
pyiceberg/table/__init__.py:
##########
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_file in data_files:
append_files.append_data_file(data_file)
+ def _build_partition_predicate(self, partition_records: List[Record]) ->
BooleanExpression:
Review Comment:
Hi Fokko, thanks for the detailed review! I am working on fixing them.
For this comment, I would like to check your opinions on what should be the
behavior in the first scenario, i.e. a dynamic overwrite's impact on files that
do not have partitions? Cus currently I alerts the user the dynamic overwrite
does not makes sense if current table is unpartitioned. I think I could change
to a no-op operation. If so, it would leave us in a slightly weird situation
where an unpartitioned table would have all the data overwritten if it is
normal overwrite but it would end up as a no-op if it is dynamic overwrite,
does that sound correct to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
