jqin61 commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1684839188
##########
pyiceberg/table/__init__.py:
##########
@@ -502,6 +503,73 @@ def append(self, df: pa.Table, snapshot_properties:
Dict[str, str] = EMPTY_DICT)
for data_file in data_files:
append_files.append_data_file(data_file)
+ def _build_partition_predicate(self, partition_records: List[Record]) ->
BooleanExpression:
Review Comment:
Thanks for the thorough review! So if the table is firstly unpartitioned and
then evolved into a partition. I think the expected bahavior is that dynamic
overwrite will also delete (potentially through overwrite) data in the
unpartitioned files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
