Fokko commented on code in PR #931:
URL: https://github.com/apache/iceberg-python/pull/931#discussion_r1680737458
##########
pyiceberg/table/__init__.py:
##########
@@ -3542,14 +3629,22 @@ def __init__(self, transaction: Transaction, io:
FileIO, snapshot_properties: Di
self._io = io
self._snapshot_properties = snapshot_properties
- def fast_append(self) -> FastAppendFiles:
+ def fast_append(self, commit_uuid: Optional[uuid.UUID] = None) ->
FastAppendFiles:
Review Comment:
How about:
```
with append_method() as append_files:
append_files.commit_uuid = append_snapshot_commit_uuid
```
Maybe not the prettiest solution, but I would not expect an user to set the
UUID, so we should not expose it to them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
