Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-24 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1928403544 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +343,13 @@ public void testVariantUnsupported() { .hasMessage("Unsupported type for i

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-24 Thread via GitHub
nastra commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1928335915 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +343,13 @@ public void testVariantUnsupported() { .hasMessage("Unsupported type for

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-23 Thread via GitHub
RussellSpitzer commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927677945 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +343,13 @@ public void testVariantUnsupported() { .hasMessage("Unsupported t

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-23 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927674078 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +343,13 @@ public void testVariantUnsupported() { .hasMessage("Unsupported type for i

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-23 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927669099 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -539,7 +539,8 @@ private static String sanitize(Type type, Object value, long now, int t

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-23 Thread via GitHub
RussellSpitzer commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927107837 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +343,13 @@ public void testVariantUnsupported() { .hasMessage("Unsupported t

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-23 Thread via GitHub
RussellSpitzer commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927103566 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -539,7 +539,8 @@ private static String sanitize(Type type, Object value, long n

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-23 Thread via GitHub
RussellSpitzer commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927102367 ## api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java: ## @@ -539,7 +539,8 @@ private static String sanitize(Type type, Object value, long n

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-22 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1926350102 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +342,22 @@ public void testVariantUnsupported() { .hasMessage("Unsupported type for i

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-22 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1926348050 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +342,22 @@ public void testVariantUnsupported() { .hasMessage("Unsupported type for i

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-22 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1926344616 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -39,7 +39,9 @@ class Identity implements Transform { @Deprecated public static Identity g

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-22 Thread via GitHub
HonahX commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1926050463 ## core/src/test/java/org/apache/iceberg/TestSortOrder.java: ## @@ -342,6 +342,22 @@ public void testVariantUnsupported() { .hasMessage("Unsupported type for

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-22 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1924994313 ## api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java: ## @@ -431,6 +431,20 @@ public void testVariantUnsupported() { assertThat(bucket.canTransfor

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-22 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1924964930 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -93,6 +95,10 @@ public SerializableFunction bind(Type type) { @Override public boolean c

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-21 Thread via GitHub
HonahX commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1924533722 ## api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java: ## @@ -431,6 +431,20 @@ public void testVariantUnsupported() { assertThat(bucket.canTransfo

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-21 Thread via GitHub
HonahX commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1924520051 ## api/src/main/java/org/apache/iceberg/transforms/Identity.java: ## @@ -93,6 +95,10 @@ public SerializableFunction bind(Type type) { @Override public boolean

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-21 Thread via GitHub
Fokko commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1923378731 ## api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java: ## @@ -136,6 +136,15 @@ public void testVariant() throws Exception { .isEqualTo(varia

Re: [PR] API: Add `UnknownType` [iceberg]

2025-01-20 Thread via GitHub
nastra commented on code in PR #12012: URL: https://github.com/apache/iceberg/pull/12012#discussion_r1923164162 ## api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java: ## @@ -136,6 +136,15 @@ public void testVariant() throws Exception { .isEqualTo(vari