Fokko commented on code in PR #12012:
URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927669099


##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -539,7 +539,8 @@ private static String sanitize(Type type, Object value, 
long now, int today) {
       case FIXED:
       case BINARY:
       case VARIANT:
-        // for boolean, uuid, decimal, fixed, variant, and binary, match the 
string result
+      case UNKNOWN:
+        // for boolean, uuid, decimal, fixed, variant, unknown, and binary, 
match the string result
         return sanitizeSimpleString(value.toString());

Review Comment:
   Yes, that's a good point. I've changed it to `(unknown)`, similar to `(time)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to