nastra commented on code in PR #12012:
URL: https://github.com/apache/iceberg/pull/12012#discussion_r1928335915
##########
core/src/test/java/org/apache/iceberg/TestSortOrder.java:
##########
@@ -342,6 +343,13 @@ public void testVariantUnsupported() {
.hasMessage("Unsupported type for identity: variant");
}
+ @Test
+ public void testUnknownSupported() {
+ Schema v3Schema = new Schema(Types.NestedField.optional(1, "u",
Types.UnknownType.get()));
+
+ SortOrder.builderFor(v3Schema).withOrderId(10).asc("u").build();
Review Comment:
it looks a bit weird if there's no assertion check in a test method. So I
would either add an assertion around the sort order or just add a
`assertThatNoException().isThrownBy(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
