RussellSpitzer commented on code in PR #12012:
URL: https://github.com/apache/iceberg/pull/12012#discussion_r1927103566
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -539,7 +539,8 @@ private static String sanitize(Type type, Object value,
long now, int today) {
case FIXED:
case BINARY:
case VARIANT:
- // for boolean, uuid, decimal, fixed, variant, and binary, match the
string result
+ case UNKNOWN:
+ // for boolean, uuid, decimal, fixed, variant, unknown, and binary,
match the string result
return sanitizeSimpleString(value.toString());
Review Comment:
I kind of feel like maybe Unknown should just output "Unknown" rather than
anything sanitized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
