Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-31 Thread via GitHub
Fokko merged PR #784: URL: https://github.com/apache/iceberg-python/pull/784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

[PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-31 Thread via GitHub
syun64 opened a new pull request, #784: URL: https://github.com/apache/iceberg-python/pull/784 reopening https://github.com/apache/iceberg-python/pull/703 due to issues with git diff detection on the PR -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-31 Thread via GitHub
syun64 closed pull request #703: Support Appends with TimeTransform Partitions URL: https://github.com/apache/iceberg-python/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-31 Thread via GitHub
syun64 commented on PR #703: URL: https://github.com/apache/iceberg-python/pull/703#issuecomment-2142845753 I'll close this PR and reopen it and see if that helps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-31 Thread via GitHub
syun64 commented on PR #703: URL: https://github.com/apache/iceberg-python/pull/703#issuecomment-2142844385 @Fokko hmmm yeah I've seen this happen some times and I don't quite understand it - when you do a diff between the two branches, it shows the right changes: https://github.com/apache

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-31 Thread via GitHub
Fokko commented on PR #703: URL: https://github.com/apache/iceberg-python/pull/703#issuecomment-2142832199 @syun64 It looks like something is off. I see a lot of unrelated changes 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-08 Thread via GitHub
syun64 commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1594758142 ## pyiceberg/transforms.py: ## @@ -515,6 +583,19 @@ def __repr__(self) -> str: """Return the string representation of the HourTransform class."""

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-08 Thread via GitHub
benihildebrand commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1594581596 ## pyiceberg/transforms.py: ## @@ -515,6 +583,19 @@ def __repr__(self) -> str: """Return the string representation of the HourTransform class."""

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-07 Thread via GitHub
syun64 commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592831066 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-07 Thread via GitHub
HonahX commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592801119 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-07 Thread via GitHub
HonahX commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592801119 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-07 Thread via GitHub
syun64 commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592449680 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-07 Thread via GitHub
syun64 commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592430523 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-07 Thread via GitHub
HonahX commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1591831561 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-06 Thread via GitHub
HonahX commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1591829611 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

Re: [PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-06 Thread via GitHub
HonahX commented on code in PR #703: URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1591829611 ## pyiceberg/transforms.py: ## @@ -349,6 +356,13 @@ def dedup_name(self) -> str: def preserves_order(self) -> bool: return True +@abstractmethod

[PR] Support Appends with TimeTransform Partitions [iceberg-python]

2024-05-06 Thread via GitHub
syun64 opened a new pull request, #703: URL: https://github.com/apache/iceberg-python/pull/703 Support writes with TimeTransforms. TimeTransforms are can be supported natively within pyarrow as pyarrow compute functions, without requiring conversions back and forth between Arrow and