HonahX commented on code in PR #703:
URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592801119
##########
pyiceberg/transforms.py:
##########
@@ -349,6 +356,13 @@ def dedup_name(self) -> str:
def preserves_order(self) -> bool:
return True
+ @abstractmethod
+ def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array],
pa.Array]": ...
+
+ @property
+ def supports_pyarrow_transform(self) -> bool:
Review Comment:
Thanks for sharing the context. My initial concern was that unlike
`can_transform` and `preserve_oder` which behave differently across transforms,
in the end the `support_pyarrow_transform` would return `True` for all the
transforms, making it a little bit redundant. But on second thought, since we
will likely not support pyarrow transform for other transforms in 0.7.0
release, this `support_pyarrow_transform` can be a useful property in the
upcoming release.
We could deprecate this property after we support pyarrow for all transforms
later. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
