syun64 commented on code in PR #703:
URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592831066
##########
pyiceberg/transforms.py:
##########
@@ -349,6 +356,13 @@ def dedup_name(self) -> str:
def preserves_order(self) -> bool:
return True
+ @abstractmethod
+ def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array],
pa.Array]": ...
+
+ @property
+ def supports_pyarrow_transform(self) -> bool:
Review Comment:
Yeah I'm on the same page! To add to that - I'm not yet sure if we will be
able to support the other Transform classes in `support_pyarrow_transform`. The
key idea here is that we want to use native pyarrow compute functions to apply
the equivalent transform without converting the values back and forth between
Arrow and Python data types. I'm not yet sure if we'll be able to do the same
for BucketTransform for instance, with the existing range of pyarrow compute
functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
