HonahX commented on code in PR #703:
URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1591829611
##########
pyiceberg/transforms.py:
##########
@@ -349,6 +356,13 @@ def dedup_name(self) -> str:
def preserves_order(self) -> bool:
return True
+ @abstractmethod
+ def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array],
pa.Array]": ...
Review Comment:
Shall we put this in the super class `Transform`, in the future we will
support all the transforms and they will share the same method def as this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
