Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu merged PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu commented on PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#issuecomment-2867838923 Thanks @petern48 for the contribution! Always love docs improvements :) Note the change wont show up in https://py.iceberg.apache.org/ until we run the github action, whi

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2082462531 ## mkdocs/docs/contributing.md: ## @@ -37,7 +37,7 @@ The PyIceberg Project is hosted on GitHub at

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2082464664 ## mkdocs/docs/contributing.md: ## @@ -48,7 +48,7 @@ python -m venv ./venv source ./venv/bin/activate ``` -To get started, you can run `make install`, whi

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

petern48 commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2074480551 ## mkdocs/docs/contributing.md: ## @@ -37,7 +37,7 @@ The PyIceberg Project is hosted on GitHub at

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

petern48 commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2074485874 ## mkdocs/docs/contributing.md: ## @@ -48,7 +48,7 @@ python -m venv ./venv source ./venv/bin/activate ``` -To get started, you can run `make install`, which

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

petern48 commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2074480551 ## mkdocs/docs/contributing.md: ## @@ -37,7 +37,7 @@ The PyIceberg Project is hosted on GitHub at

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

kevinjqliu commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2072493969 ## mkdocs/docs/contributing.md: ## @@ -37,7 +37,7 @@ The PyIceberg Project is hosted on GitHub at

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

petern48 commented on PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#issuecomment-2848814070 I originally was going to propose removing `install-poetry` from `install` in `Makefile`, but then realize it's still useful / convenienet for the CI commands, so I decided to lea

[PR] [Docs] Improve contributing docs [iceberg-python]

petern48 opened a new pull request, #1965: URL: https://github.com/apache/iceberg-python/pull/1965 Closes #1964 # Rationale for this change Following all steps in the contributing docs leads to error. Running `make install-poetry` should be done before the environme