petern48 commented on code in PR #1965:
URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2074485874
##########
mkdocs/docs/contributing.md:
##########
@@ -48,7 +48,7 @@ python -m venv ./venv
source ./venv/bin/activate
```
-To get started, you can run `make install`, which installs Poetry and all the
dependencies of the Iceberg library. This also installs the development
dependencies. If you don't want to install the development dependencies, you
need to install using `poetry install --no-dev`.
+To get started, you can run `make install`, which installs all the
dependencies of the Iceberg library. This also installs the development
dependencies. If you don't want to install the development dependencies, you
need to install using `poetry install --no-dev` instead of `make install`.
Review Comment:
Hmm, my intention here was that running `make install` would run `make
install-dependencies`, which runs `poetry install --all-extras` without the
`--no-dev` flag, which ends up installing the dev dependencies. If the user
were to run `make install` then `poetry install --no-dev`, they would end up
installing the dev dependencies, hence why I felt the need to make this change.
I do see that my proposed wording leaves out `install-poetry` part. I guess
we could create a new make command `install-without-dev` that runs poetry
install beforehand. What do you think?
```Makefile
install-without-dev: | install-poetry
poetry install --all-extras --without dev
```
(also FYI `--no-dev` was deprecated so i changed it to `--without dev`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
