Re: [PR] chore(deps): Bump crate-ci/typos from 1.33.1 to 1.34.0 [iceberg-rust]

2025-07-06 Thread via GitHub
liurenjie1024 merged PR #1491: URL: https://github.com/apache/iceberg-rust/pull/1491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] feat: add schema conversion from avro timestamp-millis [iceberg-python]

2025-07-06 Thread via GitHub
matthias-Q commented on PR #2173: URL: https://github.com/apache/iceberg-python/pull/2173#issuecomment-3043672904 @kevinjqliu yes, they are part of the Iceberg schema spec, but not for Avro (see https://avro.apache.org/docs/1.12.0/specification/). They are optional, but the conversion funct

Re: [PR] Core: Use time-travel schema when resolving partition spec in scan [iceberg]

2025-07-06 Thread via GitHub
chenjian2664 commented on code in PR #13301: URL: https://github.com/apache/iceberg/pull/13301#discussion_r2189091923 ## core/src/main/java/org/apache/iceberg/AllManifestsTable.java: ## @@ -119,7 +119,7 @@ protected TableScan newRefinedScan(Table table, Schema schema, TableScan

Re: [PR] Add support for DELTA_BINARY_PACKED Parquet encoding [iceberg]

2025-07-06 Thread via GitHub
eric-maynard commented on PR #13391: URL: https://github.com/apache/iceberg/pull/13391#issuecomment-3043506178 cc @RussellSpitzer / @wypoon / @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Spark-4.0: Add spark action to compute partition stats [iceberg]

2025-07-06 Thread via GitHub
ajantha-bhat opened a new pull request, #13478: URL: https://github.com/apache/iceberg/pull/13478 This just a clean port from spark-3.5 PR: https://github.com/apache/iceberg/pull/12450/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Core: Support DV for partition stats [iceberg]

2025-07-06 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2188939269 ## core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java: ## @@ -387,16 +411,21 @@ public void testPartitionStats() throws Exception {

Re: [PR] Spark: Registering tables to nonexistent target namespace leads to metadata deletion in HiveCatalog [iceberg]

2025-07-06 Thread via GitHub
hsiang-c commented on code in PR #13434: URL: https://github.com/apache/iceberg/pull/13434#discussion_r2175876377 ## spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogConfig.java: ## @@ -28,8 +28,12 @@ public enum SparkCatalogConfig { "testhive",

Re: [PR] core: Support DV for partition stats [iceberg]

2025-07-06 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2188920467 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -89,17 +91,57 @@ private PartitionStatsHandler() {} NestedField.optional(11, "l

[PR] feat: RegisterTable support for InMemoryCatalog [iceberg-cpp]

2025-07-06 Thread via GitHub
lishuxu opened a new pull request, #142: URL: https://github.com/apache/iceberg-cpp/pull/142 Note: Since the LoadTable interface needs to return a Table object that holds a shared_from_this pointer to the catalog, I remove InMemoryCatalog inheritance from Catalog and instead directly implem

Re: [PR] core: Support DV for partition stats [iceberg]

2025-07-06 Thread via GitHub
ajantha-bhat commented on PR #13425: URL: https://github.com/apache/iceberg/pull/13425#issuecomment-3043401673 @pvary, @stevenzwu, @nastra: I have addressed comments and also I found an issue when v3 reading the v2 stats as DV is required field in schema. The reading failed and incremental

Re: [PR] feat: RegisterTable api support for InMemoryCatalog [iceberg-cpp]

2025-07-06 Thread via GitHub
lishuxu closed pull request #141: feat: RegisterTable api support for InMemoryCatalog URL: https://github.com/apache/iceberg-cpp/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] refine: refine the interface of SnapshotProducer [iceberg-rust]

2025-07-06 Thread via GitHub
ZENOTME commented on PR #1490: URL: https://github.com/apache/iceberg-rust/pull/1490#issuecomment-3043365597 Hi @CTTY, Thanks for your review! > Since TransactionAction::commit already takes in a &Table, I don't think having SnapshotProducer hold its own table reference adds much valu

[PR] feat: RegisterTable api support for InMemoryCatalog [iceberg-cpp]

2025-07-06 Thread via GitHub
lishuxu opened a new pull request, #141: URL: https://github.com/apache/iceberg-cpp/pull/141 Note: Since the LoadTable interface needs to return a Table object that holds a shared_from_this pointer to the catalog, I remove InMemoryCatalog inheritance from Catalog and instead directly implem

Re: [PR] fix(cli/rest) Support Glue REST operations with Iceberg-Go CLI [iceberg-go]

2025-07-06 Thread via GitHub
maninc commented on PR #459: URL: https://github.com/apache/iceberg-go/pull/459#issuecomment-3043350973 Thank you @laskoviymishka @zeroshade for the suggestion. I have updated the code to follow the pattern in Iceberg Catalog Migrator. Successfully tested cli using command below,

Re: [I] (doc): Change error message to reference column that has mismatch [iceberg-python]

2025-07-06 Thread via GitHub
harishkesavarao commented on issue #2017: URL: https://github.com/apache/iceberg-python/issues/2017#issuecomment-3043319534 @Rizxcviii I apologize, I am currently unable to dedicate time to this. Wanted to let you know. -- This is an automated message from the Apache Git Service. To res

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

2025-07-06 Thread via GitHub
MisterRaindrop commented on PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#issuecomment-3043278140 @wgtmac hi please help me check it again when you’re free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-07-06 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2188793310 ## src/iceberg/table.cc: ## @@ -107,4 +108,8 @@ const std::vector& Table::history() const { const std::shared_ptr& Table::io() const { return io_; } +std::unique

[I] Change iceberg folder structure to facilitate easier migrations from snapshot parquet tables [iceberg]

2025-07-06 Thread via GitHub
abhinigam opened a new issue, #13477: URL: https://github.com/apache/iceberg/issues/13477 ### Proposed Change An iceberg table stored on s3 consists of two folders: metadata data Moreover the metadata instead of directly pointing to the data folder points to the parent fo

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-07-06 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2188789576 ## src/iceberg/table_scan.cc: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] docs: Mark Rust ADLS FileIO as implemented in the status page [iceberg]

2025-07-06 Thread via GitHub
kevinjqliu merged PR #13258: URL: https://github.com/apache/iceberg/pull/13258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] docs: Mark Rust ADLS FileIO as implemented [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on PR #13258: URL: https://github.com/apache/iceberg/pull/13258#issuecomment-3043169901 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] File Format API without registry [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on PR #13257: URL: https://github.com/apache/iceberg/pull/13257#issuecomment-3043169890 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] REST encryption integration [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on PR #13225: URL: https://github.com/apache/iceberg/pull/13225#issuecomment-3043169870 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] API: Compute truncate decimal result precision based on lowest value bound [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] closed pull request #12969: API: Compute truncate decimal result precision based on lowest value bound URL: https://github.com/apache/iceberg/pull/12969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] API: Compute truncate decimal result precision based on lowest value bound [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on PR #12969: URL: https://github.com/apache/iceberg/pull/12969#issuecomment-3043169810 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] closed pull request #12695: AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory URL: https://github.com/apache/iceberg/pull/12695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-3043169734 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] API, Core: Geospatial bounds and spatial predicates [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] closed pull request #12667: API, Core: Geospatial bounds and spatial predicates URL: https://github.com/apache/iceberg/pull/12667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] API, Core: Geospatial bounds and spatial predicates [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on PR #12667: URL: https://github.com/apache/iceberg/pull/12667#issuecomment-3043169718 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spark: when doing rewrite_data_files, check for partitioning schema compatibility [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on PR #12651: URL: https://github.com/apache/iceberg/pull/12651#issuecomment-3043169696 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spark: when doing rewrite_data_files, check for partitioning schema compatibility [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] closed pull request #12651: Spark: when doing rewrite_data_files, check for partitioning schema compatibility URL: https://github.com/apache/iceberg/pull/12651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] Unable to create tables automatically with Iceberg REST and AWS Glue [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on issue #11921: URL: https://github.com/apache/iceberg/issues/11921#issuecomment-3043169656 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Question about Decimal Type Limitations in Iceberg [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on issue #11920: URL: https://github.com/apache/iceberg/issues/11920#issuecomment-3043169634 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] kafka-connector | org.apache.kafka.connect.storage.StringConverter for value not working [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on issue #11871: URL: https://github.com/apache/iceberg/issues/11871#issuecomment-3043169585 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] kafka-connector | org.apache.kafka.connect.storage.StringConverter for value not working [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] closed issue #11871: kafka-connector | org.apache.kafka.connect.storage.StringConverter for value not working URL: https://github.com/apache/iceberg/issues/11871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] flink在提交任务的时候报错 [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on issue #11823: URL: https://github.com/apache/iceberg/issues/11823#issuecomment-3043169552 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Using the Struct type as the primary key in equalDelete operation will cause data reading errors. [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on issue #11611: URL: https://github.com/apache/iceberg/issues/11611#issuecomment-3043169526 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Implement Human OAuth2 Flows for OAuth2Manager [iceberg]

2025-07-06 Thread via GitHub
github-actions[bot] commented on issue #10677: URL: https://github.com/apache/iceberg/issues/10677#issuecomment-3043169496 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Cannot create table named after metadata table in Spark using REST catalog [iceberg]

2025-07-06 Thread via GitHub
kevinjqliu commented on issue #13388: URL: https://github.com/apache/iceberg/issues/13388#issuecomment-3043165923 Since we'd want to create `nyc.entries` as a valid table, we probably would want to add a case [here](https://github.com/apache/iceberg/blob/f3b198de2304c01af9beedf47fcc6edfe8f4

Re: [I] Cannot create table named after metadata table in Spark using REST catalog [iceberg]

2025-07-06 Thread via GitHub
kevinjqliu commented on issue #13388: URL: https://github.com/apache/iceberg/issues/13388#issuecomment-3043162289 > 172.18.0.5 - - [06/Jul/2025:16:21:23 +] "GET /v1/namespaces//tables/nyc?snapshots=all HTTP/1.1" 400 70 "-" "Apache-HttpClient/5.4.1 (Java/17.0.14)" that makes sense

[PR] feat: `validate_no_new_added_delete_files` [iceberg-python]

2025-07-06 Thread via GitHub
gabeiglio opened a new pull request, #2176: URL: https://github.com/apache/iceberg-python/pull/2176 Closes [#1930](https://github.com/apache/iceberg-python/issues/1930) # Rationale for this change Add `_validate_no_new_delete_files` and dependencies like `DeleteFileIndex

Re: [PR] Improve Docs for IRC Catalog Connection [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on code in PR #2175: URL: https://github.com/apache/iceberg-python/pull/2175#discussion_r2188685421 ## mkdocs/docs/configuration.md: ## @@ -372,7 +372,73 @@ Specific headers defined by the RESTCatalog spec include: | Key |

Re: [PR] refactor: consolidate snapshot expiration into MaintenanceTable [iceberg-python]

2025-07-06 Thread via GitHub
ForeverAngry commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2188683832 ## pyiceberg/table/maintenance.py: ## @@ -0,0 +1,399 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] Added support for Bodo DataFrame [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2188682854 ## poetry.lock: ## @@ -3276,69 +3385,49 @@ files = [ ] [[package]] -name = "numpy" -version = "2.0.2" -description = "Fundamental package for array comput

Re: [PR] feat: add support for setting and removing table properties on console [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #2153: URL: https://github.com/apache/iceberg-python/pull/2153#issuecomment-3042930857 Thanks @blinkseb for adding this feature! And thanks @Fokko for the review :) -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] feat: add support for setting and removing table properties on console [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu merged PR #2153: URL: https://github.com/apache/iceberg-python/pull/2153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Use Iceberg-Rust for parsing the ManifestList and Manifests [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on code in PR #2004: URL: https://github.com/apache/iceberg-python/pull/2004#discussion_r2188673738 ## tests/utils/test_manifest.py: ## @@ -357,7 +357,7 @@ def test_write_empty_manifest() -> None: @pytest.mark.parametrize("format_version", [1, 2]) def te

[PR] Improve Docs for IRC Catalog Connection [iceberg-python]

2025-07-06 Thread via GitHub
james5418 opened a new pull request, #2175: URL: https://github.com/apache/iceberg-python/pull/2175 …tails # Rationale for this change Included examples and detailed configuration guidance to enhance clarity. # Are these changes tested? # Are there

Re: [PR] Expose Avro reader to PyIceberg [iceberg-rust]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #1328: URL: https://github.com/apache/iceberg-rust/pull/1328#issuecomment-3042902613 deps on #1482 to read both v1 and v2 table metadata -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Read ManifestList V1 with V2 projection. [iceberg-rust]

2025-07-06 Thread via GitHub
kevinjqliu commented on code in PR #1482: URL: https://github.com/apache/iceberg-rust/pull/1482#discussion_r2188658689 ## crates/iceberg/src/avro/schema.rs: ## @@ -92,9 +127,12 @@ impl SchemaVisitor for SchemaToAvroSchema { custom_attributes: Default::default(),

Re: [PR] refactor: consolidate snapshot expiration into MaintenanceTable [iceberg-python]

2025-07-06 Thread via GitHub
jayceslesar commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2188651305 ## pyiceberg/table/maintenance.py: ## @@ -0,0 +1,399 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreemen

Re: [PR] refactor: consolidate snapshot expiration into MaintenanceTable [iceberg-python]

2025-07-06 Thread via GitHub
jayceslesar commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2188650002 ## pyiceberg/table/maintenance.py: ## @@ -0,0 +1,399 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreemen

Re: [PR] Update schema projection to support `initial-defaults` [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on code in PR #1644: URL: https://github.com/apache/iceberg-python/pull/1644#discussion_r2188646623 ## pyiceberg/io/pyarrow.py: ## @@ -1814,9 +1814,12 @@ def struct( array = self._cast_if_needed(field, field_array) field_arr

Re: [PR] Added support for Bodo DataFrame [iceberg-python]

2025-07-06 Thread via GitHub
ehsantn commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2188614748 ## poetry.lock: ## @@ -3276,69 +3385,49 @@ files = [ ] [[package]] -name = "numpy" -version = "2.0.2" -description = "Fundamental package for array computing

Re: [PR] refactor: consolidate snapshot expiration into MaintenanceTable [iceberg-python]

2025-07-06 Thread via GitHub
ForeverAngry commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2188613085 ## pyiceberg/table/maintenance.py: ## @@ -0,0 +1,399 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] refactor: consolidate snapshot expiration into MaintenanceTable [iceberg-python]

2025-07-06 Thread via GitHub
ForeverAngry commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2188607885 ## pyiceberg/table/maintenance.py: ## @@ -0,0 +1,380 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] Added support for Bodo DataFrame [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2188588800 ## poetry.lock: ## @@ -3276,69 +3385,49 @@ files = [ ] [[package]] -name = "numpy" -version = "2.0.2" -description = "Fundamental package for array comput

Re: [PR] Cleanup in `expression-dsl.md` [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu merged PR #2168: URL: https://github.com/apache/iceberg-python/pull/2168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] [Avro] Accept dict with only `'type': 'null'` as representation of `null` [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #2109: URL: https://github.com/apache/iceberg-python/pull/2109#issuecomment-3042493272 @Tishj is this fix not needed anymore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] dep: pin transitive dep `google-cloud-storage >=2.0.0` [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #2161: URL: https://github.com/apache/iceberg-python/pull/2161#issuecomment-3042424453 > But cachetools does not have any dependencies, so also not on google-cloud-storage. Why does it lower the GCP dependencies I found the culprit! `poetry show --tree`:

Re: [PR] Docs: Condens Python API docs [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu merged PR #2139: URL: https://github.com/apache/iceberg-python/pull/2139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] feat: add schema conversion from avro timestamp-millis [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #2173: URL: https://github.com/apache/iceberg-python/pull/2173#issuecomment-3042459341 > Avro schema does not have a notion of field-id and element-id. I could add a helper function that would add these. I know this is not the core responsibility of this library.

Re: [PR] Build: Bump cachetools from 5.5.2 to 6.1.0 [iceberg-python]

2025-07-06 Thread via GitHub
dependabot[bot] commented on PR #2145: URL: https://github.com/apache/iceberg-python/pull/2145#issuecomment-3042430153 OK, I won't notify you about version 6.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Build: Bump cachetools from 5.5.2 to 6.1.0 [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #2145: URL: https://github.com/apache/iceberg-python/pull/2145#issuecomment-3042429978 @dependabot ignore this major version Reason: `google-auth` sets an upper limit for `cachetools`. https://github.com/googleapis/google-auth-library-python/blob/ca94ead4035

Re: [PR] Build: Bump cachetools from 5.5.2 to 6.1.0 [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu closed pull request #2145: Build: Bump cachetools from 5.5.2 to 6.1.0 URL: https://github.com/apache/iceberg-python/pull/2145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Build: Bump cachetools from 5.5.2 to 6.1.0 [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #2145: URL: https://github.com/apache/iceberg-python/pull/2145#issuecomment-3042427347 Copying over explanation from https://github.com/apache/iceberg-python/pull/2161#issuecomment-3042424453 > But cachetools does not have any dependencies, so also not on g

Re: [PR] dep: pin transitive dep `google-cloud-storage >=2.0.0` [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu closed pull request #2161: dep: pin transitive dep `google-cloud-storage >=2.0.0` URL: https://github.com/apache/iceberg-python/pull/2161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] add iceberg datafusion integration [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu merged PR #2075: URL: https://github.com/apache/iceberg-python/pull/2075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-07-06 Thread via GitHub
davseitsev commented on code in PR #12892: URL: https://github.com/apache/iceberg/pull/12892#discussion_r2188521344 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogConfig.java: ## @@ -29,22 +29,27 @@ public enum SparkCatalogConfig { SparkCatalog.cla

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-07-06 Thread via GitHub
davseitsev commented on code in PR #12892: URL: https://github.com/apache/iceberg/pull/12892#discussion_r2188513524 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -685,6 +685,29 @@ public void testRenameTable() { .hasMessage("Table already exi

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-07-06 Thread via GitHub
davseitsev commented on code in PR #12892: URL: https://github.com/apache/iceberg/pull/12892#discussion_r2188512527 ## core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java: ## @@ -136,6 +137,14 @@ public String toString() { protected abstract String defaultWareho

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-07-06 Thread via GitHub
davseitsev commented on code in PR #12892: URL: https://github.com/apache/iceberg/pull/12892#discussion_r2188512091 ## aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java: ## @@ -172,7 +177,14 @@ void initialize( LockManager lock, Map catalogProps) {

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-07-06 Thread via GitHub
davseitsev commented on code in PR #12892: URL: https://github.com/apache/iceberg/pull/12892#discussion_r2188511433 ## aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java: ## @@ -310,6 +310,22 @@ public void testRenameTable() { assertThat(renamed

Re: [PR] refine: refine the interface of SnapshotProducer [iceberg-rust]

2025-07-06 Thread via GitHub
CTTY commented on PR #1490: URL: https://github.com/apache/iceberg-rust/pull/1490#issuecomment-3042319919 Hi @ZENOTME , thanks for working on this! I went thru the change and have some general thoughts: > ManifestProcess and SnapshotProduceOperation can be consider as custom extension fo

Re: [PR] refactor: consolidate snapshot expiration into MaintenanceTable [iceberg-python]

2025-07-06 Thread via GitHub
jayceslesar commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2188475659 ## pyiceberg/table/maintenance.py: ## @@ -0,0 +1,380 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreemen

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-07-06 Thread via GitHub
davseitsev commented on PR #12892: URL: https://github.com/apache/iceberg/pull/12892#issuecomment-304221 Thank you for the review! I'll commit all the changes separately and rebase them into a single commit when it's ready because I have some questions. -- This is an automated message

Re: [PR] Detect the case to identify missing column from the file using file's max field id in StrictMetricsEvaluator #13397 [iceberg]

2025-07-06 Thread via GitHub
manirajv06 commented on code in PR #13398: URL: https://github.com/apache/iceberg/pull/13398#discussion_r2188474388 ## api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java: ## @@ -69,13 +71,26 @@ public StrictMetricsEvaluator(Schema schema, Expression un

Re: [PR] Build: Bump cachetools from 5.5.2 to 6.1.0 [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on PR #2145: URL: https://github.com/apache/iceberg-python/pull/2145#issuecomment-3042212429 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] iceberg table properties are saved in table metadata's properties field [iceberg-python]

2025-07-06 Thread via GitHub
kevinjqliu commented on issue #2064: URL: https://github.com/apache/iceberg-python/issues/2064#issuecomment-3042208906 > my understanding is that the iceberg reference jdbc implementation does not store table properties in a sql table. Any advice on how we can store properties in the catal

Re: [I] Cannot create table named after metadata table in Spark using REST catalog [iceberg]

2025-07-06 Thread via GitHub
elphastori commented on issue #13388: URL: https://github.com/apache/iceberg/issues/13388#issuecomment-3042190882 > Im curious to see what the actual HTTP request made is. Thanks for taking a look, it's actually quite interesting. The create table command results in a `LOAD_TABLE` req

Re: [PR] Introduce website with docs [iceberg-go]

2025-07-06 Thread via GitHub
laskoviymishka commented on PR #478: URL: https://github.com/apache/iceberg-go/pull/478#issuecomment-3041946904 > Couldn't we just improve the README and examples and just use https://pkg.go.dev/github.com/apache/iceberg-go? > With pkg.go.dev as the standard for Go documentation. I

Re: [I] Enforce that test classes start with "Test" [iceberg]

2025-07-06 Thread via GitHub
CuteChuanChuan commented on issue #13442: URL: https://github.com/apache/iceberg/issues/13442#issuecomment-3041919329 Hi @nastra, I've submitted a [PR](https://github.com/apache/iceberg/pull/13466) Could you please take a look when you have a chance? I'd appreciate your feedback.

Re: [PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-06 Thread via GitHub
wgtmac commented on PR #140: URL: https://github.com/apache/iceberg-cpp/pull/140#issuecomment-3041805409 Perhaps we can design a pluggable logger interface so that downstream projects can plug in their own logger of choice. -- This is an automated message from the Apache Git Service. To r

Re: [PR] Spark: Throw unsupported for ADD COLUMN with default value [iceberg]

2025-07-06 Thread via GitHub
singhpk234 commented on code in PR #13464: URL: https://github.com/apache/iceberg/pull/13464#discussion_r2188344970 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -234,6 +234,13 @@ private static void apply(UpdateSchema pendingUpdate, TableCha

Re: [PR] [Avro] Accept dict with only `'type': 'null'` as representation of `null` [iceberg-python]

2025-07-06 Thread via GitHub
Tishj closed pull request #2109: [Avro] Accept dict with only `'type': 'null'` as representation of `null` URL: https://github.com/apache/iceberg-python/pull/2109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] OpenAPI: Add missing schema field for TableMetadata [iceberg]

2025-07-06 Thread via GitHub
Bhargavkonidena commented on PR #13152: URL: https://github.com/apache/iceberg/pull/13152#issuecomment-3041541746 @nastra I have sent multiple times even now ,is their a way. We can review it here ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Introduce website with docs [iceberg-go]

2025-07-06 Thread via GitHub
zeroshade commented on PR #478: URL: https://github.com/apache/iceberg-go/pull/478#issuecomment-3041438175 Do we really need a full website? Couldn't we just improve the readme and examples and just use https://pkg.go.dev/github.com/apache/iceberg-go which will always be auto generated for

[PR] chore(deps): Bump ordered-float from 2.10.1 to 4.6.0 [iceberg-rust]

2025-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #1495: URL: https://github.com/apache/iceberg-rust/pull/1495 Bumps [ordered-float](https://github.com/reem/rust-ordered-float) from 2.10.1 to 4.6.0. Release notes Sourced from https://github.com/reem/rust-ordered-float/releases";>ordered-f

[PR] chore(deps): Bump serde_with from 3.13.0 to 3.14.0 [iceberg-rust]

2025-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #1494: URL: https://github.com/apache/iceberg-rust/pull/1494 Bumps [serde_with](https://github.com/jonasbb/serde_with) from 3.13.0 to 3.14.0. Release notes Sourced from https://github.com/jonasbb/serde_with/releases";>serde_with's release

[PR] chore(deps): Bump tokio from 1.45.0 to 1.46.1 [iceberg-rust]

2025-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #1493: URL: https://github.com/apache/iceberg-rust/pull/1493 Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.45.0 to 1.46.1. Release notes Sourced from https://github.com/tokio-rs/tokio/releases";>tokio's releases. Tokio v1.4

[PR] chore(deps): Bump the arrow-parquet group with 4 updates [iceberg-rust]

2025-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #1492: URL: https://github.com/apache/iceberg-rust/pull/1492 Bumps the arrow-parquet group with 4 updates: [arrow-arith](https://github.com/apache/arrow-rs), [arrow-cast](https://github.com/apache/arrow-rs), [arrow-ord](https://github.com/apache/a

[PR] chore(deps): Bump crate-ci/typos from 1.33.1 to 1.34.0 [iceberg-rust]

2025-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #1491: URL: https://github.com/apache/iceberg-rust/pull/1491 Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.33.1 to 1.34.0. Release notes Sourced from https://github.com/crate-ci/typos/releases";>crate-ci/typos's release

Re: [PR] refine: refine the interface of SnapshotProducer [iceberg-rust]

2025-07-06 Thread via GitHub
ZENOTME commented on PR #1490: URL: https://github.com/apache/iceberg-rust/pull/1490#issuecomment-3041345650 cc @liurenjie1024 @CTTY @Xuanwo @sdd @Fokko @kevinjqliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] refine: refine the interface of SnapshotProducer [iceberg-rust]

2025-07-06 Thread via GitHub
ZENOTME opened a new pull request, #1490: URL: https://github.com/apache/iceberg-rust/pull/1490 ## Which issue does this PR close? ## What changes are included in this PR? This PR refine the interface of SnapshotProducer: 1. include the table in SnapshotPr

Re: [PR] refactor: Move memory catalog into core [iceberg-rust]

2025-07-06 Thread via GitHub
Xuanwo commented on code in PR #1480: URL: https://github.com/apache/iceberg-rust/pull/1480#discussion_r2188189887 ## crates/iceberg/src/lib.rs: ## @@ -22,12 +22,10 @@ //! ## Scan A Table //! //! ```rust, ignore Review Comment: Yes -- This is an automated message from

[PR] Introduce website with docs [iceberg-go]

2025-07-06 Thread via GitHub
laskoviymishka opened a new pull request, #478: URL: https://github.com/apache/iceberg-go/pull/478 Part of: https://github.com/apache/iceberg-go/issues/477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[I] Iceberg Go: documentation website [iceberg-go]

2025-07-06 Thread via GitHub
laskoviymishka opened a new issue, #477: URL: https://github.com/apache/iceberg-go/issues/477 ### Feature Request / Improvement As follow up to https://github.com/apache/iceberg-go/issues/469 i think we should introduce https://go.iceberg.apache.org/ simillar to https://rust.iceberg.

[PR] build(deps): bump the gomod_updates group with 3 updates [iceberg-go]

2025-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #476: URL: https://github.com/apache/iceberg-go/pull/476 Bumps the gomod_updates group with 3 updates: [github.com/aws/aws-sdk-go-v2/service/glue](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/

[PR] Build: Bump mkdocs-material from 9.6.14 to 9.6.15 [iceberg]

2025-07-06 Thread via GitHub
dependabot[bot] opened a new pull request, #13467: URL: https://github.com/apache/iceberg/pull/13467 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.14 to 9.6.15. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc

Re: [PR] feat: add spdlog dependency to implement logging [iceberg-cpp]

2025-07-06 Thread via GitHub
Kelvinyu1117 commented on PR #140: URL: https://github.com/apache/iceberg-cpp/pull/140#issuecomment-3041156668 I would like to suggest another alternative: https://github.com/odygrd/quill I used this logger professionally for ultra low latency application, maybe we can have a look.

  1   2   >