davseitsev commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2188521344
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogConfig.java:
##########
@@ -29,22 +29,27 @@ public enum SparkCatalogConfig {
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hive",
- "default-namespace", "default")),
+ "default-namespace", "default",
+ "unique-table-location", "true")),
HADOOP(
"testhadoop",
SparkCatalog.class.getName(),
ImmutableMap.of("type", "hadoop", "cache-enabled", "false")),
REST(
"testrest",
SparkCatalog.class.getName(),
- ImmutableMap.of("type", "rest", "cache-enabled", "false")),
+ ImmutableMap.of(
+ "type", "rest",
+ "cache-enabled", "false",
+ "unique-table-location", "true")),
SPARK(
"spark_catalog",
SparkSessionCatalog.class.getName(),
ImmutableMap.of(
"type", "hive",
"default-namespace", "default",
"parquet-enabled", "true",
+ "unique-table-location", "true",
Review Comment:
Maybe I didn't get the idea, but if I remove `unique-table-location`
property from these configs, my test will start failing for them. This check
will not pass:
```
assertThat(table.location())
.as("Should have a different table location")
.isNotEqualTo(renamedTable.location());
```
I can create a separate configs and move my test to a separate class if
that's what you meant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
