davseitsev commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2188513524
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -685,6 +685,29 @@ public void testRenameTable() {
.hasMessage("Table already exists: db.tbl2-newtable");
}
+ @Test
+ public void testCreateTableAfterRename() {
Review Comment:
I did it, it works wel lfor Hive, InMemory, Jdbc and Nessie catalogs. But in
tests for REST catalog I'm not sure how to proceed. So far I configured
property `unique_table_location` for REST catalog **backend**. For me it seems
valid option, backend decides about default table location. But maybe we want
to handle it differently in REST catalog, anyway I think it worh another PR.
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -685,6 +685,29 @@ public void testRenameTable() {
.hasMessage("Table already exists: db.tbl2-newtable");
}
+ @Test
+ public void testCreateTableAfterRename() {
Review Comment:
I did it, it works well for Hive, InMemory, Jdbc and Nessie catalogs. But in
tests for REST catalog I'm not sure how to proceed. So far I configured
property `unique_table_location` for REST catalog **backend**. For me it seems
valid option, backend decides about default table location. But maybe we want
to handle it differently in REST catalog, anyway I think it worh another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
