kevinjqliu commented on PR #2161:
URL: https://github.com/apache/iceberg-python/pull/2161#issuecomment-3042424453

   > But cachetools does not have any dependencies, so also not on 
google-cloud-storage. Why does it lower the GCP dependencies
   
   I found the culprit! `poetry show --tree`:
   ```
   ├── google-cloud-storage *
   │   ├── google-api-core >=2.15.0,<3.0.0 
   │   │   ├── google-auth >=2.14.1,<3.0.0 
   │   │   │   ├── cachetools >=2.0.0,<6.0 
   ```
   `google-auth` sets an upper limit for `cachetools`. Confirmed 
[here](https://github.com/googleapis/google-auth-library-python/blob/ca94ead4035beea4741dc5384449032f8e6f75d8/setup.py#L23)
   
   So the resolver finds the version of `google-auth` without this constraint
   ```
   ├── google-cloud-storage *
   │   ├── google-auth >=1.2.0 
   │   │   ├── cachetools >=2.0.0 
   ```
   
   > Adding this constraint would put an unnecessary constraint on the users. 
We fail on errors, to make sure that we fix deprecations in time, but I don't 
think this is the right fix.
   
   Agreed! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to