Re: [PR] fix: correct `UUIDType` partition representation for `BucketTransform` [iceberg-python]

2025-06-06 Thread via GitHub
DinGo4DEV commented on PR #2003: URL: https://github.com/apache/iceberg-python/pull/2003#issuecomment-2951733486 Squash commits and update testcases for uuid writer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

2025-06-06 Thread via GitHub
CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133354991 ## crates/iceberg/src/transaction/mod.rs: ## @@ -25,31 +26,39 @@ use std::cmp::Ordering; use std::collections::HashMap; use std::mem::discriminant; use std::sync::

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

2025-06-06 Thread via GitHub
CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133345927 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

2025-06-06 Thread via GitHub
CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133304710 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[PR] SPARK: Port prefix listing option in remove orphan files to Spark 3.4 and Spark 4.0 [iceberg]

2025-06-06 Thread via GitHub
liziyan-lzy opened a new pull request, #13264: URL: https://github.com/apache/iceberg/pull/13264 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

2025-06-06 Thread via GitHub
liurenjie1024 commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133228521 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Fix the minio config [iceberg-rust]

2025-06-06 Thread via GitHub
liurenjie1024 merged PR #1419: URL: https://github.com/apache/iceberg-rust/pull/1419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] bug(iceberg): `add_files` doesn't actually check duplicated files [iceberg-rust]

2025-06-06 Thread via GitHub
liurenjie1024 closed issue #1394: bug(iceberg): `add_files` doesn't actually check duplicated files URL: https://github.com/apache/iceberg-rust/issues/1394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] bug(iceberg): `add_files` doesn't actually check duplicated files [iceberg-rust]

2025-06-06 Thread via GitHub
liurenjie1024 closed issue #1394: bug(iceberg): `add_files` doesn't actually check duplicated files URL: https://github.com/apache/iceberg-rust/issues/1394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] fix(iceberg): add_files correctly check duplicates [iceberg-rust]

2025-06-06 Thread via GitHub
liurenjie1024 merged PR #1395: URL: https://github.com/apache/iceberg-rust/pull/1395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [readme] Add moonlink to iceberg-rust users [iceberg-rust]

2025-06-06 Thread via GitHub
liurenjie1024 merged PR #1418: URL: https://github.com/apache/iceberg-rust/pull/1418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[I] Replace BaseUpdate by separate TableUpdate and ViewUpdate in openapi [iceberg]

2025-06-06 Thread via GitHub
nryanov opened a new issue, #13263: URL: https://github.com/apache/iceberg/issues/13263 ### Proposed Change Not sure that i've chose a category correctly but this issue with spec doesn't seem like a bug. ### Motivation Current generated server-side code seems to be hard to u

Re: [PR] perf: Add GCSFileIO benchmark [iceberg]

2025-06-06 Thread via GitHub
github-actions[bot] commented on PR #12995: URL: https://github.com/apache/iceberg/pull/12995#issuecomment-2951278258 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Parquet: Refactor parquet schema handling for variant type [iceberg]

2025-06-06 Thread via GitHub
github-actions[bot] commented on PR #12916: URL: https://github.com/apache/iceberg/pull/12916#issuecomment-2951278150 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Fix: handle IllegalArgumentException when not base64 encoded [iceberg]

2025-06-06 Thread via GitHub
github-actions[bot] commented on PR #12955: URL: https://github.com/apache/iceberg/pull/12955#issuecomment-2951278185 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Adding new rewrite manifest spark action to accept custom partition order [iceberg]

2025-06-06 Thread via GitHub
github-actions[bot] commented on PR #12840: URL: https://github.com/apache/iceberg/pull/12840#issuecomment-2951278121 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] AWS: Add parameter of excluding non-current fields in Glue [iceberg]

2025-06-06 Thread via GitHub
github-actions[bot] commented on PR #12664: URL: https://github.com/apache/iceberg/pull/12664#issuecomment-2951278096 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Support In and notIn operators in ParquetFilters.ConvertFilterToParquet [iceberg]

2025-06-06 Thread via GitHub
github-actions[bot] closed pull request #12449: Support In and notIn operators in ParquetFilters.ConvertFilterToParquet URL: https://github.com/apache/iceberg/pull/12449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Support In and notIn operators in ParquetFilters.ConvertFilterToParquet [iceberg]

2025-06-06 Thread via GitHub
github-actions[bot] commented on PR #12449: URL: https://github.com/apache/iceberg/pull/12449#issuecomment-2951278066 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

2025-06-06 Thread via GitHub
CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133089713 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [I] Website: add links to PyIceberg / IcebergRust / IcebergGo / IcebergCpp [iceberg]

2025-06-06 Thread via GitHub
kevinjqliu commented on issue #12910: URL: https://github.com/apache/iceberg/issues/12910#issuecomment-2951250034 Looks like mkdoc-material does not support dropdown https://github.com/squidfunk/mkdocs-material/discussions/2198 I think the subprojects deserve it own nav tab :)

[PR] [PoC] Remove use of HiveConf.ConfVars [iceberg]

2025-06-06 Thread via GitHub
wypoon opened a new pull request, #13262: URL: https://github.com/apache/iceberg/pull/13262 Continuation of https://github.com/apache/iceberg/pull/12721. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Update `Iceberg Java API` doc [iceberg]

2025-06-06 Thread via GitHub
kevinjqliu commented on issue #13249: URL: https://github.com/apache/iceberg/issues/13249#issuecomment-2951229261 > https://iceberg.apache.org/docs/nightly/api/ is not up-to-date is this an issue with nightly? Based on the name, i'd assume it runs nightly based on the latest `main` br

Re: [I] Website: add links to PyIceberg / IcebergRust / IcebergGo / IcebergCpp [iceberg]

2025-06-06 Thread via GitHub
petern48 commented on issue #12910: URL: https://github.com/apache/iceberg/issues/12910#issuecomment-2951220594 > +1 to modeling it like the spark website, but im not sure if the current site implementation has the dropdown feature. @kevinjqliu Yeah, unfortunately, we can't create the

Re: [PR] Fix the minio config [iceberg-rust]

2025-06-06 Thread via GitHub
kevinjqliu commented on PR #1419: URL: https://github.com/apache/iceberg-rust/pull/1419#issuecomment-2951226317 I updated `minio:minio` and `minio:mc` images to the latest tag i can find -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Fix the minio config [iceberg-rust]

2025-06-06 Thread via GitHub
kevinjqliu commented on PR #1419: URL: https://github.com/apache/iceberg-rust/pull/1419#issuecomment-2951222983 Ah i was wondering why our CI wasn't failing. Looks like we were using a set image, others were using latest https://github.com/apache/iceberg-rust/blob/ea9a1aeadc3c4dc895eaf7d

Re: [PR] Docs: use latest minio client command configuration parameters [iceberg]

2025-06-06 Thread via GitHub
kevinjqliu merged PR #13221: URL: https://github.com/apache/iceberg/pull/13221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[PR] Fix the minio config [iceberg-rust]

2025-06-06 Thread via GitHub
kevinjqliu opened a new pull request, #1419: URL: https://github.com/apache/iceberg-rust/pull/1419 ## Which issue does this PR close? - Closes #. ## What changes are included in this PR? `mc config` is deprecated https://github.com/minio/mc/issues/5206 Simi

Re: [PR] Docs: Remove obsolete version attribute in quick start docker-compose.yml [iceberg]

2025-06-06 Thread via GitHub
kevinjqliu merged PR #13139: URL: https://github.com/apache/iceberg/pull/13139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] docs: Mark Rust ADLS FileIO as implemented [iceberg]

2025-06-06 Thread via GitHub
kevinjqliu commented on PR #13258: URL: https://github.com/apache/iceberg/pull/13258#issuecomment-2951176248 Thanks @DerGut I see this is the [commit](https://github.com/apache/iceberg-rust/commit/b5b8aa837ef70a25c6589d4faa6a358371e35482) referenced and its not yet included in a release.

Re: [I] Website: add links to PyIceberg / IcebergRust / IcebergGo / IcebergCpp [iceberg]

2025-06-06 Thread via GitHub
kevinjqliu commented on issue #12910: URL: https://github.com/apache/iceberg/issues/12910#issuecomment-2951191346 +1 to modeling it like the spark website, but im not sure if the current site implementation has the dropdown feature. -- This is an automated message from the Apache Git Ser

[I] [Docs] reorganize tabs on the main website [iceberg]

2025-06-06 Thread via GitHub
kevinjqliu opened a new issue, #13261: URL: https://github.com/apache/iceberg/issues/13261 ### Feature Request / Improvement Devlist discussion: https://lists.apache.org/thread/jfj84d1c0tz8rcp06z75rfq01fqqd968 I want to re-organize these tabs ![Image](https://github.com/use

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132978787 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132974266 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132911701 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [D] Partition subfolder is not showing [iceberg-rust]

2025-06-06 Thread via GitHub
GitHub user macpie added a comment to the discussion: Partition subfolder is not showing This is just a quick `PartitionedLocationGenerator` I wrote. Probably not great but it's a start if someone want to generate partition folders. ```rust use iceberg::{ Error, ErrorKind, spec::TableMeta

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132936410 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132935740 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132936083 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132934819 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132934564 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132928868 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132928428 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132926313 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132924519 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132924519 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132912549 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132921742 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132921742 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132922107 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132917617 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132919008 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132906545 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132903988 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
zeroshade commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132900763 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { Review Comment:

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132892760 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table Review Comment: Licence header is missing from this file. -- This is an automated message f

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132892443 ## table/update_schema_test.go: ## @@ -0,0 +1,232 @@ +package table Review Comment: Licence header is missing from this file -- This is an automated messa

[PR] [readme] Add moonlink to iceberg-rust users [iceberg-rust]

2025-06-06 Thread via GitHub
dentiny opened a new pull request, #1418: URL: https://github.com/apache/iceberg-rust/pull/1418 ## What changes are included in this PR? Add moonlink into iceberg-rust users, thanks for all the contributors and maintainers! -- This is an automated message from the Apache Git Servic

Re: [I] iceberg table properties are saved in table metadata's properties field [iceberg-python]

2025-06-06 Thread via GitHub
summermousa-vendia commented on issue #2064: URL: https://github.com/apache/iceberg-python/issues/2064#issuecomment-2950466295 This would be a nice thing to fix because I am using pyiceberg with glue and I would want to update the table properties so that I can update the glue catalog's me

[PR] Flink: If IcebergSink writeParalellism is not specified, defaults to the input source paralellism [iceberg]

2025-06-06 Thread via GitHub
rodmeneses opened a new pull request, #13260: URL: https://github.com/apache/iceberg/pull/13260 Currently, if the writeParallelism is not specified, the IcebergSink will default to use the job parallelism. Instead, we should default to the inputSource parallelism, to promote chaining.

[PR] Build: Upgrade to Gradle 8.14.2 [iceberg]

2025-06-06 Thread via GitHub
jbonofre opened a new pull request, #13259: URL: https://github.com/apache/iceberg/pull/13259 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [I] Publish Iceberg kafka connect runtime to Confluent hub [iceberg]

2025-06-06 Thread via GitHub
ranveer-git commented on issue #10745: URL: https://github.com/apache/iceberg/issues/10745#issuecomment-2949872854 Hi @manuzhang, I'd like to take on this issue as my first contribution to Apache Iceberg. I've encountered similar connector deployment challenges in previous projects.

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
laskoviymishka commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132523735 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

[PR] bug(storage-azdls): Fix inferred WASB endpoint [iceberg-rust]

2025-06-06 Thread via GitHub
DerGut opened a new pull request, #1417: URL: https://github.com/apache/iceberg-rust/pull/1417 ## Which issue does this PR close? - Relates to #1360. I tested again fileIO operations with the `wasbs://` scheme, and the current implementation mistakenly used the `blob` endpoint

Re: [PR] Use gcp.NewHTTPClient and pass creds [iceberg-go]

2025-06-06 Thread via GitHub
agchang commented on PR #454: URL: https://github.com/apache/iceberg-go/pull/454#issuecomment-2949779732 > Is there any easy way to have a test for this? I added an integration test, but couldn't figure out a good way to test the auth case. fake-gcs-server afaict doesn't support auth,

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132444288 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132441587 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [PR] Core, Spark 3.5: Update tag to latest snapshot for replace operation [iceberg]

2025-06-06 Thread via GitHub
manuzhang closed pull request #13125: Core, Spark 3.5: Update tag to latest snapshot for replace operation URL: https://github.com/apache/iceberg/pull/13125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core, Spark 3.5: Update tag to latest snapshot for replace operation [iceberg]

2025-06-06 Thread via GitHub
manuzhang commented on code in PR #13125: URL: https://github.com/apache/iceberg/pull/13125#discussion_r2132440552 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java: ## @@ -355,6 +355,36 @@ public void createOrReplaceWithNonExisting

Re: [PR] feat: adding schema update methods [iceberg-go]

2025-06-06 Thread via GitHub
nandorKollar commented on code in PR #431: URL: https://github.com/apache/iceberg-go/pull/431#discussion_r2132434222 ## table/update_schema.go: ## @@ -0,0 +1,532 @@ +package table + +import ( + "github.com/apache/iceberg-go" +) + +type UpdateSchema struct { + base

Re: [I] bug: incorrect order for OrderedFloat with iceberg? [iceberg-rust]

2025-06-06 Thread via GitHub
ZENOTME commented on issue #1415: URL: https://github.com/apache/iceberg-rust/issues/1415#issuecomment-2949515909 Thanks @mapleFU for this! Fix this in #1416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] fix: fix float compare order [iceberg-rust]

2025-06-06 Thread via GitHub
ZENOTME opened a new pull request, #1416: URL: https://github.com/apache/iceberg-rust/pull/1416 ## Which issue does this PR close? Closes #1415 ## What changes are included in this PR? ## Are these changes tested? -- This is an automated message

Re: [PR] spec: add clarification about the Geometry type calculation [iceberg]

2025-06-06 Thread via GitHub
mkaravel commented on PR #13227: URL: https://github.com/apache/iceberg/pull/13227#issuecomment-2949506693 > @rdblue I think it makes sense to drop `xmin > xmax` wraparound in `geometry` if we don't expect CRS to have an effect. > > On the other hand, I'd like to also add `linear` int

Re: [I] Why DoubleLiteral is able to cast to float type? [iceberg]

2025-06-06 Thread via GitHub
mapleFU commented on issue #13255: URL: https://github.com/apache/iceberg/issues/13255#issuecomment-2949465606 If NaN and Inf cannot form any valid literal, the cast seems ok to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] feat(catalog/glue): add option to customize IO loader function [iceberg-go]

2025-06-06 Thread via GitHub
vbekiaris commented on code in PR #441: URL: https://github.com/apache/iceberg-go/pull/441#discussion_r2132306181 ## catalog/glue/options.go: ## @@ -18,13 +18,18 @@ package glue import ( + "context" + + "github.com/apache/iceberg-go/io" "github.com/aws/aw

[PR] feat: add IO registry [iceberg-go]

2025-06-06 Thread via GitHub
vbekiaris opened a new pull request, #455: URL: https://github.com/apache/iceberg-go/pull/455 Introduces IO registry (similar to catalog registry). Default IO implementations (S3, Azure, GSC, local, memory) are pre-registered. Custom IO implementations can be registered with `io.Regis

Re: [I] bug: incorrect order for OrderedFloat with iceberg? [iceberg-rust]

2025-06-06 Thread via GitHub
mapleFU commented on issue #1415: URL: https://github.com/apache/iceberg-rust/issues/1415#issuecomment-2949344243 cc @liurenjie1024 @ZENOTME -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[I] bug: incorrect order for OrderedFloat with iceberg? [iceberg-rust]

2025-06-06 Thread via GitHub
mapleFU opened a new issue, #1415: URL: https://github.com/apache/iceberg-rust/issues/1415 ### Apache Iceberg Rust version None ### Describe the bug OrderedFloat[1] says: > All NaN values are considered equal, even though they may have different [bits](https://doc

[PR] File Format API without registry [iceberg]

2025-06-06 Thread via GitHub
pvary opened a new pull request, #13257: URL: https://github.com/apache/iceberg/pull/13257 Just for testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] docs: Mark Rust ADLS FileIO as implemented [iceberg]

2025-06-06 Thread via GitHub
DerGut opened a new pull request, #13258: URL: https://github.com/apache/iceberg/pull/13258 Since https://github.com/apache/iceberg-rust/issues/1360, Iceberg Rust implements the ADLS FileIO. This PR updates the [status page](https://github.com/apache/iceberg-rust/issues/1360) accordingly.

Re: [I] Why DoubleLiteral is able to cast to float type? [iceberg]

2025-06-06 Thread via GitHub
JeonDaehong commented on issue #13255: URL: https://github.com/apache/iceberg/issues/13255#issuecomment-2949161371 I'm not completely sure, but it seems like the reason might be that Float.POSITIVE_INFINITY isn't treated as a valid numeric literal in Iceberg. Even if a double value larger

Re: [PR] REST encryption integration [iceberg]

2025-06-06 Thread via GitHub
smaheshwar-pltr commented on code in PR #13225: URL: https://github.com/apache/iceberg/pull/13225#discussion_r2126223695 ## core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java: ## @@ -113,14 +143,26 @@ public void commit(TableMetadata base, TableMetadata metadat

[I] `RestCatalog` with sigv4 enabled doesn't pick up creds provided as arguments [iceberg-python]

2025-06-06 Thread via GitHub
gruuya opened a new issue, #2070: URL: https://github.com/apache/iceberg-python/issues/2070 ### Feature Request / Improvement `SigV4Adapter` doesn't use any of the `s3.*` `properties` provided to the catalog when instantiating a `boto3` session, instead it always falls back on boto's

[I] `RestCatalog` with sigv4 enabled instantiates a boto session per each client call [iceberg-python]

2025-06-06 Thread via GitHub
gruuya opened a new issue, #2069: URL: https://github.com/apache/iceberg-python/issues/2069 ### Feature Request / Improvement I've noticed that `boto3` opens a new connection on each client call with `rest.sigv4-enabled` set to `true`, which is wasteful. This happens because a

Re: [PR] API, AWS, Azure, Core, GCP: Use parametrized tests for Kryo/Java serialization verification [iceberg]

2025-06-06 Thread via GitHub
nastra merged PR #13244: URL: https://github.com/apache/iceberg/pull/13244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [I] Parameterize tests that verify Java/Kryo serialization [iceberg]

2025-06-06 Thread via GitHub
nastra closed issue #13237: Parameterize tests that verify Java/Kryo serialization URL: https://github.com/apache/iceberg/issues/13237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] `table.upsert` works only with batching [iceberg-python]

2025-06-06 Thread via GitHub
anuunchin commented on issue #2058: URL: https://github.com/apache/iceberg-python/issues/2058#issuecomment-2949142300 Hey @noahsalvi, went with 1000 - also backed by another user [here](https://github.com/apache/iceberg-python/issues/1759#issuecomment-2862418320) -- This is an automated

Re: [PR] Flink: Dynamic Iceberg Sink Contribution [iceberg]

2025-06-06 Thread via GitHub
mxm commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r2132117378 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundat

[PR] Draft: [#13209] Docs site: adding configuration table for REST catalog auth [iceberg]

2025-06-06 Thread via GitHub
dsillman2000 opened a new pull request, #13256: URL: https://github.com/apache/iceberg/pull/13256 Addresses issue #13209 Adds a new section and configuration table to the `configuration.md` page of the MkDocs site, called "Catalog REST auth properties," with entries for how to config

Re: [PR] API, AWS, Azure, Core, GCP: Use parametrized tests for Kryo/Java serialization verification [iceberg]

2025-06-06 Thread via GitHub
nastra commented on PR #13244: URL: https://github.com/apache/iceberg/pull/13244#issuecomment-2949106755 > > thanks @nandorKollar, this looks great! > > @nastra I still missed one class, `TestTableSerialization`, where I got a bit confused. > > I found a test like this one:

[I] Why DoubleLiteral is able to cast to float type? [iceberg]

2025-06-06 Thread via GitHub
mapleFU opened a new issue, #13255: URL: https://github.com/apache/iceberg/issues/13255 ### Query engine * ### Question I notice the code here: ```java static class DoubleLiteral extends ComparableLiteral { DoubleLiteral(Double value) { super(v

Re: [PR] API, AWS, Azure, Core, GCP: Use parametrized tests for Kryo/Java serialization verification [iceberg]

2025-06-06 Thread via GitHub
nandorKollar commented on PR #13244: URL: https://github.com/apache/iceberg/pull/13244#issuecomment-2949084119 > thanks @nandorKollar, this looks great! @nastra I still missed one class, `TestTableSerialization`, where I got a bit confused. I found a test like this one: ```

Re: [I] Hitting Azure Quota with ADLSFileIO access [iceberg]

2025-06-06 Thread via GitHub
nandorKollar commented on issue #13252: URL: https://github.com/apache/iceberg/issues/13252#issuecomment-2949074790 68f8053d67aaae7c7cf7b13045e2ed4146fa45f9 introduced a token cache for vended credentials, is it possible that it already addressed this problem? -- This is an automated mess

Re: [PR] Core, Spark 3.5: Update tag to latest snapshot for replace operation [iceberg]

2025-06-06 Thread via GitHub
nastra commented on code in PR #13125: URL: https://github.com/apache/iceberg/pull/13125#discussion_r2132078186 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java: ## @@ -355,6 +355,36 @@ public void createOrReplaceWithNonExistingTag

Re: [PR] feat: implement PrimitiveLiteral [iceberg-cpp]

2025-06-06 Thread via GitHub
zhjwpku commented on code in PR #117: URL: https://github.com/apache/iceberg-cpp/pull/117#discussion_r2132043264 ## src/iceberg/datum.h: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] fix(iceberg): add_files correctly check duplicates [iceberg-rust]

2025-06-06 Thread via GitHub
Erigara commented on code in PR #1395: URL: https://github.com/apache/iceberg-rust/pull/1395#discussion_r2132037931 ## crates/integration_tests/tests/shared_tests/append_data_file_test.rs: ## @@ -132,7 +132,10 @@ async fn test_append_data_file() { // commit result again

Re: [PR] fix(iceberg): add_files correctly check duplicates [iceberg-rust]

2025-06-06 Thread via GitHub
Erigara commented on code in PR #1395: URL: https://github.com/apache/iceberg-rust/pull/1395#discussion_r2132037515 ## crates/iceberg/src/transaction/append.rs: ## @@ -379,6 +364,7 @@ mod tests { // Attempt to add the existing Parquet files with fast append.

Re: [PR] feat: implement PrimitiveLiteral [iceberg-cpp]

2025-06-06 Thread via GitHub
zhjwpku commented on code in PR #117: URL: https://github.com/apache/iceberg-cpp/pull/117#discussion_r2132010329 ## src/iceberg/literal.h: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [I] INT96 timestamp is read as OffsetDateTime, not LocalDateTime [iceberg]

2025-06-06 Thread via GitHub
elphastori commented on issue #12266: URL: https://github.com/apache/iceberg/issues/12266#issuecomment-2948961450 Agreed. It seems that neither deprecating nor changing the behavior is worthwhile. I recommend closing the issue. -- This is an automated message from the Apache Git Service.

Re: [PR] fix(iceberg): add_files correctly check duplicates [iceberg-rust]

2025-06-06 Thread via GitHub
Erigara commented on code in PR #1395: URL: https://github.com/apache/iceberg-rust/pull/1395#discussion_r2132028126 ## crates/integration_tests/tests/shared_tests/append_data_file_test.rs: ## @@ -132,7 +132,10 @@ async fn test_append_data_file() { // commit result again

  1   2   >