agchang commented on PR #454: URL: https://github.com/apache/iceberg-go/pull/454#issuecomment-2949779732
> Is there any easy way to have a test for this? I added an integration test, but couldn't figure out a good way to test the auth case. fake-gcs-server afaict doesn't support auth, so the only other way is somehow passing in a custom spy object (not sure where, didn't look into it deeply) that checks the auth headers are set, but that might not be worth the effort. At least with this test we can check both cases where credentials are or are not found, and things work e2e. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
