CTTY commented on code in PR #1400:
URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133354991
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -25,31 +26,39 @@ use std::cmp::Ordering;
use std::collections::HashMap;
use std::mem::discriminant;
use std::sync::Arc;
+use std::time::Duration;
+use backon::{BackoffBuilder, ExponentialBuilder, RetryableWithContext};
+// use tokio_retry2::strategy::ExponentialBackoff;
+// use tokio_retry2::{Retry, RetryError};
use uuid::Uuid;
use crate::TableUpdate::UpgradeFormatVersion;
use crate::error::Result;
use crate::spec::FormatVersion;
use crate::table::Table;
+use crate::transaction::action::{BoxedTransactionAction, SetLocationAction,
TransactionAction};
use crate::transaction::append::FastAppendAction;
use crate::transaction::sort_order::ReplaceSortOrderAction;
use crate::{Catalog, Error, ErrorKind, TableCommit, TableRequirement,
TableUpdate};
/// Table transaction.
-pub struct Transaction<'a> {
- base_table: &'a Table,
+#[derive(Clone)]
+pub struct Transaction {
+ base_table: Table,
current_table: Table,
+ actions: Vec<BoxedTransactionAction>,
updates: Vec<TableUpdate>,
requirements: Vec<TableRequirement>,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
