Re: [PR] Core: Fix incremental compute of partition stats with COW deletes [iceberg]

2025-05-28 Thread via GitHub
lirui-apache commented on code in PR #13163: URL: https://github.com/apache/iceberg/pull/13163#discussion_r2113316192 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -336,17 +337,23 @@ private static PartitionMap computeStatsDiff( Sets.newHas

Re: [PR] static table metadata access support [iceberg-cpp]

2025-05-28 Thread via GitHub
wgtmac commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2113226315 ## src/iceberg/table.h: ## @@ -20,12 +20,16 @@ #pragma once #include +#include Review Comment: What about putting both `BaseTable` and `StaticTable` into a s

Re: [PR] Proposal: IRC Events endpoint [iceberg]

2025-05-28 Thread via GitHub
adnanhemani commented on code in PR #12584: URL: https://github.com/apache/iceberg/pull/12584#discussion_r2113256999 ## open-api/rest-catalog-open-api.py: ## @@ -1389,6 +1558,101 @@ class CommitTableResponse(BaseModel): metadata: TableMetadata +class EventsResponse(Base

Re: [PR] Core: Fix incremental compute of partition stats with COW deletes [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat commented on PR #13163: URL: https://github.com/apache/iceberg/pull/13163#issuecomment-2918384807 @lirui-apache: Could you please take another look at the fix, verify and approve the PR if it looks good for you? -- This is an automated message from the Apache Git Service. T

Re: [PR] Proposal: IRC Events endpoint [iceberg]

2025-05-28 Thread via GitHub
adnanhemani commented on code in PR #12584: URL: https://github.com/apache/iceberg/pull/12584#discussion_r2113256999 ## open-api/rest-catalog-open-api.py: ## @@ -1389,6 +1558,101 @@ class CommitTableResponse(BaseModel): metadata: TableMetadata +class EventsResponse(Base

Re: [PR] Proposal: IRC Events endpoint [iceberg]

2025-05-28 Thread via GitHub
adnanhemani commented on code in PR #12584: URL: https://github.com/apache/iceberg/pull/12584#discussion_r2113256999 ## open-api/rest-catalog-open-api.py: ## @@ -1389,6 +1558,101 @@ class CommitTableResponse(BaseModel): metadata: TableMetadata +class EventsResponse(Base

Re: [PR] Proposal: IRC Events endpoint [iceberg]

2025-05-28 Thread via GitHub
adnanhemani commented on code in PR #12584: URL: https://github.com/apache/iceberg/pull/12584#discussion_r2113256999 ## open-api/rest-catalog-open-api.py: ## @@ -1389,6 +1558,101 @@ class CommitTableResponse(BaseModel): metadata: TableMetadata +class EventsResponse(Base

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
stevenzwu commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2113243416 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return

Re: [PR] Part 1: Support Scan Planning in Rest Client [iceberg]

2025-05-28 Thread via GitHub
singhpk234 commented on PR #13004: URL: https://github.com/apache/iceberg/pull/13004#issuecomment-2918365113 posting an update here, still brainstorming if there is better solution than ThreadLocal, objectMapper and setInjectableValues which can add updated at client level, though this woul

Re: [PR] SPARK: Remove dependency on hadoop's filesystem class from remove orphan files [iceberg]

2025-05-28 Thread via GitHub
liziyan-lzy commented on code in PR #12254: URL: https://github.com/apache/iceberg/pull/12254#discussion_r2113180858 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -107,9 +115,12 @@ public abstract class TestRemoveOrpha

Re: [PR] Core: Add basic classes for writing table format-version 4 [iceberg]

2025-05-28 Thread via GitHub
manuzhang commented on code in PR #13123: URL: https://github.com/apache/iceberg/pull/13123#discussion_r2113154440 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -54,7 +54,7 @@ public class TestHelpers { private TestHelpers() {} - public static final int

Re: [PR] Core: Add basic classes for writing table format-version 4 [iceberg]

2025-05-28 Thread via GitHub
manuzhang commented on code in PR #13123: URL: https://github.com/apache/iceberg/pull/13123#discussion_r2113153555 ## core/src/test/java/org/apache/iceberg/DeleteFileIndexTestBase.java: ## @@ -50,7 +51,7 @@ public abstract class DeleteFileIndexTestBase< @Parameters(name = "

[I] pyiceberg write an extra .db in the schema path [iceberg-python]

2025-05-28 Thread via GitHub
djouallah opened a new issue, #2052: URL: https://github.com/apache/iceberg-python/issues/2052 ### Apache Iceberg version None ### Please describe the bug 🐞 pyiceberg add an extra .dot in the path, is there a way to turn it off. ``` from pyiceberg.catalog.sql

Re: [PR] REST: Avoid table corruption on self conflicts due to internal HTTP retries [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #12818: URL: https://github.com/apache/iceberg/pull/12818#discussion_r2113105286 ## core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java: ## @@ -91,7 +91,22 @@ public void accept(ErrorResponse error) { case 404:

Re: [PR] REST: Avoid table corruption on self conflicts due to internal HTTP retries [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #12818: URL: https://github.com/apache/iceberg/pull/12818#discussion_r2113105286 ## core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java: ## @@ -91,7 +91,22 @@ public void accept(ErrorResponse error) { case 404:

Re: [I] ERROR: Procedure system.refresh_table not found [iceberg]

2025-05-28 Thread via GitHub
manuzhang commented on issue #13171: URL: https://github.com/apache/iceberg/issues/13171#issuecomment-2918129980 @vishwanthp12 We don't have such a Spark procedure as `refresh_table`. All procedures can be found at https://iceberg.apache.org/docs/nightly/spark-procedures/. -- This is an

Re: [I] Add docs of Spark SQL functions for Iceberg transforms [iceberg]

2025-05-28 Thread via GitHub
manuzhang commented on issue #13156: URL: https://github.com/apache/iceberg/issues/13156#issuecomment-2918127635 @VerneZhong I mean https://github.com/apache/iceberg/blob/main/docs/docs/spark-queries.md -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2113087795 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2113087795 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2113087795 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2113087795 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2113087795 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2113087795 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [I] feature to add timestamp in data and metadata file names in iceberg [iceberg]

2025-05-28 Thread via GitHub
yadav-ankit commented on issue #12935: URL: https://github.com/apache/iceberg/issues/12935#issuecomment-2918068072 The main objective of this issue was to identify the specific parquet file , i think that can be achieved via query as well. We are good to close this. Thanks for your

Re: [I] feature to add timestamp in data and metadata file names in iceberg [iceberg]

2025-05-28 Thread via GitHub
yadav-ankit closed issue #12935: feature to add timestamp in data and metadata file names in iceberg URL: https://github.com/apache/iceberg/issues/12935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Support build full-text and vector index for iceberg [iceberg]

2025-05-28 Thread via GitHub
osscm commented on issue #12636: URL: https://github.com/apache/iceberg/issues/12636#issuecomment-2918056667 We would also love to collaborate on this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] validate added data files for snapshot compatibility [iceberg-python]

2025-05-28 Thread via GitHub
sungwy commented on code in PR #2050: URL: https://github.com/apache/iceberg-python/pull/2050#discussion_r2112948288 ## pyiceberg/table/update/validate.py: ## @@ -24,7 +24,8 @@ from pyiceberg.table.snapshots import Operation, Snapshot, ancestors_between from pyiceberg.typedef

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-05-28 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2113019823 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] static table metadata access support [iceberg-cpp]

2025-05-28 Thread via GitHub
lishuxu commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2113025457 ## src/iceberg/table.cc: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] API, Core: Geospatial bounds and spatial predicates [iceberg]

2025-05-28 Thread via GitHub
jiayuasu commented on PR #12667: URL: https://github.com/apache/iceberg/pull/12667#issuecomment-2918002778 @szehon-ho @rdblue would you please review this again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] static table metadata access support [iceberg-cpp]

2025-05-28 Thread via GitHub
lishuxu commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2113020511 ## src/iceberg/table.cc: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] static table metadata access support [iceberg-cpp]

2025-05-28 Thread via GitHub
lishuxu commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2113018762 ## test/table_test_helper.h: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] static table metadata access support [iceberg-cpp]

2025-05-28 Thread via GitHub
lishuxu commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2113017826 ## src/iceberg/table.h: ## @@ -108,4 +109,85 @@ class ICEBERG_EXPORT Table { virtual std::unique_ptr location_provider() const = 0; }; +class ICEBERG_EXPORT Bas

Re: [PR] static table metadata access support [iceberg-cpp]

2025-05-28 Thread via GitHub
lishuxu commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2113017075 ## src/iceberg/table.cc: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] static table metadata access support [iceberg-cpp]

2025-05-28 Thread via GitHub
lishuxu commented on code in PR #111: URL: https://github.com/apache/iceberg-cpp/pull/111#discussion_r2113018054 ## test/table_test.cc: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NO

Re: [PR] pluggable routers [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on PR #12859: URL: https://github.com/apache/iceberg/pull/12859#issuecomment-2917892236 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Parquet: Fix column pruning for deeply nested fields [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on PR #12634: URL: https://github.com/apache/iceberg/pull/12634#issuecomment-2917892202 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Fix failure when reading files table with branch [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on PR #11719: URL: https://github.com/apache/iceberg/pull/11719#issuecomment-2917892128 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] ERROR AppendDataExec: Data source write support IcebergBatchWrite(xxx) aborting [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on issue #11562: URL: https://github.com/apache/iceberg/issues/11562#issuecomment-2917892074 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] When `distribution-mode` = RANGE, Flink Stop-with-savepoint operation will definitely fail [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] closed issue #11556: When `distribution-mode` = RANGE, Flink Stop-with-savepoint operation will definitely fail URL: https://github.com/apache/iceberg/issues/11556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Core/REST: generify AuthSessionCache [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on PR #12562: URL: https://github.com/apache/iceberg/pull/12562#issuecomment-2917892161 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: introduce shared authentication refresh executor [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on PR #12563: URL: https://github.com/apache/iceberg/pull/12563#issuecomment-2917892178 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Fix failure when reading files table with branch [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] closed pull request #11719: Core: Fix failure when reading files table with branch URL: https://github.com/apache/iceberg/pull/11719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [Spark Integration Tests] TestCreateTable::testCreateTableCommitProperties won't work on RESTCatalog [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] closed issue #11554: [Spark Integration Tests] TestCreateTable::testCreateTableCommitProperties won't work on RESTCatalog URL: https://github.com/apache/iceberg/issues/11554 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] ERROR AppendDataExec: Data source write support IcebergBatchWrite(xxx) aborting [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] closed issue #11562: ERROR AppendDataExec: Data source write support IcebergBatchWrite(xxx) aborting URL: https://github.com/apache/iceberg/issues/11562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] When `distribution-mode` = RANGE, Flink Stop-with-savepoint operation will definitely fail [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on issue #11556: URL: https://github.com/apache/iceberg/issues/11556#issuecomment-2917892050 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] [Spark Integration Tests] TestCreateTable::testCreateTableCommitProperties won't work on RESTCatalog [iceberg]

2025-05-28 Thread via GitHub
github-actions[bot] commented on issue #11554: URL: https://github.com/apache/iceberg/issues/11554#issuecomment-2917892025 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Flink: port range distribution to v2 iceberg sink [iceberg]

2025-05-28 Thread via GitHub
stevenzwu commented on code in PR #12071: URL: https://github.com/apache/iceberg/pull/12071#discussion_r2112952874 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java: ## @@ -645,72 +711,135 @@ private DataStream distributeDataStream(DataStream inp

Re: [PR] Flink 1.19, 1.20: Remove the MiniClusterWithClientResource dependency [iceberg]

2025-05-28 Thread via GitHub
JeonDaehong commented on PR #13165: URL: https://github.com/apache/iceberg/pull/13165#issuecomment-2917869496 > Merged to main. Thanks @JeonDaehong for the backport and @nastra for the review. > > > After my previous PR was merged, I was expecting to see my name listed on the [contri

Re: [I] Add docs of Spark SQL functions for Iceberg transforms [iceberg]

2025-05-28 Thread via GitHub
VerneZhong commented on issue #13156: URL: https://github.com/apache/iceberg/issues/13156#issuecomment-2917847096 @manuzhang Hi, I’m working on documenting the built-in system functions like system.iceberg_version. Should the documentation for such functions (e.g. usage, description,

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
stevenzwu commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2112903188 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
stevenzwu commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2112903188 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
stevenzwu commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2112903188 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
stevenzwu commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2112903188 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-28 Thread via GitHub
stevenzwu commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2112903188 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return

Re: [PR] SPARK: Remove dependency on hadoop's filesystem class from remove orphan files [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on code in PR #12254: URL: https://github.com/apache/iceberg/pull/12254#discussion_r2112725064 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -344,6 +374,8 @@ public void testWapFilesAreKept() {

Re: [PR] SPARK: Remove dependency on hadoop's filesystem class from remove orphan files [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on code in PR #12254: URL: https://github.com/apache/iceberg/pull/12254#discussion_r2112725064 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -344,6 +374,8 @@ public void testWapFilesAreKept() {

Re: [PR] SPARK: Remove dependency on hadoop's filesystem class from remove orphan files [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on code in PR #12254: URL: https://github.com/apache/iceberg/pull/12254#discussion_r2112716340 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -107,9 +115,12 @@ public abstract class TestRemoveOr

Re: [PR] Site: Add Versioned Docs for 1.9.1 [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer merged PR #13172: URL: https://github.com/apache/iceberg/pull/13172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Site: Add Versioned Docs for 1.9.1 [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on PR #13172: URL: https://github.com/apache/iceberg/pull/13172#issuecomment-2917520514 Thanks @ajantha-bhat + @danielcweeks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Docs: Adds 1.9.1 Versioned JavaDocs [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on PR #13173: URL: https://github.com/apache/iceberg/pull/13173#issuecomment-2917518749 Thanks @ajantha-bhat and @danielcweeks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Docs: Adds 1.9.1 Versioned JavaDocs [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer merged PR #13173: URL: https://github.com/apache/iceberg/pull/13173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Infra: Set 1.9.1 to Latest Release [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on PR #13177: URL: https://github.com/apache/iceberg/pull/13177#issuecomment-2917517509 Thanks @ajantha-bhat , @flyrain + @singhpk234 for reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Site: Updates for 1.9.1 Release [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on PR #13176: URL: https://github.com/apache/iceberg/pull/13176#issuecomment-2917516161 Thanks @ajantha-bhat + @danielcweeks for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Site: Updates for 1.9.1 Release [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer merged PR #13176: URL: https://github.com/apache/iceberg/pull/13176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Core: Fix a cast that is too narrow [iceberg]

2025-05-28 Thread via GitHub
angelo-DNAStack commented on PR #12743: URL: https://github.com/apache/iceberg/pull/12743#issuecomment-2917511977 Checking in on this PR again, please let me know if there are any additional changes required. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Infra: Set 1.9.1 to Latest Release [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer merged PR #13177: URL: https://github.com/apache/iceberg/pull/13177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Incremental Append Scan [iceberg-python]

2025-05-28 Thread via GitHub
smaheshwar-pltr commented on PR #2031: URL: https://github.com/apache/iceberg-python/pull/2031#issuecomment-2917350349 Put up https://github.com/apache/iceberg/issues/13179 re an append-only option -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] Append-only option for Spark incremental append read that throws [iceberg]

2025-05-28 Thread via GitHub
smaheshwar-pltr commented on issue #13179: URL: https://github.com/apache/iceberg/issues/13179#issuecomment-2917349624 Not sure who to ping here so CC-ing folks I see on previous Spark incremental read work 😄: @aokolnychyi @huaxingao @szehon-ho @RussellSpitzer, please let me know your thoug

[I] Append-only option for Spark incremental append read that throws [iceberg]

2025-05-28 Thread via GitHub
smaheshwar-pltr opened a new issue, #13179: URL: https://github.com/apache/iceberg/issues/13179 ### Feature Request / Improvement Spark's [incremental append reading](https://iceberg.apache.org/docs/latest/spark-queries/#incremental-read) is useful for append-only incremental workflo

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

2025-05-28 Thread via GitHub
Fokko merged PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] feat: support decompress gzip metadata [iceberg-cpp]

2025-05-28 Thread via GitHub
Fokko commented on PR #108: URL: https://github.com/apache/iceberg-cpp/pull/108#issuecomment-2917339595 LGTM @dongxiao1198 , thanks for the review @wgtmac, @lidavidm and @yingcai-cy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] fix(catalog/glue): Fix nil map assignment issue in glue catalog [iceberg-go]

2025-05-28 Thread via GitHub
lliangyu-lin opened a new pull request, #446: URL: https://github.com/apache/iceberg-go/pull/446 ### Description When calling NewCatalog in glue catalog without any AWS properties, causing the catalog properties to be nil ``` props: iceberg.Properties(glueOps.awsProperties),

[PR] fix(table): fix race condition in scanner [iceberg-go]

2025-05-28 Thread via GitHub
zeroshade opened a new pull request, #445: URL: https://github.com/apache/iceberg-go/pull/445 fixes #443 Eliminates potential race condition in scanning caused by the metrics evaluator used for manifest pruning. Since the stats are only used for a given run of Eval, we don't ne

Re: [I] Build: Fix errorprone warnings [iceberg]

2025-05-28 Thread via GitHub
TomasDarquier commented on issue #13178: URL: https://github.com/apache/iceberg/issues/13178#issuecomment-2917209543 - [x] I can contribute a fix for this bug independently Hi, I’d like to work on this issue — it seems like a great fit for my first contribution. -- This is an automate

Re: [I] Feature request: expose `DataFile` builder as public [iceberg-rust]

2025-05-28 Thread via GitHub
dentiny closed issue #1392: Feature request: expose `DataFile` builder as public URL: https://github.com/apache/iceberg-rust/issues/1392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Feature request: expose `DataFile` builder as public [iceberg-rust]

2025-05-28 Thread via GitHub
dentiny commented on issue #1392: URL: https://github.com/apache/iceberg-rust/issues/1392#issuecomment-2917202154 Sorry I get fooled by gpt and deepseek, the default visibility is public Ref: https://docs.rs/derive_builder/latest/derive_builder/#setter-visibility -- This is an automated

[I] Feature request: expose `DataFile` builder as public [iceberg-rust]

2025-05-28 Thread via GitHub
dentiny opened a new issue, #1392: URL: https://github.com/apache/iceberg-rust/issues/1392 ### Is your feature request related to a problem or challenge? My workflow looks like - Accumulate arrow batches in-memory, flush to local filesystem when it reaches certain threshold - Pe

Re: [PR] build(deps): bump the gomod_updates group with 3 updates [iceberg-go]

2025-05-28 Thread via GitHub
zeroshade merged PR #440: URL: https://github.com/apache/iceberg-go/pull/440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] feat: set snapshot summary property in append action [iceberg-rust]

2025-05-28 Thread via GitHub
dentiny commented on code in PR #1391: URL: https://github.com/apache/iceberg-rust/pull/1391#discussion_r2112436407 ## Cargo.lock: ## @@ -3712,7 +3712,7 @@ dependencies = [ "iceberg-catalog-rest", "iceberg-datafusion", "iceberg_test_utils", - "ordered-float 4.6.0", + "orde

[PR] feat: set snapshot summary property in append action [iceberg-rust]

2025-05-28 Thread via GitHub
dentiny opened a new pull request, #1391: URL: https://github.com/apache/iceberg-rust/pull/1391 ## Which issue does this PR close? - Closes https://github.com/apache/iceberg-rust/issues/1329 ## What changes are included in this PR? This PR tries to do the same thing as re

[I] Build: Fix errorprone warnings [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat opened a new issue, #13178: URL: https://github.com/apache/iceberg/issues/13178 ### Apache Iceberg version None ### Query engine None ### Please describe the bug 🐞 `./gradlew clean build -x test -x integrationTest --no-build-cache` Defaul

Re: [I] Build: Fix errorprone warnings [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat commented on issue #13178: URL: https://github.com/apache/iceberg/issues/13178#issuecomment-2917115167 Good first issue for new contributors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [EPIC] Support for appending data to iceberg table. [iceberg-rust]

2025-05-28 Thread via GitHub
hsingh574 commented on issue #1382: URL: https://github.com/apache/iceberg-rust/issues/1382#issuecomment-2917107145 @CTTY @liurenjie1024 I'm wondering about the commit path proposed for the memory catalog in #1381 , which does #1388 and #1389 , but not the other two things. I think the retr

Re: [PR] Spec: Mark version 3 as completed [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat commented on PR #13175: URL: https://github.com/apache/iceberg/pull/13175#issuecomment-2917086695 > I don't think we need another vote for this but let's get a few more reviewers just to check. @rdblue heads up Yes, thats why I mentioned this on mailing list reply to orig

Re: [PR] build(deps): bump the gomod_updates group with 3 updates [iceberg-go]

2025-05-28 Thread via GitHub
zeroshade commented on PR #440: URL: https://github.com/apache/iceberg-go/pull/440#issuecomment-2917086522 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Spec: Mark version 3 as completed [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on PR #13175: URL: https://github.com/apache/iceberg/pull/13175#issuecomment-2917077668 I don't think we need another vote for this but let's get a few more reviewers just to check. @rdblue heads up -- This is an automated message from the Apache Git Service. To r

Re: [PR] feat: Introduce snapshot summary properties [iceberg-rust]

2025-05-28 Thread via GitHub
dentiny commented on PR #1336: URL: https://github.com/apache/iceberg-rust/pull/1336#issuecomment-2917071079 > The `SnapshotUpdate` is a super interface of tx actions that could produce a new snapshot, so in theory you could use any tx action that produces a new snapshot to do that. Current

[PR] Infra: Set 1.9.1 to Latest Release [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer opened a new pull request, #13177: URL: https://github.com/apache/iceberg/pull/13177 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Site: Updates for 1.9.1 Release [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat commented on code in PR #13176: URL: https://github.com/apache/iceberg/pull/13176#discussion_r2112393526 ## site/docs/releases.md: ## @@ -67,12 +67,29 @@ To add a dependency on Iceberg in Maven, add the following to your `pom.xml`: ``` +### 1.9.1 release + +Ap

Re: [PR] Site: Updates for 1.9.1 Release [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat commented on code in PR #13176: URL: https://github.com/apache/iceberg/pull/13176#discussion_r2112389501 ## site/docs/releases.md: ## @@ -67,12 +67,29 @@ To add a dependency on Iceberg in Maven, add the following to your `pom.xml`: ``` +### 1.9.1 release + +Ap

Re: [PR] fix(ci): Fix the minio config [iceberg-go]

2025-05-28 Thread via GitHub
kevinjqliu merged PR #444: URL: https://github.com/apache/iceberg-go/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Site: Updates for 1.9.1 Release [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat commented on code in PR #13176: URL: https://github.com/apache/iceberg/pull/13176#discussion_r2112389114 ## site/docs/releases.md: ## @@ -67,12 +67,29 @@ To add a dependency on Iceberg in Maven, add the following to your `pom.xml`: ``` +### 1.9.1 release + +Ap

Re: [PR] Site: Updates for 1.9.1 Release [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer commented on code in PR #13176: URL: https://github.com/apache/iceberg/pull/13176#discussion_r2112379370 ## site/docs/releases.md: ## @@ -67,12 +67,29 @@ To add a dependency on Iceberg in Maven, add the following to your `pom.xml`: ``` +### 1.9.1 release + +

[PR] Site: Updates for 1.9.1 Release [iceberg]

2025-05-28 Thread via GitHub
RussellSpitzer opened a new pull request, #13176: URL: https://github.com/apache/iceberg/pull/13176 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] feat(catalog/sql): Add views related ops [iceberg-go]

2025-05-28 Thread via GitHub
dttung2905 commented on PR #414: URL: https://github.com/apache/iceberg-go/pull/414#issuecomment-2917038862 > @dttung2905 figured out the issue, https://github.com/apache/iceberg-go/pull/444 fixes it so you can rebase once that gets merged. Sure. Let me rebase it again in a few hours

Re: [PR] feat(catalog/sql): Add views related ops [iceberg-go]

2025-05-28 Thread via GitHub
zeroshade commented on PR #414: URL: https://github.com/apache/iceberg-go/pull/414#issuecomment-2917034876 @dttung2905 figured out the issue, https://github.com/apache/iceberg-go/pull/444 fixes it so you can rebase once that gets merged. -- This is an automated message from the Apache Gi

[PR] fix(ci): Fix the minio config [iceberg-go]

2025-05-28 Thread via GitHub
zeroshade opened a new pull request, #444: URL: https://github.com/apache/iceberg-go/pull/444 taken from https://github.com/apache/iceberg-python/pull/2049 Looks like `mc config` is deprecated https://github.com/minio/mc/issues/5206 -- This is an automated message from the Apache Gi

Re: [PR] Core: Add basic classes for writing table format-version 4 [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat commented on code in PR #13123: URL: https://github.com/apache/iceberg/pull/13123#discussion_r2112353388 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -54,7 +54,7 @@ public class TestHelpers { private TestHelpers() {} - public static final

[PR] Spec: Mark version 3 as completed [iceberg]

2025-05-28 Thread via GitHub
ajantha-bhat opened a new pull request, #13175: URL: https://github.com/apache/iceberg/pull/13175 voted on mailing list: https://lists.apache.org/thread/9oncq0j0222nrm6scvm89xdq3gozg24p -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

  1   2   >