Re: [PR] refactor: simplify library management [iceberg-cpp]

2025-03-26 Thread via GitHub
yingcai-cy commented on code in PR #52: URL: https://github.com/apache/iceberg-cpp/pull/52#discussion_r2015764778 ## README.md: ## @@ -52,7 +52,7 @@ cmake --install build Provided Apache Arrow ```bash -cmake -S . -B build -DCMAKE_INSTALL_PREFIX=/path/to/install -DCMAKE

Re: [I] AWS: Creating a Glue table with Lake Formation enabled fails [iceberg]

2025-03-26 Thread via GitHub
xiaoxuandev commented on issue #10226: URL: https://github.com/apache/iceberg/issues/10226#issuecomment-2756807570 Hi, sorry for the delay. If you're still experiencing issues, could you try removing `'io-impl'='org.apache.iceberg.aws.s3.S3FileIO'` from the configuration to see if the error

Re: [PR] Spark 3.4 : Use correct statistics file in SparkScan::estimateStatistics(Snapshot) [iceberg]

2025-03-26 Thread via GitHub
pvary commented on code in PR #12647: URL: https://github.com/apache/iceberg/pull/12647#discussion_r2015704267 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java: ## @@ -195,8 +196,10 @@ protected Statistics estimateStatistics(Snapshot snapshot) {

Re: [PR] HIVE-28801 Iceberg: Refactor HMS table parameter setting to be able to reuse [iceberg]

2025-03-26 Thread via GitHub
pvary commented on code in PR #12461: URL: https://github.com/apache/iceberg/pull/12461#discussion_r2015682309 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
XBaith commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015673209 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access t

Re: [PR] Backport #11702 to FLink1.19 and 1.18 [iceberg]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #12080: URL: https://github.com/apache/iceberg/pull/12080#issuecomment-2756045829 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spark 3.4 : Use correct statistics file in SparkScan::estimateStatistics(Snapshot) [iceberg]

2025-03-26 Thread via GitHub
jeesou commented on PR #12647: URL: https://github.com/apache/iceberg/pull/12647#issuecomment-2756642439 Yes thanks @wypoon for this fix, and for reviewing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
aihuaxu commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015641203 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
rdblue commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015090975 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access t

Re: [PR] Deletion Vectors read support [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu commented on PR #1516: URL: https://github.com/apache/iceberg-python/pull/1516#issuecomment-2755697692 except for the `MAX_JAVA_SIGNED` variable, everything else LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] feat: Add summary functionality to `SnapshotProduceAction` [iceberg-rust]

2025-03-26 Thread via GitHub
jonathanc-n opened a new pull request, #1139: URL: https://github.com/apache/iceberg-rust/pull/1139 ## Which issue does this PR close? - Closes #724 . ## What changes are included in this PR? Added summary functionality to snapshot produce action ## Are the

[PR] Add datafusion cli for iceberg [iceberg-rust]

2025-03-26 Thread via GitHub
liurenjie1024 opened a new pull request, #1143: URL: https://github.com/apache/iceberg-rust/pull/1143 ## Which issue does this PR close? - Closes #1142. ## What changes are included in this PR? Initial check in iceberg cli. ## Are these changes tested? Yes,

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
aihuaxu commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015617762 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
aihuaxu commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015607563 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access

Re: [I] DatasourceV2 does not prune columns after V2ScanRelationPushDown [iceberg]

2025-03-26 Thread via GitHub
Akeron-Zhu commented on issue #9268: URL: https://github.com/apache/iceberg/issues/9268#issuecomment-2756506856 Hi, @IgorBerman @akshayakp97 @rdblue , I also encountered this problem in last year, it is because the Spark3 DSV2 only prune column at V2ScanRelationPushDown, but the later Rewri

Re: [PR] refactor: simplify library management [iceberg-cpp]

2025-03-26 Thread via GitHub
wgtmac commented on PR #52: URL: https://github.com/apache/iceberg-cpp/pull/52#issuecomment-2756309108 FTR, current install directory on my MacOS looks like ``` /tmp/iceberg/ ├── lib/ │ ├── libiceberg_vendored_arrow.a │ ├── libiceberg_vendored_avrocpp.a │ ├── libiceber

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
XBaith commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015466369 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access t

Re: [PR] chore: improve coordinator election logging [iceberg]

2025-03-26 Thread via GitHub
kumarpritam863 commented on PR #12609: URL: https://github.com/apache/iceberg/pull/12609#issuecomment-2756329408 I do not think for that we should be having redundant checks on members as that is the only scenario in which there will be no co-ordinator, in all cases the open is called after

[PR] refactor: simplify library management [iceberg-cpp]

2025-03-26 Thread via GitHub
wgtmac opened a new pull request, #52: URL: https://github.com/apache/iceberg-cpp/pull/52 Libraries are consolidated to `libiceberg` and `libiceberg-bundle` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Prototyping Spark 3.4 row lineage [iceberg]

2025-03-26 Thread via GitHub
amogh-jahagirdar opened a new pull request, #12592: URL: https://github.com/apache/iceberg/pull/12592 This is a very rough prototyping PR for just demonstrating how we'd update the spark extension rules to appropriately nullify or preserve the row id/last updated sequence metadata attribute

Re: [I] Table rename in Glue Catalog throws Incorrect `AlreadyExistsException` [iceberg]

2025-03-26 Thread via GitHub
ZygimantasKoncius closed issue #11155: Table rename in Glue Catalog throws Incorrect `AlreadyExistsException` URL: https://github.com/apache/iceberg/issues/11155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Overwrite with Filter Conditions Example - Large Amount of Filter Conditions [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu closed issue #1571: Overwrite with Filter Conditions Example - Large Amount of Filter Conditions URL: https://github.com/apache/iceberg-python/issues/1571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014782759 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroupPlanner.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] chore: improve coordinator election logging [iceberg]

2025-03-26 Thread via GitHub
vl-kp commented on PR #12609: URL: https://github.com/apache/iceberg/pull/12609#issuecomment-2756183687 > iceberg.connect.group-id this should be the consumer group ID, as this is used to get the info on the consumer group. If this is not provided or wrongly provided then that is probably a

Re: [PR] Remove deprecated code [iceberg-rust]

2025-03-26 Thread via GitHub
liurenjie1024 merged PR #1141: URL: https://github.com/apache/iceberg-rust/pull/1141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Spark 3.4: Migrate SparkRowLevelOperationsTestBase related tests to JUnit 5 [iceberg]

2025-03-26 Thread via GitHub
tomtongue commented on PR #12656: URL: https://github.com/apache/iceberg/pull/12656#issuecomment-2756166607 @nastra When you have a chance, could you review this? I migrate the ExtensionsBase related tests to Spark 3.5 in this PR (and thanks for replacing the test base!) -- This is an

Re: [PR] API: Define RepairManifests action interface [iceberg]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2756045712 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spec: Allow the use of `source-id` in V3 [iceberg]

2025-03-26 Thread via GitHub
sfc-gh-bhannel commented on code in PR #12644: URL: https://github.com/apache/iceberg/pull/12644#discussion_r2014937438 ## format/spec.md: ## @@ -1414,12 +1414,16 @@ Each partition field in `fields` is stored as a JSON object with the following p | V1 | V2 | V3

Re: [PR] Core: Add support for Avro's timestamp-millis LogicalType in DataReader [iceberg]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #12397: URL: https://github.com/apache/iceberg/pull/12397#issuecomment-2756045914 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Replace usages of Aws4Signer with AwsV4HttpSigner in REST SigV4 [iceberg]

2025-03-26 Thread via GitHub
github-actions[bot] closed pull request #12295: Replace usages of Aws4Signer with AwsV4HttpSigner in REST SigV4 URL: https://github.com/apache/iceberg/pull/12295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Spec: Allow the use of `source-id` in V3 [iceberg]

2025-03-26 Thread via GitHub
szehon-ho commented on PR #12644: URL: https://github.com/apache/iceberg/pull/12644#issuecomment-2756063498 Hi @Fokko i havent take a look yet at spec change, but for multi bucket we had some discussions last year. For reference the pr is here : https://github.com/apache/iceberg/pull/8259

Re: [PR] Replace usages of Aws4Signer with AwsV4HttpSigner in REST SigV4 [iceberg]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #12295: URL: https://github.com/apache/iceberg/pull/12295#issuecomment-2756045874 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015157484 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015139989 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015155240 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015152999 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015149619 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015142847 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

2025-03-26 Thread via GitHub
Fokko merged PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [I] [feat] push down schema casting to the record batch level [iceberg-python]

2025-03-26 Thread via GitHub
Fokko closed issue #1049: [feat] push down schema casting to the record batch level URL: https://github.com/apache/iceberg-python/issues/1049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-26 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2008319167 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +565,148 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015125611 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroupPlanner.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
amogh-jahagirdar commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015106875 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direc

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
amogh-jahagirdar commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015106875 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direc

[PR] Remove deprecated code [iceberg-rust]

2025-03-26 Thread via GitHub
Fokko opened a new pull request, #1141: URL: https://github.com/apache/iceberg-rust/pull/1141 ## Which issue does this PR close? - Closes #. ## What changes are included in this PR? ## Are these changes tested? -- This is an automated message fr

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015095511 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] spec: Variant lower/upper bounds [iceberg]

2025-03-26 Thread via GitHub
rdblue commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2015090975 ## format/spec.md: ## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access t

Re: [PR] Remove `paste` dependency by expanding previously macro-generated code [iceberg-rust]

2025-03-26 Thread via GitHub
Fokko commented on PR #1138: URL: https://github.com/apache/iceberg-rust/pull/1138#issuecomment-2755854533 Great seeing you here @hendrikmakait 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Trying to access closed classloader on AWS 'getFileStatus' [iceberg]

2025-03-26 Thread via GitHub
xiaoxuandev commented on issue #12654: URL: https://github.com/apache/iceberg/issues/12654#issuecomment-2755895422 Hi, are you running this on EMR? Which version are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Core: ability to create REST catalog with external AuthManager [iceberg]

2025-03-26 Thread via GitHub
gh-yzou commented on PR #12655: URL: https://github.com/apache/iceberg/pull/12655#issuecomment-2755697834 @adutra Thanks a lot for putting on this PR! Yes, have a way to inject the AuthManager would be very useful for Polaris Spark client. Polaris provides native support for Iceberg

Re: [PR] HIVE-28801 Iceberg: Refactor HMS table parameter setting to be able to reuse [iceberg]

2025-03-26 Thread via GitHub
wypoon commented on code in PR #12461: URL: https://github.com/apache/iceberg/pull/12461#discussion_r2014954082 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015078649 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] Fix naming [iceberg-python]

2025-03-26 Thread via GitHub
Fokko opened a new pull request, #1857: URL: https://github.com/apache/iceberg-python/pull/1857 # Rationale for this change Small copy-paste :) # Are these changes tested? # Are there any user-facing changes? -- This is an automated message from the Apache

Re: [PR] Deletion Vectors read support [iceberg-python]

2025-03-26 Thread via GitHub
Fokko merged PR #1516: URL: https://github.com/apache/iceberg-python/pull/1516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2025-03-26 Thread via GitHub
ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r2014974633 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015046752 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

2025-03-26 Thread via GitHub
Fokko commented on code in PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r2015042363 ## tests/integration/test_reads.py: ## @@ -837,10 +837,10 @@ def test_table_scan_default_to_large_types(catalog: Catalog) -> None: expected_schema = pa.sch

Re: [PR] Arrow: Infer the types when reading [iceberg-python]

2025-03-26 Thread via GitHub
Fokko commented on PR #1669: URL: https://github.com/apache/iceberg-python/pull/1669#issuecomment-2755822244 > should we first bump min version to Arrow 18? If you don't use date types, then everything works fine :) I'm a bit hesitant to bump it very aggressively, see https://github.

Re: [I] Support Deletion Vectors [iceberg-python]

2025-03-26 Thread via GitHub
Fokko closed issue #1549: Support Deletion Vectors URL: https://github.com/apache/iceberg-python/issues/1549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Deletion Vectors read support [iceberg-python]

2025-03-26 Thread via GitHub
Fokko commented on code in PR #1516: URL: https://github.com/apache/iceberg-python/pull/1516#discussion_r2015012515 ## pyiceberg/table/puffin.py: ## Review Comment: Played around with some snippets, but I think I'll leave it as is now :) -- This is an automated message

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014994662 ## core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java: ## @@ -49,15 +56,15 @@ public abstract class SizeBasedDataRewriter extends SizeBa

Re: [PR] HIVE-28801 Iceberg: Refactor HMS table parameter setting to be able to reuse [iceberg]

2025-03-26 Thread via GitHub
wypoon commented on code in PR #12461: URL: https://github.com/apache/iceberg/pull/12461#discussion_r2014950206 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2025-03-26 Thread via GitHub
ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r2014974226 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2025-03-26 Thread via GitHub
ChaladiMohanVamsi commented on PR #11577: URL: https://github.com/apache/iceberg/pull/11577#issuecomment-2755718534 @nastra @danielcweeks can you please review on the latest changes handling review comments. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

2025-03-26 Thread via GitHub
stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014975086 ## core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewritePlanner.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2025-03-26 Thread via GitHub
ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r2014972775 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2025-03-26 Thread via GitHub
ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r2014929124 ## azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java: ## @@ -25,24 +25,42 @@ import java.util.Collections; import java.util.Map; import j

Re: [I] Reliability: MERGE INTO is not idempotent when no matches are found [iceberg]

2025-03-26 Thread via GitHub
hussein-awala commented on issue #12653: URL: https://github.com/apache/iceberg/issues/12653#issuecomment-2755659837 Thanks @RussellSpitzer for this investigation. All my tests only had a no-match clause. For the query with a match clause, I just checked the operation in the commit metrics,

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2025-03-26 Thread via GitHub
ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r2014928582 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2025-03-26 Thread via GitHub
ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r2014924473 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Found

Re: [I] Forbidden Exception creating Polaris Rest catalog with Flink 1.20 [iceberg]

2025-03-26 Thread via GitHub
shantanu-dahiya commented on issue #11836: URL: https://github.com/apache/iceberg/issues/11836#issuecomment-2741984160 @george-zubrienko I see [iceberg 1.8.1](https://github.com/apache/iceberg/blob/apache-iceberg-1.8.1/gradle/libs.versions.toml) imports httpcomponents version `5.4.1`, but t

Re: [PR] Use delimited column names in CreateChangelogViewProcedure [iceberg]

2025-03-26 Thread via GitHub
andyglow commented on PR #12418: URL: https://github.com/apache/iceberg/pull/12418#issuecomment-2755594152 thanks for the review @nastra I addressed your comments. Please take another look -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Deletion Vectors read support [iceberg-python]

2025-03-26 Thread via GitHub
Fokko commented on code in PR #1516: URL: https://github.com/apache/iceberg-python/pull/1516#discussion_r2014898543 ## pyiceberg/table/puffin.py: ## Review Comment: Thanks for sharing, that looks pretty neat -- This is an automated message from the Apache Git Service. T

Re: [I] Compatibility Issue with pydantic and annotated-types in pyiceberg 0.8.1 [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu closed issue #1418: Compatibility Issue with pydantic and annotated-types in pyiceberg 0.8.1 URL: https://github.com/apache/iceberg-python/issues/1418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Core: Support incremental compute for partition stats [iceberg]

2025-03-26 Thread via GitHub
ajantha-bhat commented on code in PR #12629: URL: https://github.com/apache/iceberg/pull/12629#discussion_r2014320125 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -53,14 +56,43 @@ public static Collection computeStats(Table table, Snapshot snap

Re: [PR] Docs: Fix ASF sponsorship links [iceberg]

2025-03-26 Thread via GitHub
Fokko merged PR #12646: URL: https://github.com/apache/iceberg/pull/12646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [I] Clean up import in `test_schema.py` [iceberg-python]

2025-03-26 Thread via GitHub
Fokko commented on issue #1852: URL: https://github.com/apache/iceberg-python/issues/1852#issuecomment-2755473627 @sunxiaojian sure thing! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] API: Follow up on adding Variant data type to implement sanitizing fo… [iceberg]

2025-03-26 Thread via GitHub
aihuaxu commented on PR #12611: URL: https://github.com/apache/iceberg/pull/12611#issuecomment-2755506786 > @aihuaxu > > Since this is first PR, need to discuss few things before in hand to ensure the direction is correct. Hence, marking the pr as draft for now. > > Added a new

Re: [I] [feature] Investigate integrations leveraging the PyCapsule protocol [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu commented on issue #1655: URL: https://github.com/apache/iceberg-python/issues/1655#issuecomment-2755166500 @WillAyd thanks for the suggestion! I haven't investigate this yet. But i see `__arrow_c_stream__` docs [here](https://arrow.apache.org/docs/format/CDataInterface/PyCapsul

[PR] Spark 3.4: Migrate SparkRowLevelOperationsTestBase related tests to JUnit 5 [iceberg]

2025-03-26 Thread via GitHub
tomtongue opened a new pull request, #12656: URL: https://github.com/apache/iceberg/pull/12656 *Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to https://github.com/apache/iceberg/issues/7160* This PR migrates `SparkRowLevelOperationsTestBase` r

[I] [discuss] PyIceberg Near-Term Roadmap [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu opened a new issue, #1856: URL: https://github.com/apache/iceberg-python/issues/1856 ### Feature Request / Improvement This issue tracks some of areas of focus for the pyiceberg project in the near term. The previous roadmap (#736) was created right before Iceberg Su

Re: [I] PyIceberg Near-Term Roadmap [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu commented on issue #736: URL: https://github.com/apache/iceberg-python/issues/736#issuecomment-2755438192 @glesperance i just added #1856 please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Fix thrift client connection for Kerberos Hive Client [iceberg-python]

2025-03-26 Thread via GitHub
Fokko commented on PR #1747: URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2755425442 @kevinjqliu I think this one is also good for 0.9.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Build: Bump griffe from 1.6.2 to 1.6.3 [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu merged PR #1855: URL: https://github.com/apache/iceberg-python/pull/1855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Doc: Update Instructions for rewrite_table_path. [iceberg]

2025-03-26 Thread via GitHub
slfan1989 commented on PR #12628: URL: https://github.com/apache/iceberg/pull/12628#issuecomment-2754908935 @manuzhang I also noticed a small change. Since #11147 has been fixed and the latest version of Iceberg (apache-iceberg-1.8.1) has been released, which includes the fix for #11157, I

Re: [I] PyIceberg Near-Term Roadmap [iceberg-python]

2025-03-26 Thread via GitHub
glesperance commented on issue #736: URL: https://github.com/apache/iceberg-python/issues/736#issuecomment-2755414983 @kevinjqliu whats the best palce to follow the roadmap now that we're closing this? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] chore: improve coordinator election logging [iceberg]

2025-03-26 Thread via GitHub
kumarpritam863 commented on PR #12609: URL: https://github.com/apache/iceberg/pull/12609#issuecomment-2754674429 iceberg.connect.group-id this should be the consumer group ID, as this is used to get the info on the consumer group. If this is not provided or wrongly provided then that is pro

Re: [I] Remove `paste` dependency. [iceberg-rust]

2025-03-26 Thread via GitHub
Xuanwo closed issue #1064: Remove `paste` dependency. URL: https://github.com/apache/iceberg-rust/issues/1064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Remove `paste` dependency by expanding previously macro-generated code [iceberg-rust]

2025-03-26 Thread via GitHub
Xuanwo merged PR #1138: URL: https://github.com/apache/iceberg-rust/pull/1138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [I] [feature] Investigate integrations leveraging the PyCapsule protocol [iceberg-python]

2025-03-26 Thread via GitHub
WillAyd commented on issue #1655: URL: https://github.com/apache/iceberg-python/issues/1655#issuecomment-2755323047 Using the terminology from the Arrow standard, the presence of `__arrow_c_stream__` on an object would signal that you are a _producer_ of Arrow data. A _consumer_ may inspec

Re: [I] Parquet column array> with null value is read in as empty list [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu closed issue #251: Parquet column array> with null value is read in as empty list URL: https://github.com/apache/iceberg-python/issues/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Spec][Upstream] Mapping from DecimalType to Parquet physical type not aligned with spec [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu commented on issue #936: URL: https://github.com/apache/iceberg-python/issues/936#issuecomment-2755080117 dup of #1789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-03-26 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2014744159 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Spark : Backporting Correct Stats file fetch fix to Spark 3.4 [iceberg]

2025-03-26 Thread via GitHub
wypoon commented on PR #12647: URL: https://github.com/apache/iceberg/pull/12647#issuecomment-2755295157 This is a clean backport of my fix. @jeesou can you please use the same title as the original fix, prefixed by "Spark 3.4" -- "Spark 3.4: Use correct statistics file in SparkScan::

Re: [PR] CORE: Inject OAuth2 Token from TableSession [iceberg]

2025-03-26 Thread via GitHub
wolflex888 commented on code in PR #12635: URL: https://github.com/apache/iceberg/pull/12635#discussion_r2014648107 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -414,6 +416,10 @@ public Table loadTable(SessionContext context, TableIdentifier iden

Re: [PR] Core, Spark: Add row lineage metadata columns, and surface them in SparkTable metadata columns [iceberg]

2025-03-26 Thread via GitHub
amogh-jahagirdar commented on code in PR #12596: URL: https://github.com/apache/iceberg/pull/12596#discussion_r2014658672 ## core/src/main/java/org/apache/iceberg/MetadataColumns.java: ## @@ -93,21 +93,34 @@ private MetadataColumns() {} "_commit_snapshot_id",

[PR] Build: Bump pyparsing from 3.2.2 to 3.2.3 [iceberg-python]

2025-03-26 Thread via GitHub
dependabot[bot] opened a new pull request, #1854: URL: https://github.com/apache/iceberg-python/pull/1854 Bumps [pyparsing](https://github.com/pyparsing/pyparsing) from 3.2.2 to 3.2.3. Changelog Sourced from https://github.com/pyparsing/pyparsing/blob/master/CHANGES";>pyparsing's

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-03-26 Thread via GitHub
sungwy commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r2014648551 ## open-api/rest-catalog-open-api.yaml: ## @@ -4458,7 +4458,9 @@ components: # The fields `message` and `type` as indicated here are not presently prescriptive.

Re: [PR] CORE: Inject OAuth2 Token from TableSession [iceberg]

2025-03-26 Thread via GitHub
wolflex888 commented on code in PR #12635: URL: https://github.com/apache/iceberg/pull/12635#discussion_r2014648107 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -414,6 +416,10 @@ public Table loadTable(SessionContext context, TableIdentifier iden

Re: [I] how to enable in compaction status, Snapshot retention status, orphan file deletion status on aws glue tables.for reference i have [iceberg-python]

2025-03-26 Thread via GitHub
kevinjqliu closed issue #1829: how to enable in compaction status, Snapshot retention status, orphan file deletion status on aws glue tables.for reference i have URL: https://github.com/apache/iceberg-python/issues/1829 -- This is an automated message from the Apache Git Service. To respond

  1   2   3   >