Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

2025-03-17 Thread via GitHub
lidavidm commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2731829868 I have a branch queued up to set up the CMake build "properly" so that we can use it downstream: https://github.com/apache/iceberg-rust/compare/add-c-binding...lidavidm:iceberg-rust:a

Re: [PR] Core: Add `view-override` catalog property [iceberg]

2025-03-17 Thread via GitHub
nastra merged PR #12534: URL: https://github.com/apache/iceberg/pull/12534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Make `schema` and `partition_spec` optional for TableMetadataV1 [iceberg-rust]

2025-03-17 Thread via GitHub
Fokko commented on PR #1087: URL: https://github.com/apache/iceberg-rust/pull/1087#issuecomment-2731762486 Thanks for raising this PR @phillipleblanc and sending the email on `dev@iceberg.a.o`. Reference: https://lists.apache.org/thread/npgwpgcwgft9h85ozjrds4yh2yrfy0vg -- This is an auto

Re: [I] CLI list not working [iceberg-python]

2025-03-17 Thread via GitHub
github-actions[bot] commented on issue #1122: URL: https://github.com/apache/iceberg-python/issues/1122#issuecomment-2731249919 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the A

Re: [I] catalog table-default and table-override properties are not supported in CREATE_OR_REPLACE operation in IRC [iceberg]

2025-03-17 Thread via GitHub
puchengy commented on issue #12506: URL: https://github.com/apache/iceberg/issues/12506#issuecomment-2731614504 @RussellSpitzer Sorry that I did not make it clear. I think this is not an issue specific to Gravitino and I think other IRC implementations should have the same problem. You have

Re: [PR] feat(table): Add files to partitioned tables [iceberg-go]

2025-03-17 Thread via GitHub
kevinjqliu commented on code in PR #338: URL: https://github.com/apache/iceberg-go/pull/338#discussion_r2000145624 ## table/snapshots.go: ## @@ -306,6 +307,37 @@ func (s Snapshot) Manifests(fio iceio.IO) ([]iceberg.ManifestFile, error) { return nil, nil } +func (s Sn

Re: [I] Does main branch reference reset requiring a clean up of snapshot logs [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] commented on issue #11109: URL: https://github.com/apache/iceberg/issues/11109#issuecomment-2731247045 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] catalog table-default and table-override properties are not supported in CREATE_OR_REPLACE operation in IRC [iceberg]

2025-03-17 Thread via GitHub
puchengy commented on issue #12506: URL: https://github.com/apache/iceberg/issues/12506#issuecomment-2731528367 Hi @nastra, Gravitino did not do anything but simply pass the properties to HiveCatalog during table creation -- This is an automated message from the Apache Git Service. To res

Re: [PR] Build: Bump polars from 1.25.0 to 1.25.2 [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu merged PR #1802: URL: https://github.com/apache/iceberg-python/pull/1802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Build: Bump mkdocs-material from 9.6.8 to 9.6.9 [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu merged PR #1801: URL: https://github.com/apache/iceberg-python/pull/1801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [I] Unable to read some Iceberg V1 tables [iceberg-rust]

2025-03-17 Thread via GitHub
kevinjqliu commented on issue #1088: URL: https://github.com/apache/iceberg-rust/issues/1088#issuecomment-2731505702 devlist discussion, https://lists.apache.org/thread/npgwpgcwgft9h85ozjrds4yh2yrfy0vg -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: fix delete files sequence comparison [iceberg-rust]

2025-03-17 Thread via GitHub
chenzl25 commented on code in PR #1077: URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r291436 ## crates/iceberg/src/delete_file_index.rs: ## @@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex { self.global_deletes .iter() -

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999636597 ## docs/docs/aws.md: ## @@ -669,6 +665,63 @@ Users can use catalog properties to override the defaults. For example, to confi --conf spark.sql.catalog.my_catal

Re: [I] Issue with IsIn Predicate Formatting in Iceberg-Go [iceberg-go]

2025-03-17 Thread via GitHub
zeroshade commented on issue #335: URL: https://github.com/apache/iceberg-go/issues/335#issuecomment-2731401069 So the bug here is that it's not returning an ErrNotImplemented :smile: Currently, since this library uses `arrow-go` to delegate the filtering we have the limitation that I

Re: [I] Support `PartitionStats` [iceberg-rust]

2025-03-17 Thread via GitHub
jonathanc-n commented on issue #1102: URL: https://github.com/apache/iceberg-rust/issues/1102#issuecomment-2731378219 @liurenjie1024 Is there anything I am missing here, does this require something else? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Variants: Implement toString of SerializedArray and VariantData [iceberg]

2025-03-17 Thread via GitHub
XBaith closed pull request #12498: Variants: Implement toString of SerializedArray and VariantData URL: https://github.com/apache/iceberg/pull/12498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Spark: Add some tests for variant fixup [iceberg]

2025-03-17 Thread via GitHub
XBaith commented on code in PR #12497: URL: https://github.com/apache/iceberg/pull/12497#discussion_r223368 ## core/src/test/java/org/apache/iceberg/RandomVariants.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Enable discussion. [iceberg-rust]

2025-03-17 Thread via GitHub
Xuanwo merged PR #1103: URL: https://github.com/apache/iceberg-rust/pull/1103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Core: PartitionsTable#partitions returns incomplete list in case of partition evolution and NULL partition values [iceberg]

2025-03-17 Thread via GitHub
deniskuzZ commented on code in PR #12528: URL: https://github.com/apache/iceberg/pull/12528#discussion_r1999329563 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -243,6 +245,102 @@ public void testPartitionSpecEvolutionToUnparti

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999621184 ## docs/docs/aws.md: ## @@ -425,12 +426,7 @@ As introduced in the previous sections, `S3FileIO` adopts the latest AWS clients This means for any table manifest

Re: [PR] Make `schema` and `partition_spec` optional for TableMetadataV1 [iceberg-rust]

2025-03-17 Thread via GitHub
liurenjie1024 commented on PR #1087: URL: https://github.com/apache/iceberg-rust/pull/1087#issuecomment-2731363997 Seems this is java's inconsistent behavior with spec, and the spec says in v1 it should be deprecated. Java implementation's behavior seems reasonable to me, maybe we should ra

Re: [PR] Core: Add `view-override` catalog property [iceberg]

2025-03-17 Thread via GitHub
ebyhr commented on PR #12534: URL: https://github.com/apache/iceberg/pull/12534#issuecomment-2731349767 @nastra Sure, added a new commit documenting the property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] WIP: Interface based DataFile reader and writer API [iceberg]

2025-03-17 Thread via GitHub
liurenjie1024 commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r165495 ## core/src/main/java/org/apache/iceberg/io/datafile/AppenderBuilder.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Make `schema` and `partition_spec` optional for TableMetadataV1 [iceberg-rust]

2025-03-17 Thread via GitHub
c-thiel commented on PR #1087: URL: https://github.com/apache/iceberg-rust/pull/1087#issuecomment-2730461136 Hm, in the Iceberg spec, they are both required for v1 tables: https://iceberg.apache.org/spec/#table-metadata-fields I guess java has no problems reading them? -- This is

Re: [PR] Spark: Add some tests for variant fixup [iceberg]

2025-03-17 Thread via GitHub
aihuaxu commented on code in PR #12497: URL: https://github.com/apache/iceberg/pull/12497#discussion_r101983 ## core/src/test/java/org/apache/iceberg/RandomVariants.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [I] Unexpected `MERGE INTO` behavior - updates applied despite conditions [iceberg]

2025-03-17 Thread via GitHub
nihal111 commented on issue #12558: URL: https://github.com/apache/iceberg/issues/12558#issuecomment-2731291519 Ah, I should have been more clear with the query example. My desired behavior is for the query to update records (matched on id) that have a changed value (in other columns) but d

Re: [I] CLI list not working [iceberg-python]

2025-03-17 Thread via GitHub
github-actions[bot] closed issue #1122: CLI list not working URL: https://github.com/apache/iceberg-python/issues/1122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Inconsistent id definition on Flink resolvedSchema conversion to iceberg schema [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] commented on issue #11128: URL: https://github.com/apache/iceberg/issues/11128#issuecomment-2731247100 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] Parquet: Implement Variant metrics [iceberg]

2025-03-17 Thread via GitHub
aihuaxu commented on code in PR #12496: URL: https://github.com/apache/iceberg/pull/12496#discussion_r1999896330 ## .palantir/revapi.yml: ## @@ -1172,6 +1172,11 @@ acceptedBreaks: \ java.util.function.Consumer)" justification: "Removing deprecated code" Review C

Re: [I] CLI list not working [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on issue #1122: URL: https://github.com/apache/iceberg-python/issues/1122#issuecomment-2731252487 dup of #1784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Make REST Catalog Namespace Separator Configurable [iceberg-python]

2025-03-17 Thread via GitHub
github-actions[bot] commented on issue #1183: URL: https://github.com/apache/iceberg-python/issues/1183#issuecomment-2731249890 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [PR] Make `schema` and `partition_spec` optional for TableMetadataV1 [iceberg-rust]

2025-03-17 Thread via GitHub
kevinjqliu commented on PR #1087: URL: https://github.com/apache/iceberg-rust/pull/1087#issuecomment-2731249803 java reads from `partition-specs` first and falls back to `partition-spec` https://github.com/apache/iceberg/blob/3cc4b045c6df776a9167ceb31338e9170d02df4e/core/src/main/java/org

Re: [I] AWS Glue Apache Iceberg Data Recovery [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] commented on issue #11077: URL: https://github.com/apache/iceberg/issues/11077#issuecomment-2731247006 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Cannot update map key [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] closed issue #9163: Cannot update map key URL: https://github.com/apache/iceberg/issues/9163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Table rename in Glue Catalog throws Incorrect `AlreadyExistsException` [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] commented on issue #11155: URL: https://github.com/apache/iceberg/issues/11155#issuecomment-2731247133 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] AWS Glue Apache Iceberg Data Recovery [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] closed issue #11077: AWS Glue Apache Iceberg Data Recovery URL: https://github.com/apache/iceberg/issues/11077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] Cannot update map key [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] commented on issue #9163: URL: https://github.com/apache/iceberg/issues/9163#issuecomment-2731246898 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-17 Thread via GitHub
rdblue merged PR #12457: URL: https://github.com/apache/iceberg/pull/12457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-17 Thread via GitHub
rdblue commented on PR #12457: URL: https://github.com/apache/iceberg/pull/12457#issuecomment-2731190545 Thanks for reviewing, @danielcweeks and @aihuaxu! I'll follow up on some of Dan's comments in later PRs. I'd like to get this one in so I can open PRs for other readers that will u

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1999833881 ## core/src/main/java/org/apache/iceberg/avro/VariantConversion.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-17 Thread via GitHub
rdblue commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1999843486 ## core/src/test/java/org/apache/iceberg/RandomVariants.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-17 Thread via GitHub
rdblue commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1999841799 ## core/src/main/java/org/apache/iceberg/avro/ValueWriters.java: ## @@ -373,6 +382,82 @@ public void write(BigDecimal decimal, Encoder encoder) throws IOException {

Re: [PR] Parquet: Implement Variant metrics [iceberg]

2025-03-17 Thread via GitHub
rdblue commented on code in PR #12496: URL: https://github.com/apache/iceberg/pull/12496#discussion_r1999840961 ## parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java: ## @@ -198,145 +191,4 @@ private static List writeAndRead( return Lists.newArrayLis

Re: [PR] Parquet: Implement Variant metrics [iceberg]

2025-03-17 Thread via GitHub
rdblue commented on code in PR #12496: URL: https://github.com/apache/iceberg/pull/12496#discussion_r1999838308 ## data/src/test/java/org/apache/iceberg/TestMergingMetrics.java: ## @@ -91,8 +87,7 @@ public abstract class TestMergingMetrics { optional(27, "timestam

Re: [PR] Parquet: Implement Variant metrics [iceberg]

2025-03-17 Thread via GitHub
rdblue commented on code in PR #12496: URL: https://github.com/apache/iceberg/pull/12496#discussion_r1999837148 ## .palantir/revapi.yml: ## @@ -1172,6 +1172,11 @@ acceptedBreaks: \ java.util.function.Consumer)" justification: "Removing deprecated code" Review Co

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1999836842 ## core/src/test/java/org/apache/iceberg/RandomVariants.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] AWS: Update the aws-bundle with latest dependencies [iceberg]

2025-03-17 Thread via GitHub
SanjayMarreddi commented on code in PR #12553: URL: https://github.com/apache/iceberg/pull/12553#discussion_r1999793485 ## aws-bundle/NOTICE: ## @@ -44,6 +45,8 @@ NOTICE for Group: software.amazon.awssdk Name: sdk-core Version: 2.30.31 NOTICE for Group: software.amazon.awssd

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1999827309 ## core/src/main/java/org/apache/iceberg/avro/ValueWriters.java: ## @@ -373,6 +382,82 @@ public void write(BigDecimal decimal, Encoder encoder) throws IOExcepti

[I] Unexpected `MERGE INTO` behavior - updates applied despite conditions [iceberg]

2025-03-17 Thread via GitHub
nihal111 opened a new issue, #12558: URL: https://github.com/apache/iceberg/issues/12558 ### Apache Iceberg version 1.7.1 ### Query engine Spark ### Please describe the bug 🐞 While using `MERGE INTO` with Iceberg in Spark, I observed that updates were being

[PR] Build: Bump coverage from 7.6.12 to 7.7.0 [iceberg-python]

2025-03-17 Thread via GitHub
dependabot[bot] opened a new pull request, #1803: URL: https://github.com/apache/iceberg-python/pull/1803 Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.6.12 to 7.7.0. Changelog Sourced from https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst";>coverage's ch

[PR] Build: Bump polars from 1.25.0 to 1.25.2 [iceberg-python]

2025-03-17 Thread via GitHub
dependabot[bot] opened a new pull request, #1802: URL: https://github.com/apache/iceberg-python/pull/1802 Bumps [polars](https://github.com/pola-rs/polars) from 1.25.0 to 1.25.2. Release notes Sourced from https://github.com/pola-rs/polars/releases";>polars's releases. Pytho

[PR] Build: Bump mkdocs-material from 9.6.8 to 9.6.9 [iceberg-python]

2025-03-17 Thread via GitHub
dependabot[bot] opened a new pull request, #1801: URL: https://github.com/apache/iceberg-python/pull/1801 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.8 to 9.6.9. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk

[PR] Build: Bump pypa/cibuildwheel from 2.23.0 to 2.23.1 [iceberg-python]

2025-03-17 Thread via GitHub
dependabot[bot] opened a new pull request, #1800: URL: https://github.com/apache/iceberg-python/pull/1800 Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.23.0 to 2.23.1. Release notes Sourced from https://github.com/pypa/cibuildwheel/releases";>pypa/cibuildwh

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999632461 ## docs/docs/aws.md: ## @@ -669,6 +665,63 @@ Users can use catalog properties to override the defaults. For example, to confi --conf spark.sql.catalog.my_catal

Re: [PR] Use delimited column names in CreateChangelogViewProcedure [iceberg]

2025-03-17 Thread via GitHub
andyglow commented on PR #12418: URL: https://github.com/apache/iceberg/pull/12418#issuecomment-2730953448 I accidently removed the changes for the previous PR (Synked the repo), and had to create another one. @dramaticlly could we run the build/tests for this? -- This is an automa

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on PR #10233: URL: https://github.com/apache/iceberg/pull/10233#issuecomment-2730916409 My overall response is that we have too much configuration and abstraction for this. I feel like in HadoopFileIO we can just use reflection to check if the bulk methods exis

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999663393 ## core/src/main/java/org/apache/iceberg/hadoop/wrappedio/BindingUtils.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999657301 ## core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java: ## @@ -49,6 +62,11 @@ public class HadoopFileIO implements HadoopConfigurable, DelegateFileIO

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999644488 ## docs/docs/aws.md: ## @@ -669,6 +665,63 @@ Users can use catalog properties to override the defaults. For example, to confi --conf spark.sql.catalog.my_catal

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999643749 ## docs/docs/aws.md: ## @@ -669,6 +665,63 @@ Users can use catalog properties to override the defaults. For example, to confi --conf spark.sql.catalog.my_catal

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999607240 ## docs/docs/aws.md: ## @@ -669,6 +665,63 @@ Users can use catalog properties to override the defaults. For example, to confi --conf spark.sql.catalog.my_catal

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999613234 ## docs/docs/aws.md: ## @@ -669,6 +665,63 @@ Users can use catalog properties to override the defaults. For example, to confi --conf spark.sql.catalog.my_catal

Re: [PR] feat(puffin): Add PuffinWriter [iceberg-rust]

2025-03-17 Thread via GitHub
jonathanc-n commented on PR #959: URL: https://github.com/apache/iceberg-rust/pull/959#issuecomment-2730829750 @fqaiser94 Whats the current idea for this? I can offer help if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-03-17 Thread via GitHub
danielcweeks commented on code in PR #10233: URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999613234 ## docs/docs/aws.md: ## @@ -669,6 +665,63 @@ Users can use catalog properties to override the defaults. For example, to confi --conf spark.sql.catalog.my_catal

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r1999548823 ## pyiceberg/transforms.py: ## Review Comment: should we include ns support in pyiceberg_core transform as well? ## pyiceberg/types.py: ##

Re: [PR] AWS: Update the aws-bundle with latest dependencies [iceberg]

2025-03-17 Thread via GitHub
jackye1995 commented on code in PR #12553: URL: https://github.com/apache/iceberg/pull/12553#discussion_r1999408540 ## aws-bundle/NOTICE: ## @@ -44,6 +45,8 @@ NOTICE for Group: software.amazon.awssdk Name: sdk-core Version: 2.30.31 NOTICE for Group: software.amazon.awssdk N

[I] Iceberg Kafka Connect Sink cannot read table: java.lang.NumberFormatException: For input string: "60s" [iceberg]

2025-03-17 Thread via GitHub
lk-1984 opened a new issue, #12557: URL: https://github.com/apache/iceberg/issues/12557 ### Apache Iceberg version 1.8.1 (latest release) ### Query engine None ### Please describe the bug 🐞 I have 1.8.1 Iceberg Kafka Connect Sink, and 1.7.1 in Trino. When I

Re: [I] Applying Filter on Top-Level Struct Columns Throws Error [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on issue #1778: URL: https://github.com/apache/iceberg-python/issues/1778#issuecomment-2730507642 i think we can reproduce it by using [`test_all_types`](https://github.com/apache/iceberg-python/blob/1c0e2b04c383e5d90118ffce2066dcdb95193c4a/dev/provision.py#L219) in [

Re: [I] Kafka: runtime integration test failure or flaky [iceberg]

2025-03-17 Thread via GitHub
github-actions[bot] closed issue #11046: Kafka: runtime integration test failure or flaky URL: https://github.com/apache/iceberg/issues/11046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] feat(manifests): Consolidate V1/V2 manifest file objects [iceberg-go]

2025-03-17 Thread via GitHub
zeroshade merged PR #332: URL: https://github.com/apache/iceberg-go/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-03-17 Thread via GitHub
steveloughran commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2730432803 if you are really in a hurry to ship, use a 2.29.x SDK version.or at least include th -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] feat: nan_value_counts support [iceberg-rust]

2025-03-17 Thread via GitHub
feniljain commented on PR #907: URL: https://github.com/apache/iceberg-rust/pull/907#issuecomment-2730452436 Hadn't realized it got conflicts due to other PR merges, fixed them too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Support transforms with datetime timezones [iceberg-rust]

2025-03-17 Thread via GitHub
kevinjqliu commented on PR #1086: URL: https://github.com/apache/iceberg-rust/pull/1086#issuecomment-2730451740 interesting how i needed to merge main to run tests... never seen that before -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Core: PartitionsTable#partitions returns incomplete list in case of partition evolution and NULL partition values [iceberg]

2025-03-17 Thread via GitHub
deniskuzZ commented on code in PR #12528: URL: https://github.com/apache/iceberg/pull/12528#discussion_r1999259243 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -243,6 +245,102 @@ public void testPartitionSpecEvolutionToUnparti

Re: [I] Can we enable adaptive clustering? [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on issue #1790: URL: https://github.com/apache/iceberg-python/issues/1790#issuecomment-2730417785 Truncate transform with pyarrow was added in 0.9.0 https://github.com/apache/iceberg-python/commit/50c33aa0119d9e2478b3865d864ec23a7c45b1d7#diff-59b88b08481bfa5924034299

Re: [PR] Core: PartitionsTable#partitions returns incomplete list in case of partition evolution and NULL partition values [iceberg]

2025-03-17 Thread via GitHub
deniskuzZ commented on code in PR #12528: URL: https://github.com/apache/iceberg/pull/12528#discussion_r1999259243 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -243,6 +245,102 @@ public void testPartitionSpecEvolutionToUnparti

Re: [PR] handle decimal physicial type mapping [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on code in PR #1799: URL: https://github.com/apache/iceberg-python/pull/1799#discussion_r1999324401 ## tests/io/test_pyarrow_stats.py: ## @@ -72,7 +72,7 @@ StringType, ) from pyiceberg.utils.datetime import date_to_days, datetime_to_micros, time_to_m

Re: [I] Not able to create Pyiceberg table with Partition Spec using pyarrow schema [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on issue #1797: URL: https://github.com/apache/iceberg-python/issues/1797#issuecomment-2730395067 thats right, the `source_id` must match the field id. If you're just looking to add a partition field, check out the docs for partition evolution https://py.ice

Re: [I] Error reading table after appending pyarrow table [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on issue #1798: URL: https://github.com/apache/iceberg-python/issues/1798#issuecomment-2730392166 > I have iceberg table created by pyiceberg and appended some data in pyarrow table format can you provide the code you use to do this? -- This is an automated m

Re: [I] improve pyiceberg CLI [iceberg-python]

2025-03-17 Thread via GitHub
kevinjqliu commented on issue #1784: URL: https://github.com/apache/iceberg-python/issues/1784#issuecomment-2730368903 @iting0321 heres the current documentation for the CLI https://py.iceberg.apache.org/cli/ In general, the CLI requires a connection to the catalog. This can be done

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-03-17 Thread via GitHub
jackye1995 commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1999267746 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -275,6 +275,7 @@ private List deleteBatch(String bucket, Collection keysToDelete) Del

Re: [PR] feat(manifests): Consolidate V1/V2 manifest file objects [iceberg-go]

2025-03-17 Thread via GitHub
zeroshade commented on code in PR #332: URL: https://github.com/apache/iceberg-go/pull/332#discussion_r1997687200 ## manifest.go: ## @@ -593,42 +624,29 @@ func ReadManifestList(in io.Reader) ([]ManifestFile, error) { return nil, err } - var fallb

Re: [PR] Flink: Add support for Flink 2.0 [iceberg]

2025-03-17 Thread via GitHub
pvary commented on code in PR #12527: URL: https://github.com/apache/iceberg/pull/12527#discussion_r1999274861 ## gradle/libs.versions.toml: ## @@ -45,6 +45,7 @@ findbugs-jsr305 = "3.0.2" flink118 = { strictly = "1.18.1"} flink119 = { strictly = "1.19.1"} flink120 = { stric

[PR] feat(table): Add files to partitioned tables [iceberg-go]

2025-03-17 Thread via GitHub
zeroshade opened a new pull request, #338: URL: https://github.com/apache/iceberg-go/pull/338 Next step in successfully adding files, supporting adding files to partitioned tables and properly setting the partition data into the DataFile objects. -- This is an automated message from the

Re: [PR] Flink: Add support for Flink 2.0 [iceberg]

2025-03-17 Thread via GitHub
pvary commented on code in PR #12527: URL: https://github.com/apache/iceberg/pull/12527#discussion_r1999274247 ## gradle.properties: ## @@ -16,8 +16,8 @@ jmhOutputPath=build/reports/jmh/human-readable-output.txt jmhJsonOutputPath=build/reports/jmh/results.json jmhIncludeRegex

Re: [PR] OpenAPI: Handle NamespaceNotEmptyException when dropping a namespace [iceberg]

2025-03-17 Thread via GitHub
nastra commented on code in PR #12518: URL: https://github.com/apache/iceberg/pull/12518#discussion_r1999268591 ## open-api/rest-catalog-open-api.yaml: ## @@ -410,7 +410,17 @@ paths: 204: description: Success, no content 400: - $ref: '#/comp

Re: [PR] Flink: Add support for Flink 2.0 [iceberg]

2025-03-17 Thread via GitHub
pvary commented on code in PR #12527: URL: https://github.com/apache/iceberg/pull/12527#discussion_r1999266980 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java: ## @@ -138,6 +141,12 @@ class IcebergFilesCommitter extends AbstractStreamO

Re: [PR] Core: PartitionsTable#partitions returns incomplete list in case of partition evolution and NULL partition values [iceberg]

2025-03-17 Thread via GitHub
deniskuzZ commented on code in PR #12528: URL: https://github.com/apache/iceberg/pull/12528#discussion_r1999259243 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -243,6 +245,102 @@ public void testPartitionSpecEvolutionToUnparti

Re: [PR] Core: PartitionsTable#partitions returns incomplete list in case of partition evolution and NULL partition values [iceberg]

2025-03-17 Thread via GitHub
deniskuzZ commented on code in PR #12528: URL: https://github.com/apache/iceberg/pull/12528#discussion_r1999234522 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -243,6 +245,102 @@ public void testPartitionSpecEvolutionToUnparti

Re: [PR] Core: PartitionsTable#partitions returns incomplete list in case of partition evolution and NULL partition values [iceberg]

2025-03-17 Thread via GitHub
deniskuzZ commented on code in PR #12528: URL: https://github.com/apache/iceberg/pull/12528#discussion_r1999234522 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -243,6 +245,102 @@ public void testPartitionSpecEvolutionToUnparti

[PR] fix(views): make timestamp take &self & fix set_current_version_id [iceberg-rust]

2025-03-17 Thread via GitHub
twuebi opened a new pull request, #1101: URL: https://github.com/apache/iceberg-rust/pull/1101 ## Which issue does this PR close? - Closes #1099 - Closes #1100 ## What changes are included in this PR? 1. fixes set current view version 2. makes ViewVersionLog

[I] ViewVersionLog::timestamp consumes self [iceberg-rust]

2025-03-17 Thread via GitHub
twuebi opened a new issue, #1100: URL: https://github.com/apache/iceberg-rust/issues/1100 currently the function takes `self`: `pub fn timestamp(self)`, it should become `pub fn timestamp(&self)` since this is simply a getter of a `Copy` field. -- This is an automated message from the Ap

[I] ViewMetadataBuilder set current view version fails on -1 [iceberg-rust]

2025-03-17 Thread via GitHub
twuebi opened a new issue, #1099: URL: https://github.com/apache/iceberg-rust/issues/1099 ### Apache Iceberg Rust version None ### Describe the bug ``` if version_id == Self::LAST_ADDED && self.last_added_version_id.is_none() { version_id = self.last_added_version

[PR] handle decimal physicial type mapping [iceberg-python]

2025-03-17 Thread via GitHub
redpheonixx opened a new pull request, #1799: URL: https://github.com/apache/iceberg-python/pull/1799 This pull request addresses the handling of decimal physical type matching in Parquet. It implements rules such that: For precision ≤ 9, values are stored as `int32`. For precision ≤ 1

Re: [PR] WIP: Interface based DataFile reader and writer API [iceberg]

2025-03-17 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r1999135766 ## core/src/main/java/org/apache/iceberg/io/datafile/AppenderBuilder.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [I] Missing size rewrite in rewrite_table_path for delete file [iceberg]

2025-03-17 Thread via GitHub
jotarada commented on issue #12554: URL: https://github.com/apache/iceberg/issues/12554#issuecomment-2730102231 @szehon-ho Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] Missing size rewrite in rewrite_table_path for delete file [iceberg]

2025-03-17 Thread via GitHub
jotarada opened a new issue, #12554: URL: https://github.com/apache/iceberg/issues/12554 ### Apache Iceberg version 1.8.1 (latest release) ### Query engine None ### Please describe the bug 🐞 I think this a bug produced by [11555](https://github.com/apache/i

Re: [PR] Core: PartitionsTable#partitions returns incomplete list in case of partition evolution and NULL partition values [iceberg]

2025-03-17 Thread via GitHub
RussellSpitzer commented on PR #12528: URL: https://github.com/apache/iceberg/pull/12528#issuecomment-2730063569 @szehon-ho Adding you since you were in this code most recently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Parquet: Implement Variant metrics [iceberg]

2025-03-17 Thread via GitHub
aihuaxu commented on code in PR #12496: URL: https://github.com/apache/iceberg/pull/12496#discussion_r1999085447 ## .palantir/revapi.yml: ## @@ -1172,6 +1172,11 @@ acceptedBreaks: \ java.util.function.Consumer)" justification: "Removing deprecated code" Review C

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.106.1 to 1.107.0 in the gomod_updates group across 1 directory [iceberg-go]

2025-03-17 Thread via GitHub
zeroshade merged PR #337: URL: https://github.com/apache/iceberg-go/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

  1   2   >