SanjayMarreddi commented on code in PR #12553: URL: https://github.com/apache/iceberg/pull/12553#discussion_r1999793485
########## aws-bundle/NOTICE: ########## @@ -44,6 +45,8 @@ NOTICE for Group: software.amazon.awssdk Name: sdk-core Version: 2.30.31 NOTICE for Group: software.amazon.awssdk Name: sso Version: 2.30.31 NOTICE for Group: software.amazon.awssdk Name: sts Version: 2.30.31 NOTICE for Group: software.amazon.awssdk Name: utils Version: 2.30.31 +NOTICE for Group: software.amazon.s3.accessgrants Name: aws-s3-accessgrants-java-plugin Version: 2.3.0 +NOTICE for Group: software.amazon.s3.analyticsaccelerator Name: analyticsaccelerator-s3 Version: 1.0.0 Review Comment: Actually it is already present: https://github.com/apache/iceberg/blob/main/aws-bundle/NOTICE#L20 ########## aws-bundle/build.gradle: ########## @@ -36,6 +38,9 @@ project(":iceberg-aws-bundle") { implementation "software.amazon.awssdk:sts" implementation "software.amazon.awssdk:dynamodb" implementation "software.amazon.awssdk:lakeformation" + implementation "software.amazon.awssdk:url-connection-client" Review Comment: Sure, I'm happy to remove it - I have added because it's present [here](https://github.com/apache/iceberg/blob/main/build.gradle#L462): Should we consider removing there too? ########## aws-bundle/LICENSE: ########## @@ -443,6 +443,12 @@ License: Apache License, Version 2.0 - https://aws.amazon.com/apache2.0 -------------------------------------------------------------------------------- +Group: software.amazon.awssdk Name: url-connection-client Version: 2.30.31 +Project URL: https://aws.amazon.com/sdkforjava +License: Apache License, Version 2.0 - https://aws.amazon.com/apache2.0 + +-------------------------------------------------------------------------------- Review Comment: Actually, it is already present: https://github.com/apache/iceberg/blob/main/aws-bundle/LICENSE#L358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
