rdblue commented on code in PR #12496:
URL: https://github.com/apache/iceberg/pull/12496#discussion_r1999838308
##########
data/src/test/java/org/apache/iceberg/TestMergingMetrics.java:
##########
@@ -91,8 +87,7 @@ public abstract class TestMergingMetrics<T> {
optional(27, "timestamp", Types.TimestampType.withZone())));
private static final Map<Types.NestedField, Integer>
FIELDS_WITH_NAN_COUNT_TO_ID =
- ImmutableMap.of(
- FLOAT_FIELD, 3, DOUBLE_FIELD, 4, FLOAT_LIST, 10, MAP_FIELD_1, 18,
MAP_FIELD_2, 22);
+ ImmutableMap.of(FLOAT_FIELD, 3, DOUBLE_FIELD, 4);
Review Comment:
Like ORC, Parquet will no longer produce metrics for repeated fields, like
those in map keys or values or in list elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
