Re: [I] Hive 4.0.0 can't read Iceberg table while inserting data works fine [iceberg]

2024-06-15 Thread via GitHub
pvary commented on issue #10506: URL: https://github.com/apache/iceberg/issues/10506#issuecomment-2171107875 I would ask this question on the Hive users list, and the if appropriate, I would file a Hive jira. The folks there would know, if this is the way how you should use Hive 4.0.0. --

Re: [PR] Deprecate ContentCache.invalidateAll [iceberg]

2024-06-15 Thread via GitHub
jbonofre commented on code in PR #10494: URL: https://github.com/apache/iceberg/pull/10494#discussion_r1641622578 ## core/src/main/java/org/apache/iceberg/io/ContentCache.java: ## @@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) { return input; } + /**

Re: [PR] API: add resultSchema() method to StructTransform [iceberg]

2024-06-15 Thread via GitHub
jbonofre commented on PR #10496: URL: https://github.com/apache/iceberg/pull/10496#issuecomment-2171068998 @stevenzwu do we have a corresponding issue for this PR ? Your PR looks like a good idea to me. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-06-15 Thread via GitHub
jbonofre commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1641622324 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -466,6 +466,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [PR] Remove deprecated APIs scheduled for removal in 1.6.0 [iceberg]

2024-06-15 Thread via GitHub
jbonofre commented on PR #10501: URL: https://github.com/apache/iceberg/pull/10501#issuecomment-2171066896 @findepi you should set Iceberg 1.6.0 as milestone for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Build: Bump datamodel-code-generator from 0.25.6 to 0.25.7 [iceberg]

2024-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #10507: URL: https://github.com/apache/iceberg/pull/10507 Bumps [datamodel-code-generator](https://github.com/koxudaxi/datamodel-code-generator) from 0.25.6 to 0.25.7. Release notes Sourced from https://github.com/koxudaxi/datamodel-code-

[I] Hive 4.0.0 can't read Iceberg table while inserting data is fine [iceberg]

2024-06-15 Thread via GitHub
nadialeiden opened a new issue, #10506: URL: https://github.com/apache/iceberg/issues/10506 ### Query engine Hive 4.0.0 ### Question **Versions** Hive 4.0.0 Hadoop 3.4.1 **Problem** Hello, I have just encountered a problem regarding to Hive and Ice

[PR] Build: Bump software.amazon.awssdk:bom from 2.25.69 to 2.26.3 [iceberg]

2024-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #10505: URL: https://github.com/apache/iceberg/pull/10505 Bumps software.amazon.awssdk:bom from 2.25.69 to 2.26.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softw

[PR] Build: Bump io.netty:netty-buffer from 4.1.110.Final to 4.1.111.Final [iceberg]

2024-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #10504: URL: https://github.com/apache/iceberg/pull/10504 Bumps [io.netty:netty-buffer](https://github.com/netty/netty) from 4.1.110.Final to 4.1.111.Final. Commits https://github.com/netty/netty/commit/90c5fd78c12ffe4698795e44fc6d865d

[PR] Build: Bump org.springframework:spring-web from 5.3.36 to 5.3.37 [iceberg]

2024-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #10503: URL: https://github.com/apache/iceberg/pull/10503 Bumps [org.springframework:spring-web](https://github.com/spring-projects/spring-framework) from 5.3.36 to 5.3.37. Release notes Sourced from https://github.com/spring-projects/spr

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.40.0 [iceberg]

2024-06-15 Thread via GitHub
dependabot[bot] closed pull request #10417: Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.40.0 URL: https://github.com/apache/iceberg/pull/10417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.40.0 [iceberg]

2024-06-15 Thread via GitHub
dependabot[bot] commented on PR #10417: URL: https://github.com/apache/iceberg/pull/10417#issuecomment-2171039799 Superseded by #10502. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.41.0 [iceberg]

2024-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #10502: URL: https://github.com/apache/iceberg/pull/10502 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.28.0 to 26.41.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bo

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-06-15 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1641606523 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [I] to_pandas() API which converts iceberg table scan to a pd.DataFrame will lost datetime data type and row order [iceberg-python]

2024-06-15 Thread via GitHub
github-actions[bot] commented on issue #132: URL: https://github.com/apache/iceberg-python/issues/132#issuecomment-2170984831 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apac

Re: [I] to_pandas() API which converts iceberg table scan to a pd.DataFrame will lost datetime data type and row order [iceberg-python]

2024-06-15 Thread via GitHub
github-actions[bot] closed issue #132: to_pandas() API which converts iceberg table scan to a pd.DataFrame will lost datetime data type and row order URL: https://github.com/apache/iceberg-python/issues/132 -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] Support for low latency writes to iceberg table [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] closed issue #2723: Support for low latency writes to iceberg table URL: https://github.com/apache/iceberg/issues/2723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] Support for low latency writes to iceberg table [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] commented on issue #2723: URL: https://github.com/apache/iceberg/issues/2723#issuecomment-2170984119 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Remove site docs from showing up in IntelliJ search and causing very long index times in IntelliJ [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] commented on issue #2718: URL: https://github.com/apache/iceberg/issues/2718#issuecomment-2170984113 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Remove site docs from showing up in IntelliJ search and causing very long index times in IntelliJ [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] closed issue #2718: Remove site docs from showing up in IntelliJ search and causing very long index times in IntelliJ URL: https://github.com/apache/iceberg/issues/2718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Hive documentation not updated on website [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] closed issue #2715: Hive documentation not updated on website URL: https://github.com/apache/iceberg/issues/2715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] Hive documentation not updated on website [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] commented on issue #2715: URL: https://github.com/apache/iceberg/issues/2715#issuecomment-2170984109 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Can't seem to read from glue iceberg table in EMR Hive [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] closed issue #2696: Can't seem to read from glue iceberg table in EMR Hive URL: https://github.com/apache/iceberg/issues/2696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Can't seem to read from glue iceberg table in EMR Hive [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] commented on issue #2696: URL: https://github.com/apache/iceberg/issues/2696#issuecomment-2170984103 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] [Incremental Scan] [Spark] Support overwrite snapshots too [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] closed issue #2690: [Incremental Scan] [Spark] Support overwrite snapshots too URL: https://github.com/apache/iceberg/issues/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Incremental Scan] [Spark] Support overwrite snapshots too [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] commented on issue #2690: URL: https://github.com/apache/iceberg/issues/2690#issuecomment-2170984096 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Does spark integrated iceberg support concurrent insert overwrite [iceberg]

2024-06-15 Thread via GitHub
github-actions[bot] commented on issue #2633: URL: https://github.com/apache/iceberg/issues/2633#issuecomment-2170984083 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] `parquet_path_to_id_mapping` generates incorrect path for List types [iceberg-python]

2024-06-15 Thread via GitHub
syun64 commented on issue #716: URL: https://github.com/apache/iceberg-python/issues/716#issuecomment-2170966077 Hi @cgbur and @felixscherz thank you for raising this and taking this investigation further. I'm not a polars user myself, but the difference in the behavior is quite interesting

Re: [I] Add view support to the Rest Catalog [iceberg-python]

2024-06-15 Thread via GitHub
syun64 commented on issue #818: URL: https://github.com/apache/iceberg-python/issues/818#issuecomment-2170955774 Thank you for raising this @ndrluis 💯 I will add this as a 0.8.0 milestone for now -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] Support get partition table with filter [iceberg-python]

2024-06-15 Thread via GitHub
syun64 closed issue #24: Support get partition table with filter URL: https://github.com/apache/iceberg-python/issues/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [I] Support get partition table with filter [iceberg-python]

2024-06-15 Thread via GitHub
syun64 commented on issue #24: URL: https://github.com/apache/iceberg-python/issues/24#issuecomment-2170955372 Partitions table was added in: https://github.com/apache/iceberg-python/pull/603 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Fix ancestors_of exception for tables with >=2000 snapshots [iceberg-python]

2024-06-15 Thread via GitHub
syun64 commented on PR #821: URL: https://github.com/apache/iceberg-python/pull/821#issuecomment-2170950407 Hi @ndrluis - thank you for raising this. This looks like an issue we'd definitely want to fix. Just to help with reviewing this PR, and for future records, would you be able t

Re: [PR] Support snapshot management operations like creating tags by adding `ManageSnapshots` API [iceberg-python]

2024-06-15 Thread via GitHub
syun64 commented on PR #728: URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2170945908 This is awesome! @chinmay-bhat You are on a roll with these PRs right now, thank you for contributing these much needed features to PyIceberg! Looking forward to releasing these with

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-06-15 Thread via GitHub
findepi commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1641426650 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -466,6 +466,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2024-06-15 Thread via GitHub
findepi commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-2170594846 follow-up to complete removal of AssertHelpers -- https://github.com/apache/iceberg/pull/10500 > I don't think we want to spend time migrating those agreed! fortunately

Re: [PR] API: Deprecate AssertHelpers [iceberg]

2024-06-15 Thread via GitHub
findepi commented on PR #6977: URL: https://github.com/apache/iceberg/pull/6977#issuecomment-2170594054 follow-up to complete removal of AssertHelpers -- https://github.com/apache/iceberg/pull/10500 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Remove all usages of deprecated AssertHelpers [iceberg]

2024-06-15 Thread via GitHub
findepi commented on PR #10500: URL: https://github.com/apache/iceberg/pull/10500#issuecomment-2170593672 [flink-scala-2-12-tests (8, 1.17)](https://github.com/apache/iceberg/actions/runs/9528246393/job/26265724393#logs) looks like a flake. on a subsequent run [flink-scala-2-12-tests (8, 1

Re: [PR] Build: Bump org.scala-lang.modules:scala-collection-compat_2.13 from 2.11.0 to 2.12.0 [iceberg]

2024-06-15 Thread via GitHub
Fokko merged PR #10195: URL: https://github.com/apache/iceberg/pull/10195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Bump net.snowflake:snowflake-jdbc from 3.16.0 to 3.16.1 [iceberg]

2024-06-15 Thread via GitHub
Fokko merged PR #10419: URL: https://github.com/apache/iceberg/pull/10419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-06-15 Thread via GitHub
amogh-jahagirdar commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1641406745 ## open-api/rest-catalog-open-api.yaml: ## @@ -2106,6 +2210,32 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFil

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-06-15 Thread via GitHub
danielcweeks commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1641334986 ## open-api/rest-catalog-open-api.yaml: ## @@ -3789,6 +4003,21 @@ components: EmptyResponse: $ref: '#/components/examples/ListNamespace

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-06-15 Thread via GitHub
danielcweeks commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1641334089 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +2988,69 @@ components: additionalProperties: type: string +PreplanTableRequest

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-06-15 Thread via GitHub
danielcweeks commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1641333965 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +2988,69 @@ components: additionalProperties: type: string +PreplanTableRequest

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-06-15 Thread via GitHub
danielcweeks commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1641333565 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +2988,69 @@ components: additionalProperties: type: string +PreplanTableRequest

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-06-15 Thread via GitHub
danielcweeks commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1641328271 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +2988,69 @@ components: additionalProperties: type: string +PreplanTableRequest

Re: [PR] Parquet: Make row-group filters cooperate to filter [iceberg]

2024-06-15 Thread via GitHub
amogh-jahagirdar commented on code in PR #10090: URL: https://github.com/apache/iceberg/pull/10090#discussion_r1640408646 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java: ## @@ -116,48 +122,48 @@ private boolean eval( } }

Re: [PR] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
ZENOTME commented on code in PR #401: URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1641288830 ## crates/iceberg/src/spec/values.rs: ## @@ -50,7 +51,7 @@ use super::datatypes::{PrimitiveType, Type}; const MAX_TIME_VALUE: i64 = 24 * 60 * 60 * 1_000_000i64 - 1;

Re: [PR] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
ZENOTME commented on code in PR #401: URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1641281871 ## crates/iceberg/src/arrow/reader.rs: ## Review Comment: +1. We can expose an interface in the table to get a builder. -- This is an automated message from

Re: [PR] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
ZENOTME commented on code in PR #401: URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1641279780 ## crates/iceberg/src/arrow/reader.rs: ## @@ -74,38 +70,22 @@ impl ArrowReaderBuilder { self } -/// Sets the desired column projection with a lis

Re: [PR] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
ZENOTME commented on code in PR #401: URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1641278744 ## crates/iceberg/src/expr/predicate.rs: ## @@ -879,12 +905,19 @@ mod tests { ) } +fn test_bound_predicate_serialize_diserialize(bound_predicate:

Re: [PR] Support snapshot management operations like creating tags by adding `ManageSnapshots` API [iceberg-python]

2024-06-15 Thread via GitHub
chinmay-bhat commented on PR #728: URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2170122431 Thanks @HonahX @Fokko @syun64 for the discussions and reviews! 🫡 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] Support creating tags [iceberg-python]

2024-06-15 Thread via GitHub
HonahX closed issue #573: Support creating tags URL: https://github.com/apache/iceberg-python/issues/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] Support snapshot management operations like creating tags by adding `ManageSnapshots` API [iceberg-python]

2024-06-15 Thread via GitHub
HonahX commented on PR #728: URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2170106747 Merged! Thanks @chinmay-bhat for the great work. Thanks @Fokko @syun64 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Support snapshot management operations like creating tags by adding `ManageSnapshots` API [iceberg-python]

2024-06-15 Thread via GitHub
HonahX merged PR #728: URL: https://github.com/apache/iceberg-python/pull/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Remove all usages of deprecated AssertHelpers [iceberg]

2024-06-15 Thread via GitHub
findepi commented on code in PR #10500: URL: https://github.com/apache/iceberg/pull/10500#discussion_r1641257105 ## spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -688,23 +688,23 @@ public void invalidDataImport()

Re: [PR] Remove all usages of deprecated AssertHelpers [iceberg]

2024-06-15 Thread via GitHub
nastra commented on code in PR #10500: URL: https://github.com/apache/iceberg/pull/10500#discussion_r1641210236 ## spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -688,23 +688,23 @@ public void invalidDataImport() {

Re: [PR] Support snapshot management operations like creating tags by adding `ManageSnapshots` API [iceberg-python]

2024-06-15 Thread via GitHub
chinmay-bhat commented on PR #728: URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2169622681 @Fokko @HonahX Can we merge this in? Other draft PRs depend on this one 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Rename allVersions to allModules [iceberg]

2024-06-15 Thread via GitHub
findepi commented on PR #10499: URL: https://github.com/apache/iceberg/pull/10499#issuecomment-2169528217 thanks for the merge, @nastra ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Rename allVersions to allModules [iceberg]

2024-06-15 Thread via GitHub
nastra merged PR #10499: URL: https://github.com/apache/iceberg/pull/10499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Tests: Remove deprecated and unused test helper [iceberg]

2024-06-15 Thread via GitHub
findepi closed pull request #10500: Tests: Remove deprecated and unused test helper URL: https://github.com/apache/iceberg/pull/10500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Tests: Remove deprecated and unused test helper [iceberg]

2024-06-15 Thread via GitHub
findepi commented on PR #10500: URL: https://github.com/apache/iceberg/pull/10500#issuecomment-2169422404 you're right, just intellij didn't see them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Rename allVersions to allModules [iceberg]

2024-06-15 Thread via GitHub
findepi commented on PR #10499: URL: https://github.com/apache/iceberg/pull/10499#issuecomment-2169395232 cc @pan3793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Use all known Scala versions when -DallVersions set [iceberg]

2024-06-15 Thread via GitHub
findepi commented on code in PR #10478: URL: https://github.com/apache/iceberg/pull/10478#discussion_r1641090102 ## settings.gradle: ## @@ -72,6 +72,7 @@ project(':open-api').name = 'iceberg-open-api' if (null != System.getProperty("allVersions")) { System.setProperty("fli

Re: [PR] Use all known Scala versions when -DallVersions set [iceberg]

2024-06-15 Thread via GitHub
findepi closed pull request #10478: Use all known Scala versions when -DallVersions set URL: https://github.com/apache/iceberg/pull/10478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Use all known Scala versions when -DallVersions set [iceberg]

2024-06-15 Thread via GitHub
findepi commented on code in PR #10478: URL: https://github.com/apache/iceberg/pull/10478#discussion_r1641082384 ## settings.gradle: ## @@ -72,6 +72,7 @@ project(':open-api').name = 'iceberg-open-api' if (null != System.getProperty("allVersions")) { System.setProperty("fli

Re: [PR] Support building with Java 21 [iceberg]

2024-06-15 Thread via GitHub
findepi commented on code in PR #10474: URL: https://github.com/apache/iceberg/pull/10474#discussion_r1641073768 ## baseline.gradle: ## @@ -60,8 +63,7 @@ subprojects { spotless { java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/jmh/j

Re: [I] Support more complex types when reading into arrow record batch. [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #405: URL: https://github.com/apache/iceberg-rust/issues/405#issuecomment-2169283940 > I'm happy to start looking into this one if you like? Thanks @sdd ! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Support more complex types when reading into arrow record batch. [iceberg-rust]

2024-06-15 Thread via GitHub
sdd commented on issue #405: URL: https://github.com/apache/iceberg-rust/issues/405#issuecomment-2169282092 I'm happy to start looking into this one if you like? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Use all known Scala versions when -DallVersions set [iceberg]

2024-06-15 Thread via GitHub
nastra commented on code in PR #10478: URL: https://github.com/apache/iceberg/pull/10478#discussion_r1640997638 ## settings.gradle: ## @@ -72,6 +72,7 @@ project(':open-api').name = 'iceberg-open-api' if (null != System.getProperty("allVersions")) { System.setProperty("flin

Re: [PR] Support building with Java 21 [iceberg]

2024-06-15 Thread via GitHub
nastra commented on code in PR #10474: URL: https://github.com/apache/iceberg/pull/10474#discussion_r1640996276 ## baseline.gradle: ## @@ -60,8 +63,7 @@ subprojects { spotless { java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/jmh/ja

Re: [I] Read Parquet data file with projection [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #244: URL: https://github.com/apache/iceberg-rust/issues/244#issuecomment-2169270213 Close by #245 . Follow up issued tracked in #405 to make things more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] Read Parquet data file with projection [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 closed issue #244: Read Parquet data file with projection URL: https://github.com/apache/iceberg-rust/issues/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] refactor: Rename `ManifestListEntry`, `ManifestEntry` to make them more similar to java/python implementation. [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #145: URL: https://github.com/apache/iceberg-rust/issues/145#issuecomment-2169253182 Close by #204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Tracking: Support row filter in table scan. [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 closed issue #153: Tracking: Support row filter in table scan. URL: https://github.com/apache/iceberg-rust/issues/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] refactor: Rename `ManifestListEntry`, `ManifestEntry` to make them more similar to java/python implementation. [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 closed issue #145: refactor: Rename `ManifestListEntry`, `ManifestEntry` to make them more similar to java/python implementation. URL: https://github.com/apache/iceberg-rust/issues/145 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Enable reading to arrow record batch stream. [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #125: URL: https://github.com/apache/iceberg-rust/issues/125#issuecomment-2169252223 Close by #207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Enable reading to arrow record batch stream. [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 closed issue #125: Enable reading to arrow record batch stream. URL: https://github.com/apache/iceberg-rust/issues/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add missing arrow predicate pushdown implementations for `StartsWith`, `NotStartsWith`, `In`, and `NotIn` [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 merged PR #404: URL: https://github.com/apache/iceberg-rust/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on code in PR #401: URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1640919368 ## Cargo.toml: ## @@ -65,8 +65,8 @@ log = "^0.4" mockito = "^1" murmur3 = "0.5.2" once_cell = "1" -opendal = "0.46" -ordered-float = "4.0.0" +opendal = { ve

Re: [PR] Add missing arrow predicate pushdown implementations for `StartsWith`, `NotStartsWith`, `In`, and `NotIn` [iceberg-rust]

2024-06-15 Thread via GitHub
sdd commented on code in PR #404: URL: https://github.com/apache/iceberg-rust/pull/404#discussion_r1640927249 ## crates/iceberg/src/arrow/reader.rs: ## @@ -741,42 +742,98 @@ impl<'a> BoundPredicateVisitor for PredicateConverter<'a> { fn starts_with( &mut self, -

Re: [PR] Add missing arrow predicate pushdown implementations for `StartsWith`, `NotStartsWith`, `In`, and `NotIn` [iceberg-rust]

2024-06-15 Thread via GitHub
sdd commented on code in PR #404: URL: https://github.com/apache/iceberg-rust/pull/404#discussion_r1640925156 ## crates/iceberg/src/arrow/reader.rs: ## @@ -741,42 +742,98 @@ impl<'a> BoundPredicateVisitor for PredicateConverter<'a> { fn starts_with( &mut self, -

Re: [I] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
ZENOTME commented on issue #398: URL: https://github.com/apache/iceberg-rust/issues/398#issuecomment-2169216557 > > > Sorry, I don't quite get what's the meta here? > > > > > > e.g. field_id, predicate. The info that can be shared by the set of FileScanTasks. Maybe "metadata" is n

Re: [I] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #398: URL: https://github.com/apache/iceberg-rust/issues/398#issuecomment-2169210628 > > Sorry, I don't quite get what's the meta here? > > e.g. field_id, predicate. The info that can be shared by the set of FileScanTasks. Maybe "metadata" is not preci

Re: [I] Correct names in the ManifestList [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #354: URL: https://github.com/apache/iceberg-rust/issues/354#issuecomment-2169200194 Close by #380 Thanks @gupteaj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Correct names in the ManifestList [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 closed issue #354: Correct names in the ManifestList URL: https://github.com/apache/iceberg-rust/issues/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] Enhancement: Add support for a config file in iceberg-rust [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #375: URL: https://github.com/apache/iceberg-rust/issues/375#issuecomment-2169199161 I think to fix #374, we should decouple two things: 1. Add a setting in metadata reader/writer to deal with current-snapshot-id 2. How to enable the setting, either

Re: [I] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
ZENOTME commented on issue #398: URL: https://github.com/apache/iceberg-rust/issues/398#issuecomment-2169198820 > Sorry, I don't quite get what's the meta here? e.g. field_id, predicate. The info that can be shared by the set of FileScanTasks. Maybe "metadata" is not precise here. -

Re: [I] Enhancement: refine the reader interface [iceberg-rust]

2024-06-15 Thread via GitHub
liurenjie1024 commented on issue #398: URL: https://github.com/apache/iceberg-rust/issues/398#issuecomment-2169196583 Sorry, I don't quite get what's the meta here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U