findepi commented on code in PR #10478:
URL: https://github.com/apache/iceberg/pull/10478#discussion_r1641082384


##########
settings.gradle:
##########
@@ -72,6 +72,7 @@ project(':open-api').name = 'iceberg-open-api'
 
 if (null != System.getProperty("allVersions")) {
   System.setProperty("flinkVersions", System.getProperty("knownFlinkVersions"))
+  System.setProperty("scalaVersions", System.getProperty("knownScalaVersions"))

Review Comment:
   For example to check the code compiles correctly, but i understand now this 
may not be needed and that scala version config is more for CI that for 
building.
   Thanks, will rename to allModules!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to