ZENOTME commented on code in PR #401:
URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1641279780
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -74,38 +70,22 @@ impl ArrowReaderBuilder {
self
}
- /// Sets the desired column projection with a list of field ids.
- pub fn with_field_ids(mut self, field_ids: impl IntoIterator<Item =
usize>) -> Self {
- self.field_ids = field_ids.into_iter().collect();
- self
- }
-
- /// Sets the predicates to apply to the scan.
- pub fn with_predicates(mut self, predicates: BoundPredicate) -> Self {
- self.predicates = Some(predicates);
- self
- }
-
/// Build the ArrowReader.
pub fn build(self) -> ArrowReader {
ArrowReader {
batch_size: self.batch_size,
- field_ids: self.field_ids,
- schema: self.schema,
file_io: self.file_io,
- predicates: self.predicates,
+ metadata: self.table_metadata,
}
}
}
/// Reads data from Parquet files
+#[derive(Clone)]
pub struct ArrowReader {
batch_size: Option<usize>,
- field_ids: Vec<usize>,
- #[allow(dead_code)]
- schema: SchemaRef,
file_io: FileIO,
- predicates: Option<BoundPredicate>,
+ metadata: TableMetadataRef,
Review Comment:
The file scan task will store a schema id so we need this to get the schema.
We can't know which schema needs until we get a file scan task.🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
