clintf1982 commented on issue #9562:
URL: https://github.com/apache/iceberg/issues/9562#issuecomment-2053922595
@ajantha-bhat Thanks a lot:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Fokko commented on PR #10095:
URL: https://github.com/apache/iceberg/pull/10095#issuecomment-2053908709
Moving this forward, thanks @sfc-gh-dhuo for letting us know 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Fokko merged PR #10095:
URL: https://github.com/apache/iceberg/pull/10095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
jbonofre commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1564467550
##
.github/workflows/stale.yml:
##
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any
dependabot[bot] opened a new pull request, #10139:
URL: https://github.com/apache/iceberg/pull/10139
Bumps
[org.springframework:spring-web](https://github.com/spring-projects/spring-framework)
from 5.3.33 to 5.3.34.
Release notes
Sourced from https://github.com/spring-projects/spr
dependabot[bot] commented on PR #10093:
URL: https://github.com/apache/iceberg/pull/10093#issuecomment-2053905136
Superseded by #10138.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dependabot[bot] closed pull request #10093: Build: Bump
software.amazon.awssdk:bom from 2.25.21 to 2.25.26
URL: https://github.com/apache/iceberg/pull/10093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dependabot[bot] opened a new pull request, #10138:
URL: https://github.com/apache/iceberg/pull/10138
Bumps software.amazon.awssdk:bom from 2.25.21 to 2.25.31.
[ -> No
deleted
amogh-jahagirdar commented on code in PR #10133:
URL: https://github.com/apache/iceberg/pull/10133#discussion_r1564304976
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSchemaUtil.java:
##
@@ -59,9 +59,7 @@ private SparkSchemaUtil() {}
* @return a Schema for
amogh-jahagirdar opened a new pull request, #10137:
URL: https://github.com/apache/iceberg/pull/10137
Small refactoring of SparkSchemaUtil#schemaForTable, I noticed when doing
#10133 we can just use the existing convert method
--
This is an automated message from the Apache Git Service.
amogh-jahagirdar commented on code in PR #10133:
URL: https://github.com/apache/iceberg/pull/10133#discussion_r1564299266
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSchemaUtil.java:
##
@@ -59,9 +59,7 @@ private SparkSchemaUtil() {}
* @return a Schema for
amogh-jahagirdar commented on code in PR #10133:
URL: https://github.com/apache/iceberg/pull/10133#discussion_r1564298758
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##
@@ -948,6 +948,28 @@ public void testAddFiles
amogh-jahagirdar commented on code in PR #602:
URL: https://github.com/apache/iceberg-python/pull/602#discussion_r1564265956
##
tests/integration/test_inspect_table.py:
##
@@ -266,3 +266,56 @@ def test_inspect_entries_partitioned(spark: SparkSession,
session_catalog: Catal
Fokko commented on code in PR #590:
URL: https://github.com/apache/iceberg-python/pull/590#discussion_r1564246026
##
pyiceberg/io/pyarrow.py:
##
@@ -1780,16 +1781,17 @@ def write_file(io: FileIO, table_metadata:
TableMetadata, tasks: Iterator[WriteT
)
def write_parq
Fokko commented on code in PR #590:
URL: https://github.com/apache/iceberg-python/pull/590#discussion_r1564241452
##
pyiceberg/io/pyarrow.py:
##
@@ -1780,16 +1781,17 @@ def write_file(io: FileIO, table_metadata:
TableMetadata, tasks: Iterator[WriteT
)
def write_parq
syun64 commented on code in PR #603:
URL: https://github.com/apache/iceberg-python/pull/603#discussion_r1564235822
##
pyiceberg/table/__init__.py:
##
@@ -3410,6 +3411,94 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
schema=entries_sch
Fokko commented on code in PR #602:
URL: https://github.com/apache/iceberg-python/pull/602#discussion_r1564223181
##
pyiceberg/table/__init__.py:
##
@@ -3410,6 +3410,32 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
schema=entries_sche
kevinjqliu commented on issue #604:
URL: https://github.com/apache/iceberg-python/issues/604#issuecomment-2053743307
Some potential optimizations:
* parallelize `pytest` execution, this requires that each test can be
independently run
* un-paratermized some tests, I noticed that tests
Fokko commented on code in PR #603:
URL: https://github.com/apache/iceberg-python/pull/603#discussion_r1564221753
##
pyiceberg/table/__init__.py:
##
@@ -3410,6 +3411,94 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
schema=entries_sche
kevinjqliu commented on code in PR #590:
URL: https://github.com/apache/iceberg-python/pull/590#discussion_r1564221724
##
pyiceberg/io/pyarrow.py:
##
@@ -1122,12 +1121,12 @@ def project_table(
return result
-def to_requested_schema(requested_schema: Schema, file_schema:
syun64 commented on issue #600:
URL: https://github.com/apache/iceberg-python/issues/600#issuecomment-2053740059
I think this is a great discussion item @kevinjqliu - thank you for raising
this.
I'm a bit torn between whether we (PyIceberg) should be responsible for
creating separat
syun64 commented on code in PR #603:
URL: https://github.com/apache/iceberg-python/pull/603#discussion_r1564204302
##
pyiceberg/table/__init__.py:
##
@@ -3410,6 +3411,94 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
schema=entries_sch
syun64 commented on code in PR #603:
URL: https://github.com/apache/iceberg-python/pull/603#discussion_r1564204302
##
pyiceberg/table/__init__.py:
##
@@ -3410,6 +3411,94 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
schema=entries_sch
Fokko merged PR #599:
URL: https://github.com/apache/iceberg-python/pull/599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #590:
URL: https://github.com/apache/iceberg-python/pull/590#discussion_r1564194393
##
tests/integration/test_inspect_table.py:
##
@@ -186,8 +185,6 @@ def test_inspect_entries(
assert df_lhs == df_rhs, f"Difference in data_fil
Fokko commented on code in PR #590:
URL: https://github.com/apache/iceberg-python/pull/590#discussion_r1564193928
##
pyiceberg/io/pyarrow.py:
##
@@ -1122,12 +1121,12 @@ def project_table(
return result
-def to_requested_schema(requested_schema: Schema, file_schema: Sche
jbonofre commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2053708559
@manuzhang sure ! Let me update accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
manuzhang commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1564079903
##
.github/workflows/stale.yml:
##
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received an
marvinlanhenke commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1563872514
##
Cargo.toml:
##
@@ -21,6 +21,7 @@ members = [
"crates/catalog/*",
"crates/examples",
"crates/iceberg",
+"crates/integrations",
Review Co
jbonofre commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2053563062
We already have a property to determine if we create tables or not. But it's
not directly exposed easily to the users. Let me prepare a PR to improve this.
--
This is an automated m
jbonofre commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1563845762
##
.github/workflows/stale.yml:
##
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any
jbonofre commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2053562342
Sure thing. I can propose a PR during the weekend. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nastra commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2053550821
thanks @mrcnc, I'll take another look on monday. @jbonofre could you also
take a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
nastra commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1563814052
##
.github/workflows/stale.yml:
##
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any
56 matches
Mail list logo
