amogh-jahagirdar commented on code in PR #10133:
URL: https://github.com/apache/iceberg/pull/10133#discussion_r1564299266
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSchemaUtil.java:
##########
@@ -59,9 +59,7 @@ private SparkSchemaUtil() {}
* @return a Schema for the table, if found
*/
public static Schema schemaForTable(SparkSession spark, String name) {
- StructType sparkType = spark.table(name).schema();
- Type converted = SparkTypeVisitor.visit(sparkType, new
SparkTypeToType(sparkType));
- return new Schema(converted.asNestedType().asStructType().fields());
+ return convert(spark.table(name).schema());
Review Comment:
I'll just raise this separately since it's a small refactoring not directly
related to this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
