Fokko commented on code in PR #590:
URL: https://github.com/apache/iceberg-python/pull/590#discussion_r1564193928
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1122,12 +1121,12 @@ def project_table(
return result
-def to_requested_schema(requested_schema: Schema, file_schema: Schema, table:
pa.Table) -> pa.Table:
- struct_array = visit_with_partner(requested_schema, table,
ArrowProjectionVisitor(file_schema), ArrowAccessor(file_schema))
+def to_requested_schema(table: pa.Table, from_schema: Schema, to_schema:
Schema) -> pa.Table:
Review Comment:
This is a public method, so we're breaking the API here. Not sure if a
refactor justifies the the breaking change. Also, The `file_Schema` and
`requested_schema` are more informative to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
