syun64 commented on issue #600: URL: https://github.com/apache/iceberg-python/issues/600#issuecomment-2053740059
I think this is a great discussion item @kevinjqliu - thank you for raising this. I'm a bit torn between whether we (PyIceberg) should be responsible for creating separate instances of Tables specific to that snapshot_id like you suggest, or if the engines should be responsible for accepting the `snapshot_id` as an argument to their API, and pass the value to the [scan function](https://github.com/syun64/iceberg-python/blob/main/pyiceberg/table/__init__.py#L1212), which already supports the snapshot ID as an argument. For instance, the PolaRs scan function you shared takes the pyiceberg.Table as an arg, and it uses [pyiceberg.Table.scan](https://github.com/pola-rs/polars/blob/py-0.20.19/py-polars/polars/io/iceberg.py#L174), but it just doesn't utilize the rest of the function args it supports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
