marvinlanhenke commented on code in PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#discussion_r1547190841
##
crates/iceberg/src/scan.rs:
##
@@ -155,8 +189,22 @@ impl TableScan {
.await?;
// Generate data file stream
-let mut
Fokko merged PR #10071:
URL: https://github.com/apache/iceberg/pull/10071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
marvinlanhenke commented on code in PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#discussion_r1547190841
##
crates/iceberg/src/scan.rs:
##
@@ -155,8 +189,22 @@ impl TableScan {
.await?;
// Generate data file stream
-let mut
marvinlanhenke commented on PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#issuecomment-2031169057
@liurenjie1024 @ZENOTME @sdd @Xuanwo
I'd really appreciate your thoughts on this:
I took a closer look at the work @sdd has already done - and I think in
order to proc
marvinlanhenke commented on code in PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#discussion_r1547117184
##
crates/iceberg/src/scan.rs:
##
@@ -214,326 +272,559 @@ impl FileScanTask {
}
}
-#[cfg(test)]
-mod tests {
-use crate::io::{FileIO, OutputFile};
pvary commented on code in PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547189727
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata
meta
manuzhang commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1547081267
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##
@@ -232,4 +232,25 @@ public void testMigrateEmpt
rtadepalli commented on PR #68:
URL: https://github.com/apache/iceberg-go/pull/68#issuecomment-2030993475
@zeroshade can you please take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
manuzhang commented on code in PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547080134
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata
ZENOTME commented on code in PR #277:
URL: https://github.com/apache/iceberg-rust/pull/277#discussion_r1547039753
##
crates/iceberg/src/arrow.rs:
##
@@ -106,3 +114,224 @@ impl ArrowReader {
ProjectionMask::all()
}
}
+
+/// The key of column id in the metadata of a
manuzhang commented on issue #10076:
URL: https://github.com/apache/iceberg/issues/10076#issuecomment-2030918741
I don't see where you have configured `write.upsert.enabled=true` which is
required for Flink upsert.
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on issue #2387:
URL: https://github.com/apache/iceberg/issues/2387#issuecomment-2030829689
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2378:
URL: https://github.com/apache/iceberg/issues/2378#issuecomment-2030829663
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2391:
URL: https://github.com/apache/iceberg/issues/2391#issuecomment-2030829706
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2383:
URL: https://github.com/apache/iceberg/issues/2383#issuecomment-2030829677
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2377:
URL: https://github.com/apache/iceberg/issues/2377#issuecomment-2030829646
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2375:
URL: https://github.com/apache/iceberg/issues/2375#issuecomment-2030829625
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2374:
URL: https://github.com/apache/iceberg/issues/2374#issuecomment-2030829604
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2373:
URL: https://github.com/apache/iceberg/issues/2373#issuecomment-2030829582
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1546625002
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546861608
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2991,76 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546861228
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2991,76 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1524301299
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2978,63 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1524301299
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2978,63 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
amogh-jahagirdar commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546964523
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,113 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{p
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1524301299
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2978,63 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546955885
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546944082
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,113 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/na
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546882126
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2991,76 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546878684
##
open-api/rest-catalog-open-api.yaml:
##
@@ -3804,6 +4042,21 @@ components:
}
}
+UnprocessableEntityResponse:
+ description:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546878116
##
open-api/rest-catalog-open-api.yaml:
##
@@ -3804,6 +4042,21 @@ components:
}
}
+UnprocessableEntityResponse:
+ description:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546862202
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2991,76 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546861906
##
open-api/rest-catalog-open-api.yaml:
##
@@ -3789,6 +4012,21 @@ components:
EmptyResponse:
$ref: '#/components/examples/ListNamespacesEmpt
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546861608
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2991,76 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546861228
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +2991,76 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546845493
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2106,6 +2213,32 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546831783
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2106,6 +2213,32 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
RussellSpitzer commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1546825628
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##
@@ -232,4 +232,25 @@ public void testMigrat
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1546824945
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2106,6 +2213,32 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
RussellSpitzer commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1546814116
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##
@@ -232,4 +232,25 @@ public void testMigrat
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1546625002
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1546625002
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
viirya commented on PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#issuecomment-2030175699
@liurenjie1024 It is ready for review. I will fix the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
harishch1998 commented on code in PR #10052:
URL: https://github.com/apache/iceberg/pull/10052#discussion_r1546587898
##
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##
@@ -468,6 +486,20 @@ public Builder uri(String path) {
return this;
}
+public
jbonofre commented on issue #10068:
URL: https://github.com/apache/iceberg/issues/10068#issuecomment-2030087295
@pp-akursar yes, that's expected for `LIMIT` as the syntax depends of the
database backend (dialect).
Currently, JDBC Catalog is "guarantee" to work with SqlLite and Postgre
kevinjqliu commented on issue #515:
URL: https://github.com/apache/iceberg-python/issues/515#issuecomment-2030042131
@geruh thanks for the explanation! Would you say this is a bug in how
pyiceberg configures S3? I'm not familiar with the AWS profile config. It seems
like if a profile config
pp-akursar commented on issue #10068:
URL: https://github.com/apache/iceberg/issues/10068#issuecomment-2030028690
`jdbc.schema-version=V0` workaround gets past initialization, but LIMIT
clause elsewhere causes problems
```
UncheckedSQLException: Failed to execute exists query: SELE
HonahX merged PR #568:
URL: https://github.com/apache/iceberg-python/pull/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
zhongyujiang commented on issue #7771:
URL: https://github.com/apache/iceberg/issues/7771#issuecomment-2029673825
@va-bo-101 Just created #10074 to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
zhongyujiang commented on PR #10074:
URL: https://github.com/apache/iceberg/pull/10074#issuecomment-2029671208
@amogh-jahagirdar @aokolnychyi @RussellSpitzer can you please review this?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
marvinlanhenke commented on PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029473672
> Hi, @marvinlanhenke I skimmed through the code and it seems that we only
need to split tests into separate modules to make it easier to maintain and
read. But I agree that we
liurenjie1024 commented on PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029468475
Hi, @marvinlanhenke I skimmed through the code and it seems that we only
need to split tests into separate modules to make it easier to maintain and
read. But I agree that we can
marvinlanhenke commented on PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029456431
> > @Fokko @liurenjie1024 PTAL
> > I ported all the tests - and fixed #311. Now, all tests are passing and
align with the Java implementation. I think we only can optimize the
liurenjie1024 commented on PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029440339
> @Fokko @liurenjie1024 PTAL
>
> I ported all the tests - and fixed #311. Now, all tests are passing and
align with the Java implementation. I think we only can optimize th
ggershinsky commented on PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#issuecomment-2029437907
Yep, this is due to
https://github.com/apache/iceberg/blob/main/format/gcm-stream-spec.md#file-length
. There are options for table modification attacks if this field is not
(safely)
ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1546126748
##
core/src/test/java/org/apache/iceberg/TestManifestListEncryption.java:
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
marvinlanhenke commented on PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029426833
@Fokko @liurenjie1024
PTAL
I ported all the tests - and fixed #311. Now, all tests are passing and
align with the Java implementation.
I think we only can optimize
ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1546070409
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -93,6 +95,16 @@ static void toJson(Snapshot snapshot, JsonGenerator
generator) throws IOExcepti
liurenjie1024 commented on PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#issuecomment-2029306991
cc @viirya Is this ready for review or you still need to do more update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
liurenjie1024 merged PR #312:
URL: https://github.com/apache/iceberg-rust/pull/312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 closed issue #311: Bug: `fn day_timestamp_micro` produces wrong
results
URL: https://github.com/apache/iceberg-rust/issues/311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
liurenjie1024 commented on issue #311:
URL: https://github.com/apache/iceberg-rust/issues/311#issuecomment-2029287945
> @liurenjie1024 ...while looking at it - I think we need to handle `Year,
Month, and Hours` as well? The Java implementation does the same thing for all
granularities.
62 matches
Mail list logo
