RussellSpitzer commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1546825628
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##########
@@ -232,4 +232,25 @@ public void testMigrateEmptyTable() throws Exception {
Object result = scalarSql("CALL %s.system.migrate('%s')", catalogName,
tableName);
assertThat(result).isEqualTo(0L);
}
+
+ @TestTemplate
+ public void testMigrateWithParallelism() throws IOException {
+ assumeThat(catalogName).isEqualToIgnoringCase("spark_catalog");
+ String location = Files.createTempDirectory(temp,
"junit").toFile().toString();
+ for (int p = -1; p <= 2; p++) {
Review Comment:
Quick test style as well, if I want to test multiple cases and the framework
doesn't support parameterization of the individual tests I would do something
like
```
def body(parameter) {
outcome = thing()
assert expected = outcome
}
```
```
def testIllegal() {
assert(body(-1)).throws
}
def testValid() {
body(1)
body(10)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
