pvary commented on code in PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547189727
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
throw e;
} catch (Throwable e) {
- if (e.getMessage()
- .contains(
+ if (e.getMessage() != null
Review Comment:
Where would we use this new method?
If we would use it only in this class, and only in 2 places, then I think it
is better not to "hide" what we do behind a method somewhere else in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
